You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/16 14:43:59 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1899: fix: invalid import issues
juzhiyuan opened a new pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
This PR aims to fix the broken Route creator, this issue is caused by the invalid import path, and when run building, we don't have a checker to check this.
To prevent from this occasionally case, we may could have `Husky` enabled and check paths.
**Related issues**
fix https://github.com/apache/apisix-dashboard/issues/1889
**Checklist:**
- [x] Did you explain what problem does this PR solves? Or what new features have been added?
- [x] Have you added corresponding test cases? **No need for this issue**
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841829761
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1899](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bd58fe) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e14cb8c952ac854b15c9b5be27bebefa40d79165?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e14cb8c) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
+ Coverage 68.85% 68.91% +0.06%
==========================================
Files 122 122
Lines 3111 3111
Branches 745 745
==========================================
+ Hits 2142 2144 +2
+ Misses 969 967 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `68.91% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | `86.95% <ø> (ø)` | |
| [web/src/components/PluginFlow/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29uc3RhbnRzLnRz) | `29.03% <ø> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e14cb8c...2bd58fe](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841829761
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1899](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bd58fe) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e14cb8c952ac854b15c9b5be27bebefa40d79165?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e14cb8c) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
+ Coverage 68.85% 68.91% +0.06%
==========================================
Files 122 122
Lines 3111 3111
Branches 745 745
==========================================
+ Hits 2142 2144 +2
+ Misses 969 967 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `68.91% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | `86.95% <ø> (ø)` | |
| [web/src/components/PluginFlow/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvY29uc3RhbnRzLnRz) | `29.03% <ø> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e14cb8c...2bd58fe](https://codecov.io/gh/apache/apisix-dashboard/pull/1899?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1899: fix: invalid import issues
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841827057
Deploy preview for *apisix-dashboard* processing.
Building with commit 2bd58fe1c4bdee2f73c7d107e9be13722d8c20c8
https://app.netlify.com/sites/apisix-dashboard/deploys/60a12fa607855700084db29d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841829529
It would be great to have a checker here:
1. We could enable Husky to check pre-commit;
2. When changed files contain local cache paths, like `@/.umi/xx`, just throw errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841827057
Deploy preview for *apisix-dashboard* ready!
Built with commit 2bd58fe1c4bdee2f73c7d107e9be13722d8c20c8
https://deploy-preview-1899--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Yiyiyimu commented on pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841922941
> Hi @Yiyiyimu, this PR just fixed an incorrect path-import, so I request you to review it.
Got it. Approved 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841827057
Deploy preview for *apisix-dashboard* ready!
Built with commit 2bd58fe1c4bdee2f73c7d107e9be13722d8c20c8
https://deploy-preview-1899--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1899: fix: invalid import issues
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841827057
Deploy preview for *apisix-dashboard* processing.
Building with commit 2bd58fe1c4bdee2f73c7d107e9be13722d8c20c8
https://app.netlify.com/sites/apisix-dashboard/deploys/60a12fa607855700084db29d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841911627
Hi @Yiyiyimu, this PR just fixed an incorrect path-import, so I request you to review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Yiyiyimu commented on pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841922941
> Hi @Yiyiyimu, this PR just fixed an incorrect path-import, so I request you to review it.
Got it. Approved 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1899: fix: incorrect import paths
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1899: fix: invalid import issues
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841828074
Waiting for GitHub Action to be fixed. https://www.githubstatus.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1899: fix: invalid import issues
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1899:
URL: https://github.com/apache/apisix-dashboard/pull/1899#issuecomment-841828074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org