[jira] [Commented] (HADOOP-18980) S3A credential provider remapping: make extensible

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813113#comment-17813113 ] 

ASF GitHub Bot commented on HADOOP-18980:
-----------------------------------------

virajjasani commented on code in PR #6406:
URL: https://github.com/apache/hadoop/pull/6406#discussion_r1474046258


##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java:
##########
@@ -2716,4 +2716,72 @@ public void testConcurrentModificationDuringIteration() throws InterruptedExcept
 
     assertFalse("ConcurrentModificationException occurred", exceptionOccurred.get());
   }
+
+  @Test
+  public void testStringCollectionSplitByEquals() {
+    Configuration conf = new Configuration();
+    conf.set("custom_key", "");
+    Map<String, String> splitMap =
+        conf.getTrimmedStringCollectionSplitByEquals("custom_key");
+    Assertions

Review Comment:
   Done, btw TestConfiguration changes are removed after reverting Configuration class changes as per your previous feedback.





> S3A credential provider remapping: make extensible
> --------------------------------------------------
>
>                 Key: HADOOP-18980
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18980
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Steve Loughran
>            Assignee: Viraj Jasani
>            Priority: Minor
>              Labels: pull-request-available
>
> s3afs will now remap the common com.amazonaws credential providers to equivalents in the v2 sdk or in hadoop-aws
> We could do the same for third party credential providers by taking a key=value list in a configuration property and adding to the map. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org