You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/10 12:50:31 UTC
[GitHub] [flink] dawidwys opened a new pull request #10512:
[FLINK-15092][java,
table] Remove the restriction that GenericCsvInputFormat expects at least
one parser
dawidwys opened a new pull request #10512: [FLINK-15092][java, table] Remove the restriction that GenericCsvInputFormat expects at least one parser
URL: https://github.com/apache/flink/pull/10512
## What is the purpose of the change
GenericCsvInputFormat (and CsvInputFormat, RowCsvInputFormat
transitevely) had an artificial restriction that at least one parser
must have been provided. This is a limitation for a proper support of
projection pushdown in flink-table, when no fields from the input are
required. This lead to a safety condition check in PushProjectIntoTableSourceScanRule failing.
As part of this commit a TableSourceTestBase class was introduced where
we can check if table sourcec meet such requirements.
## Verifying this change
This change added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services