[jira] [Comment Edited] (HBASE-10771) Primitive type put/get APIs in ByteRange

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986823#comment-13986823 ] 

Andrew Purtell edited comment on HBASE-10771 at 5/1/14 6:07 PM:
----------------------------------------------------------------

Visually the get* and put* methods look small enough to be inlineable, but have you confirmed with -XX:+PrintCompilation -XX:+UnlockDiagnosticVMOptions -XX:+PrintInlining ?

Edit: Use -Xcomp also to skip warmup and profiling issues. We want to test if it's possible to inline the methods in as many cases as we can trigger. 

Edit 2: Any chance of a unit test that builds and unpacks various structures using the new classes and methods, say 1M times in a loop? Bonus points if it is Cells in HFileBlocks. 


was (Author: apurtell):
Visually the get* and put* methods look small enough to be inlineable, but have you confirmed with -XX:+PrintCompilation -XX:+UnlockDiagnosticVMOptions -XX:+PrintInlining ?

> Primitive type put/get APIs in ByteRange 
> -----------------------------------------
>
>                 Key: HBASE-10771
>                 URL: https://issues.apache.org/jira/browse/HBASE-10771
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10771.patch, HBASE-10771_V2.patch, HBASE-10771_V3.patch
>
>
> While doing HBASE-10713 I came across the need to write int/long (and read also) from a ByteRange.  CellBlocks are backed by ByteRange. So we can add such APIs.
> Also as per HBASE-10750  we return a ByteRange from MSLAB and also discussion under HBASE-10191 suggest we can have BR backed HFileBlocks etc.  



--
This message was sent by Atlassian JIRA
(v6.2#6252)