[GitHub] xinyu-intel commented on a change in pull request #11335: Fix axis Bug in MKLDNN Softmax

[GitBox <gi...@apache.org>]

xinyu-intel commented on a change in pull request #11335: Fix axis Bug in MKLDNN Softmax
URL: https://github.com/apache/incubator-mxnet/pull/11335#discussion_r196372967
 
 

 ##########
 File path: src/operator/nn/softmax.cc
 ##########
 @@ -38,10 +38,9 @@ static void SoftmaxComputeExCPU(const nnvm::NodeAttrs& attrs,
                                 const std::vector<NDArray>& inputs,
                                 const std::vector<OpReqType>& req,
                                 const std::vector<NDArray>& outputs) {
-  const SoftmaxParam& param = nnvm::get<SoftmaxParam>(attrs.parsed);
   // It seems MKLDNN softmax doesn't support training.
   // and it only supports non-negative axis.
 
 Review comment:
   We are not using the latest MKLDNN.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services