You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by Cazen <gi...@git.apache.org> on 2016/03/19 09:31:47 UTC
[GitHub] incubator-quarks-website pull request: [QUARKS-45] [WIP] Change do...
GitHub user Cazen opened a pull request:
https://github.com/apache/incubator-quarks-website/pull/11
[QUARKS-45] [WIP] Change documentation banner links to point to correct locations for Apache
1. In header.html
- Home
Change pointing from #home to {{ site.projurl }}/
I hope site.projurl will change from http://quarks-edge.github.io/quarks/ to http://quarks.incubator.apache.org/
But please notify me if this argument is wrong.
2. In mydoc_topnav.yml
- Github Repos
Change pointing from https://github.com/quarks-edge to https://github.com/apache/incubator-quarks
- Download in Quarks Resources
Change pointing from https://github.com/quarks-edge/quarks/releases/latest to https://github.com/apache/incubator-quarks/releases
But I think It's better make apache-release faster(QUARKS-46) than using this URL
3. In feedback.html
- Feedback
Change pointing from https://github.com/quarks-edge/quarks.documentation/issues/new to mailto:dev@quarks.incubator.apache.org
Because logo in this TopNavi is mailling picture
Futher discussion
- I couldn't link JAVADOC page because gh-pages branch not exist in incubator-quarks. I will create Jira issue for create branch and init JAVADOC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Cazen/incubator-quarks-website QUARKS-45
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks-website/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit f4e217945f86fbe24c97a06e717a30b7df86b0ba
Author: Cazen <ca...@korea.com>
Date: 2016-03-19T08:18:11Z
Modify Github Repos, Javadoc, Download in Quarks Resources, Feedback Link
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-45] Change document...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/11#issuecomment-199565009
Thank you for merge!
Have a good day :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-45] [WIP] Change do...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/11#issuecomment-199162693
I'm sorry but I have a confusion in requirement #1. Please tell me if my works are wrong
- I see it will open in http://quarks.incubator.apache.org/. Then, the Home button should have http://quarks.incubator.apache.org/#home
- And I've applied dropdown menu to Github Repos in documentation
Thank you very much
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-45] [WIP] Change do...
Posted by kmarsden <gi...@git.apache.org>.
Github user kmarsden commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/11#issuecomment-199256126
Sorry I wasn't clear about requirement 1. What I was getting at was that somewhere in the documentation banner, it would be good to have a link to the top level website, but that is not really necessary as part of this Jira, so the relative path for #home was ok and didn't need to be changed, but the change does no harm as far as I can tell.
That said, I tried your pull request and, as is, it works great and is a huge improvement, so I suggest you take the [WIP] off and a committer commit it straight away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-45] Change document...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quarks-website/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-45] [WIP] Change do...
Posted by kmarsden <gi...@git.apache.org>.
Github user kmarsden commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/11#issuecomment-198729052
Thanks for these changes. As is, they are a big improvement.
1) Is it possible to separate the house home which would point to site.projurl and the words "documentation home" which would continue to point to #home (the top of the documentation)? It would be nice to have both.
2) It would be nice to have a drop down with both the source code and the web site/doc repos.
3) I think the dev list is good. I think it will encourage feedback more than linking to
Jira.
Javadoc. Thanks for filing QUARKS-48 for the javadoc. Let's pickup the conversation about that there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-45] [WIP] Change do...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/11#issuecomment-199260069
Thank you @kmarsden for detail review.
Now I understand your intends about banner. I will try it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-45] [WIP] Change do...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/11#issuecomment-198668234
@kmarsden Nice to meet you! Could you please take a look?
I think it need further modification. I will very happy if you give me some advice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: [QUARKS-45] Change document...
Posted by kmarsden <gi...@git.apache.org>.
Github user kmarsden commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/11#issuecomment-199553831
Could a committer merge this pull request? I think it is important for the links to work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---