You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/25 04:00:45 UTC
[GitHub] [airflow] potiuk opened a new pull request #14998: Fixes problem with two different files mdsumed with the same name
potiuk opened a new pull request #14998:
URL: https://github.com/apache/airflow/pull/14998
When we check whether we should rebuild image, we check if the
md5sum of some important files changed - which would trigger
question whether to rebuild the image or not (because of
changed dependencies which need to be installed). This
happens for example when package.json or yarn.lock changes.
Previously, all the important files had distinct names, so
we stored the md5 hashes of those files with just filenames +.md5sum
but they were flattened to a single directory. Unfortunately,
as of #14927 (merged with failing build) we had two package.json
and two yarn.locks and it caused overwriting of md5hash of one
by the other. This triggered unnecessary rebuilding of the image
in CI part which resulted in failure (because of Apache Beam
dependency problem).
This PR fixes it by adding parent directory to the name of
the md5sum file (so we have www-package.json and ui-package.json)
now. Those important files change very rarely so this incident
should not happen again but we added some comments preventing
it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14998: Fixes problem with two different files mdsumed with the same name
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14998:
URL: https://github.com/apache/airflow/pull/14998#issuecomment-806439967
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on a change in pull request #14998: Fixes problem with two different files mdsumed with the same name
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #14998:
URL: https://github.com/apache/airflow/pull/14998#discussion_r601176365
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -186,6 +186,19 @@ function initialization::initialize_available_integrations() {
FILES_FOR_REBUILD_CHECK=()
# Determine which files trigger rebuild check
+#
+# !!!! IMPORTANT NOTE !!!!!!!!!!!!!!!!!!!!!!!!1
+# When you add files here, please make sure to not add files
+# with the same name. And if you do - make sure that files with the
+# same name are stored in directories with different name. For
+# example we hava two package.json files here, but they are in
+# directories with different names (`wwww` and `ui`).
+# The problem is that md5 hashes of those files are stored in
+# ./build/directory in the same directory as <PARENT_DIR>-<FILE>.md5sum .
+# For example md5sum of the `airflow/www/package.json` file is stored
+# as `www-package.json` and `airflow/ui/package.json` as `ui-package.json`,
+# The file list here changes extremely rarely.
+# !!!! IMPORTANT NOTE !!!!!!!!!!!!!!!!!!!!!!!!1
Review comment:
```suggestion
# !!!!!!!!!! IMPORTANT NOTE !!!!!!!!!!
# When you add files here, please make sure to not add files
# with the same name. And if you do - make sure that files with the
# same name are stored in directories with different name. For
# example we have two package.json files here, but they are in
# directories with different names (`www` and `ui`).
# The problem is that md5 hashes of those files are stored in
# `./build/directory` in the same directory as <PARENT_DIR>-<FILE>.md5sum.
# For example md5sum of the `airflow/www/package.json` file is stored
# as `www-package.json` and `airflow/ui/package.json` as `ui-package.json`,
# The file list here changes extremely rarely.
# !!!!!!!!!! IMPORTANT NOTE !!!!!!!!!!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #14998: Fixes problem with two different files mdsumed with the same name
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #14998:
URL: https://github.com/apache/airflow/pull/14998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org