1.8.x branch freeze!

[Andrew Phillips <ap...@qrmedia.com>]

Hi all

Please consider the 1.8.x branches of all repos frozen as of now for  
the 1.8.1 release. I'm not actually going to be able to get the  
releases started for an hour or so, so please shout if there's  
something you urgently still need to get in...

Regards

ap

Re: 1.8.x branch freeze!

[Ignasi Barrera <na...@apache.org>]

I'd say proceed without the changes. As Everett pointed in previous
comments there will always be pull requests to merge and reasons to delay
the release.

This is a minor, and don't see those PRs as blocker, so I think we should
proceed with the release.
El 08/10/2014 18:32, "Adrian Cole" <ad...@gmail.com> escribió:

> PS 2 of the 3 Inbar PRs need change. One trivially. There's a jewish
> holiday that prevents him from changing these today. Either we change
> on his behalf, delay or proceed.
>
> Anyone have a preference?
> -A
>
> On Wed, Oct 8, 2014 at 7:33 AM, Andrew Phillips <ap...@qrmedia.com>
> wrote:
> >> If the release hasn't already started, I might see if these are easy
> >> merges. Has the release lever been pulled?
> >
> >
> > Nope, there's still time. I'll hold until those PRs are in unless we
> uncover
> > something major in them that needs more time.
> >
> > Thanks for raising this!
> >
> > ap
>

Re: 1.8.x branch freeze!

[Adrian Cole <ad...@gmail.com>]

Here's the feedback which I think says "go" anyway. Let's please
prioritize ending the madness of the terrible ConcreteBuilder crap in
the next version or two so folks don't accidentally emulate it then
feel torn being asked to undo it.

---
There is no problem closing the PR and openning a new one on master.
Its not life and death as far as these api goes.
Plus you guys are ripping me a new one on the code review lol :D

Although regarding the extention api I think that making the
parameters nulleble will make the code simpler and easier to manage
(consider muti types of extention on one api you wont see the end of
it regarding enharetance classes for extentions (i am talking about PR
562... )


On Wed, Oct 8, 2014 at 10:56 AM, Andrew Phillips <ap...@qrmedia.com> wrote:
>> Yes he is :) Unfortunately his email are being rejected on spam score,
>> so I am channeling Inbar.
>
>
> I see 561 and 559 [1, 2] are in - were those the two you were referring to?
> If so, time to pull the levers!
>
> ap
>
> [1] https://github.com/jclouds/jclouds/pull/561
> [2] https://github.com/jclouds/jclouds/pull/559

Re: 1.8.x branch freeze!

[Andrew Phillips <ap...@qrmedia.com>]

> Yes he is :) Unfortunately his email are being rejected on spam score,
> so I am channeling Inbar.

I see 561 and 559 [1, 2] are in - were those the two you were  
referring to? If so, time to pull the levers!

ap

[1] https://github.com/jclouds/jclouds/pull/561
[2] https://github.com/jclouds/jclouds/pull/559

Re: 1.8.x branch freeze!

[Adrian Cole <ad...@gmail.com>]

Yes he is :) Unfortunately his email are being rejected on spam score,
so I am channeling Inbar.

-A

On Wed, Oct 8, 2014 at 9:39 AM, Andrew Phillips <ap...@qrmedia.com> wrote:
>> Either we change on his behalf, delay or proceed.
>
>
> Is he OK with us modifying? If so, I'm happy to wait for those to come in.
>
> ap

Re: 1.8.x branch freeze!

[Andrew Phillips <ap...@qrmedia.com>]

> Either we change on his behalf, delay or proceed.

Is he OK with us modifying? If so, I'm happy to wait for those to come in.

ap

Re: 1.8.x branch freeze!

[Adrian Cole <ad...@gmail.com>]

PS 2 of the 3 Inbar PRs need change. One trivially. There's a jewish
holiday that prevents him from changing these today. Either we change
on his behalf, delay or proceed.

Anyone have a preference?
-A

On Wed, Oct 8, 2014 at 7:33 AM, Andrew Phillips <ap...@qrmedia.com> wrote:
>> If the release hasn't already started, I might see if these are easy
>> merges. Has the release lever been pulled?
>
>
> Nope, there's still time. I'll hold until those PRs are in unless we uncover
> something major in them that needs more time.
>
> Thanks for raising this!
>
> ap

Re: 1.8.x branch freeze!

[Andrew Phillips <ap...@qrmedia.com>]

> If the release hasn't already started, I might see if these are easy
> merges. Has the release lever been pulled?

Nope, there's still time. I'll hold until those PRs are in unless we  
uncover something major in them that needs more time.

Thanks for raising this!

ap

Re: 1.8.x branch freeze!

[Adrian Cole <ad...@gmail.com>]

Inbar from CloudBand raised 3 pull requests last night 2 having to do with
fields like zone and tenent in the OpenStack codebase in jclouds/jclouds.
If the release hasn't already started, I might see if these are easy
merges. Has the release lever been pulled?

-A
Hi all

Please consider the 1.8.x branches of all repos frozen as of now for the
1.8.1 release. I'm not actually going to be able to get the releases
started for an hour or so, so please shout if there's something you
urgently still need to get in...

Regards

ap