You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Kousuke Saruta (Code Review)" <ge...@cloudera.org> on 2016/11/22 09:13:25 UTC
[kudu-CR] Enforce LANG=C to check the version of compiler.
Kousuke Saruta has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5175
Change subject: Enforce LANG=C to check the version of compiler.
......................................................................
Enforce LANG=C to check the version of compiler.
Otherwise, extracting compiler information could fail.
Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5175/1
--
To view, visit http://gerrit.cloudera.org:8080/5175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
[kudu-CR] Enforce LANG=C to check the version of compiler. Otherwise, extracting compiler information could fail. One example is here (built on CentOS 7).
Posted by "Kousuke Saruta (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5175
to look at the new patch set (#2).
Change subject: Enforce LANG=C to check the version of compiler. Otherwise, extracting compiler information could fail. One example is here (built on CentOS 7).
......................................................................
Enforce LANG=C to check the version of compiler.
Otherwise, extracting compiler information could fail.
One example is here (built on CentOS 7).
LANG is not C
[sarutak@devel release]$ echo $LANG
ja_JP.UTF-8
check the output of `c++ -v` and you'll found it does not match the pattern ".*gcc version ([0-9\\.]+).*".
[sarutak@devel release]$ c++ -v
\u7d44\u307f\u8fbc\u307f spec \u3092\u4f7f\u7528\u3057\u3066\u3044\u307e\u3059\u3002
COLLECT_GCC=c++
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper
\u30bf\u30fc\u30b2\u30c3\u30c8: x86_64-redhat-linux
configure \u8a2d\u5b9a: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux
\u30b9\u30ec\u30c3\u30c9\u30e2\u30c7\u30eb: posix
gcc \u30d0\u30fc\u30b8\u30e7\u30f3 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)
Those conditions end up having a failure of cmake.
[kou@devel-mbp-centos7 release]$ ../../build-support/enable_devtoolset.sh ../../thirdparty/installed/common/bin/cmake -DCMAKE_BUILD_TYPE=release ../..
...
CMake Error at cmake_modules/CompilerInfo.cmake:51 (message):
Unknown compiler. Version info:
\u7d44\u307f\u8fbc\u307f spec \u3092\u4f7f\u7528\u3057\u3066\u3044\u307e\u3059\u3002
COLLECT_GCC=/usr/bin/c++
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper
\u30bf\u30fc\u30b2\u30c3\u30c8: x86_64-redhat-linux
configure \u8a2d\u5b9a: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla
--enable-bootstrap --enable-shared --enable-threads=posix
--enable-checking=release --with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-gnu-unique-object
--enable-linker-build-id --with-linker-hash-style=gnu
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto
--enable-plugin --enable-initfini-array --disable-libgcj
--with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install
--with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install
--enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64
--build=x86_64-redhat-linux
\u30b9\u30ec\u30c3\u30c9\u30e2\u30c7\u30eb: posix
gcc \u30d0\u30fc\u30b8\u30e7\u30f3 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)
Call Stack (most recent call first):
CMakeLists.txt:218 (include)
-- Configuring incomplete, errors occurred!
See also "/home/kou/work/kudu/build/release/CMakeFiles/CMakeOutput.log".
...
Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5175/2
--
To view, visit http://gerrit.cloudera.org:8080/5175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Enforce LANG=C to check the version of compiler.
Posted by "Kousuke Saruta (Code Review)" <ge...@cloudera.org>.
Kousuke Saruta has restored this change.
Change subject: Enforce LANG=C to check the version of compiler.
......................................................................
Restored
--
To view, visit http://gerrit.cloudera.org:8080/5175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: restore
Gerrit-Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Enforce LANG=C to check the version of compiler.
Posted by "Kousuke Saruta (Code Review)" <ge...@cloudera.org>.
Kousuke Saruta has abandoned this change.
Change subject: Enforce LANG=C to check the version of compiler.
......................................................................
Abandoned
It's wrong branch. I'll abandon this.
--
To view, visit http://gerrit.cloudera.org:8080/5175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Enforce LANG=C to check the version of compiler.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Enforce LANG=C to check the version of compiler.
......................................................................
Patch Set 1:
(1 comment)
Patch looks good, just left you a question.
http://gerrit.cloudera.org:8080/#/c/5175/1//COMMIT_MSG
Commit Message:
Line 9: Otherwise, extracting compiler information could fail.
Could you describe this in more detail? Maybe provide an example?
--
To view, visit http://gerrit.cloudera.org:8080/5175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Enforce LANG=C to check the version of compiler. Otherwise, extracting compiler information could fail. One example is here (built on CentOS 7).
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Enforce LANG=C to check the version of compiler. Otherwise, extracting compiler information could fail. One example is here (built on CentOS 7).
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Enforce LANG=C to check the version of compiler. Otherwise, extracting compiler information could fail. One example is here (built on CentOS 7).
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: Enforce LANG=C to check the version of compiler. Otherwise, extracting compiler information could fail. One example is here (built on CentOS 7).
......................................................................
Enforce LANG=C to check the version of compiler.
Otherwise, extracting compiler information could fail.
One example is here (built on CentOS 7).
LANG is not C
[sarutak@devel release]$ echo $LANG
ja_JP.UTF-8
check the output of `c++ -v` and you'll found it does not match the pattern ".*gcc version ([0-9\\.]+).*".
[sarutak@devel release]$ c++ -v
\u7d44\u307f\u8fbc\u307f spec \u3092\u4f7f\u7528\u3057\u3066\u3044\u307e\u3059\u3002
COLLECT_GCC=c++
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper
\u30bf\u30fc\u30b2\u30c3\u30c8: x86_64-redhat-linux
configure \u8a2d\u5b9a: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux
\u30b9\u30ec\u30c3\u30c9\u30e2\u30c7\u30eb: posix
gcc \u30d0\u30fc\u30b8\u30e7\u30f3 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)
Those conditions end up having a failure of cmake.
[kou@devel-mbp-centos7 release]$ ../../build-support/enable_devtoolset.sh ../../thirdparty/installed/common/bin/cmake -DCMAKE_BUILD_TYPE=release ../..
...
CMake Error at cmake_modules/CompilerInfo.cmake:51 (message):
Unknown compiler. Version info:
\u7d44\u307f\u8fbc\u307f spec \u3092\u4f7f\u7528\u3057\u3066\u3044\u307e\u3059\u3002
COLLECT_GCC=/usr/bin/c++
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper
\u30bf\u30fc\u30b2\u30c3\u30c8: x86_64-redhat-linux
configure \u8a2d\u5b9a: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla
--enable-bootstrap --enable-shared --enable-threads=posix
--enable-checking=release --with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-gnu-unique-object
--enable-linker-build-id --with-linker-hash-style=gnu
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto
--enable-plugin --enable-initfini-array --disable-libgcj
--with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install
--with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install
--enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64
--build=x86_64-redhat-linux
\u30b9\u30ec\u30c3\u30c9\u30e2\u30c7\u30eb: posix
gcc \u30d0\u30fc\u30b8\u30e7\u30f3 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)
Call Stack (most recent call first):
CMakeLists.txt:218 (include)
-- Configuring incomplete, errors occurred!
See also "/home/kou/work/kudu/build/release/CMakeFiles/CMakeOutput.log".
...
Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Reviewed-on: http://gerrit.cloudera.org:8080/5175
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins