[GitHub] [arrow] LouisClt commented on a diff in pull request #13737: ARROW-17214: [C++] Add scalar casts to string types for list based types

[GitBox <gi...@apache.org>]

LouisClt commented on code in PR #13737:
URL: https://github.com/apache/arrow/pull/13737#discussion_r933570685


##########
cpp/src/arrow/scalar.cc:
##########
@@ -1041,6 +1041,24 @@ Status CastImpl(const StructScalar& from, StringScalar* to) {
   return Status::OK();
 }
 
+// list based types (list, large list and map (fixed sized list too)) to string
+Status CastImpl(const BaseListScalar& from, StringScalar* to) {
+  std::stringstream ss;
+  ss << from.type->ToString() << "{";

Review Comment:
   Thanks, I merged your PR. Do you want to change "{}" for "[]" or is this OK ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org