You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Tibor Digana <ti...@apache.org> on 2017/06/18 00:15:05 UTC
Re: New Branch (report real sys props of forked JVM) SUREFIRE-1360
I have fixed https://issues.apache.org/jira/browse/SUREFIRE-1302 in branch
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=b9034a3bbb32a27a2d7b66e4d516c2dac61fce29
Tested and made debugging. Forked VM is killed immediately.
On Wed, Apr 26, 2017 at 3:38 AM, Tibor Digana <ti...@apache.org>
wrote:
> If we do not have time for this, can I proceed with pushing both branches
> SUREFIRE-1364 and SUREFIRE-1366?
>
> On Sun, Apr 23, 2017 at 9:50 PM, Tibor Digana <tibor.digana@googlemail.com
> > wrote:
>
>> @Michael,
>>
>> I had to override branch SUREFIRE-1366 because of some old code and
>> generated code had windows ending lines. Usually the branch changes <p/> to
>> <br> and <code> to <em> which is best to see in GitHub view:
>> https://github.com/apache/maven-surefire/commit/5745ba135522
>> dfe2307d67b4cf84a562fe240ac4
>> Sometimes a code was optimized because was reported that if statements
>> could be written in one line, some #equals(Object), and sometimes ignored
>> Javadoc on the top of class with @SuppressWarnings( { "javadoc", "
>> checkstyle:javadoctype" } ), POM's compiler has -Xdoclint:all, enforcer
>> has rule with jdk 1.8, and @see links in Javadoc with external links to
>> Jira, sometimes changed ">" to >.
>>
>> On Sun, Apr 23, 2017 at 10:42 AM, Tibor Digana <
>> tibor.digana@googlemail.com> wrote:
>>
>>> Hi Michael,
>>>
>>> No problem.
>>> I am glad that somebody helps me like you do.
>>>
>>> On Sun, Apr 23, 2017 at 10:36 AM, Michael Osipov <mi...@apache.org>
>>> wrote:
>>>
>>>> Am 2017-04-22 um 11:31 schrieb Tibor Digana:
>>>>
>>>>> Hi,
>>>>>
>>>>> I would like to push SUREFIRE-1364 and then fix jira issue
>>>>> SUREFIRE-1360
>>>>> which should help the users to speed up testing on cloud.
>>>>> Can we proceed?
>>>>>
>>>>>
>>>> I will need a day or two to check the branch. Please wait...
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>>>
>>>
>>> --
>>> Cheers
>>> Tibor
>>>
>>
>>
>>
>> --
>> Cheers
>> Tibor
>>
>
>
Re: New Branch (report real sys props of forked JVM) SUREFIRE-1360
Posted by Michael Osipov <mi...@apache.org>.
Tibor,
I have left a few comments on GitHub. Check the out. I'll run the ITs
too here.
Michael
Am 2017-06-18 um 02:15 schrieb Tibor Digana:
> I have fixed https://issues.apache.org/jira/browse/SUREFIRE-1302 in branch
> https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=b9034a3bbb32a27a2d7b66e4d516c2dac61fce29
> Tested and made debugging. Forked VM is killed immediately.
>
> On Wed, Apr 26, 2017 at 3:38 AM, Tibor Digana <ti...@apache.org>
> wrote:
>
>> If we do not have time for this, can I proceed with pushing both branches
>> SUREFIRE-1364 and SUREFIRE-1366?
>>
>> On Sun, Apr 23, 2017 at 9:50 PM, Tibor Digana <tibor.digana@googlemail.com
>>> wrote:
>>
>>> @Michael,
>>>
>>> I had to override branch SUREFIRE-1366 because of some old code and
>>> generated code had windows ending lines. Usually the branch changes <p/> to
>>> <br> and <code> to <em> which is best to see in GitHub view:
>>> https://github.com/apache/maven-surefire/commit/5745ba135522
>>> dfe2307d67b4cf84a562fe240ac4
>>> Sometimes a code was optimized because was reported that if statements
>>> could be written in one line, some #equals(Object), and sometimes ignored
>>> Javadoc on the top of class with @SuppressWarnings( { "javadoc", "
>>> checkstyle:javadoctype" } ), POM's compiler has -Xdoclint:all, enforcer
>>> has rule with jdk 1.8, and @see links in Javadoc with external links to
>>> Jira, sometimes changed ">" to >.
>>>
>>> On Sun, Apr 23, 2017 at 10:42 AM, Tibor Digana <
>>> tibor.digana@googlemail.com> wrote:
>>>
>>>> Hi Michael,
>>>>
>>>> No problem.
>>>> I am glad that somebody helps me like you do.
>>>>
>>>> On Sun, Apr 23, 2017 at 10:36 AM, Michael Osipov <mi...@apache.org>
>>>> wrote:
>>>>
>>>>> Am 2017-04-22 um 11:31 schrieb Tibor Digana:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I would like to push SUREFIRE-1364 and then fix jira issue
>>>>>> SUREFIRE-1360
>>>>>> which should help the users to speed up testing on cloud.
>>>>>> Can we proceed?
>>>>>>
>>>>>>
>>>>> I will need a day or two to check the branch. Please wait...
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Cheers
>>>> Tibor
>>>>
>>>
>>>
>>>
>>> --
>>> Cheers
>>> Tibor
>>>
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org