You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/04/29 14:19:21 UTC
[kudu-CR] [backup] Support column alterations between backups
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13173
Change subject: [backup] Support column alterations between backups
......................................................................
[backup] Support column alterations between backups
This patch adds support for column alterations between
backups and while restoring the data.
When restoring each backup, it leverages the column ID
map in the metadata to compare against the final
metadata. Using this it can detect and handle
added, dropped, and renamed columns.
Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 113 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/13173/1
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [backup] Support column alterations between backups
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 )
Change subject: [backup] Support column alterations between backups
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala:
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@171
PS1, Line 171: // Ignore the rowActionCol, which isn't a real column.
Nit: should probably indent this by 2 chars to emphasize that it applies to .filter()
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@181
PS1, Line 181: // TODO: is it possible to have rename collisions?
Should be possible to manually test this with a hacked up metadata file. Would be interesting to see how that manifests; is there an error somewhere?
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@287
PS1, Line 287: .addHashPartitions(List("key").asJava, 3)
Could be omitted; don't think the test cares about this.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@338
PS1, Line 338: an
and
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Apr 2019 22:26:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [backup] Support column alterations between backups
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 )
Change subject: [backup] Support column alterations between backups
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 01 May 2019 18:02:33 +0000
Gerrit-HasComments: No
[kudu-CR] [backup] Support column alterations between backups
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 )
Change subject: [backup] Support column alterations between backups
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13173/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala:
http://gerrit.cloudera.org:8080/#/c/13173/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@172
PS2, Line 172: .filter(_._1 != rowActionCol)
> You want this to show as error? Why not info?
Done
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@287
PS1, Line 287: .addHashPartitions(List("key").asJava, 3)
> You find this easier than .setRangePartitionColumns(List("key"))? I prefer
Done
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 12:55:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] [backup] Support column alterations between backups
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 )
Change subject: [backup] Support column alterations between backups
......................................................................
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/13173/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13173/1//COMMIT_MSG@10
PS1, Line 10: and while restoring the data
I think this part of the sentence should be omitted because it sounds like we will support users concurrently altering a table we are restoring into, but we won't.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala:
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@162
PS1, Line 162: handleAlteredColumns
nit: maybe call this projectSchema() or something like that since we are doing a schema projection?
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@177
PS1, Line 177: error
This should probably be info() and come with an explanation about why we are doing this, i.e. the column was dropped in-between incremental backups.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@181
PS1, Line 181: // TODO: is it possible to have rename collisions?
The answer to this question is that it is not possible to have an id collision and we should be doing a full projection from the old id => name mapping to the last metadata id => name mapping, so no collision is possible
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@182
PS1, Line 182: error
also info() with an explanation about why, something about restoring data where the column name was later altered or something like that
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@307
PS1, Line 307: .renameColumn("col_a", "col_1")
Can we also add a new column col_a that has the same name but (hopefully) a different id? That might require a separate DDL to achieve.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@321
PS1, Line 321: row.addInt("col_1", i)
Can we add some logic to detect bad rename handling? Basically instead of having all columns contain the same value we can have the first column be i * 1, 2nd column be set to i * 2, or something like that so that it's still easy to assert at the end but we would get more coverage.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@340
PS1, Line 340: assertEquals(expectedSet, rows.map(_.getInt("key")).toSet)
: assertEquals(expectedSet, rows.map(_.getInt("col_1")).toSet)
: assertEquals(expectedSet, rows.map(_.getInt("col_c")).toSet)
See comment above re. how these assertions can't differentiate between unique columns
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Apr 2019 22:34:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [backup] Support column alterations between backups
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 )
Change subject: [backup] Support column alterations between backups
......................................................................
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/13173/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13173/1//COMMIT_MSG@10
PS1, Line 10:
> I think this part of the sentence should be omitted because it sounds like
Done
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala:
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@162
PS1, Line 162: adjustSchema(
> nit: maybe call this projectSchema() or something like that since we are do
I am open to another name. I am not sure I want to use projectSchema since I am doing more than a simple projection by renaming columns. Maybe adjustSchema?
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@171
PS1, Line 171:
> Nit: should probably indent this by 2 chars to emphasize that it applies to
For some reason the scala formatter does this. :/
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@177
PS1, Line 177: ns.fo
> This should probably be info() and come with an explanation about why we ar
oops, I mean't to leave these in as Info logs to go along with the above "Adjusting columns to handle alterations" log.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@181
PS1, Line 181: log.info(s"Dropping the column $colName from backup data")
> The answer to this question is that it is not possible to have an id collis
I forgot about this todo.
I was trying to think through a scenario in which a column was dropped and added in such a way that I would try to rename an old column to a new column name that already existed in the DataFrame.
Something like dropping a later column and renaming an earlier one can cause this. Here is an example:
from: col_a, col_b, col_c
to col_c, col_b
In that scenario the rename would be processed first and either fail or the renamed column would be dropped right after being renamed. Spark just force the rename on collision, so the column gets dropped.
I think to handle all renames I need to be sure to do all the drops first. I will adjust this.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@182
PS1, Line 182: = re
> also info() with an explanation about why, something about restoring data w
see my earlier comment.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@287
PS1, Line 287: val options = new CreateTableOptions()
> Could be omitted; don't think the test cares about this.
I added this because some partition is required and this was easiest.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@307
PS1, Line 307: // columns don't occur when processing columns from left to right.
> Can we also add a new column col_a that has the same name but (hopefully) a
I do exactly this. See the addColumn on the next line.
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@321
PS1, Line 321: table = kuduClient.openTable(tableName)
> Can we add some logic to detect bad rename handling? Basically instead of h
Done
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 03:24:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [backup] Support column alterations between backups
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13173
to look at the new patch set (#2).
Change subject: [backup] Support column alterations between backups
......................................................................
[backup] Support column alterations between backups
This patch adds support for column alterations between
backups.
When restoring each backup, it leverages the column ID
map in the metadata to compare against the final
metadata. Using this it can detect and handle
added, dropped, and renamed columns.
Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 124 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/13173/2
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [backup] Support column alterations between backups
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 )
Change subject: [backup] Support column alterations between backups
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 22:16:57 +0000
Gerrit-HasComments: No
[kudu-CR] [backup] Support column alterations between backups
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13173
to look at the new patch set (#3).
Change subject: [backup] Support column alterations between backups
......................................................................
[backup] Support column alterations between backups
This patch adds support for column alterations between
backups.
When restoring each backup, it leverages the column ID
map in the metadata to compare against the final
metadata. Using this it can detect and handle
added, dropped, and renamed columns.
Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 121 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/13173/3
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [backup] Support column alterations between backups
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 )
Change subject: [backup] Support column alterations between backups
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13173/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala:
http://gerrit.cloudera.org:8080/#/c/13173/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@172
PS2, Line 172: log.error(s"currentColumns: $currentColumns")
You want this to show as error? Why not info?
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@287
PS1, Line 287: val options = new CreateTableOptions()
> I added this because some partition is required and this was easiest.
You find this easier than .setRangePartitionColumns(List("key"))? I prefer that because it means, when reviewing the test, you don't have to remember the detail of there being 3 buckets thinking it might prove important later on.
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 04:00:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [backup] Support column alterations between backups
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13173 )
Change subject: [backup] Support column alterations between backups
......................................................................
[backup] Support column alterations between backups
This patch adds support for column alterations between
backups.
When restoring each backup, it leverages the column ID
map in the metadata to compare against the final
metadata. Using this it can detect and handle
added, dropped, and renamed columns.
Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Reviewed-on: http://gerrit.cloudera.org:8080/13173
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 121 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, but someone else must approve
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03
Gerrit-Change-Number: 13173
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>