You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/06/19 08:35:36 UTC
[GitHub] [dubbo-go-pixiu] ma642 opened a new pull request, #446: WIP: deploy pixiu as dubbo service egress gateway in k8s istio
ma642 opened a new pull request, #446:
URL: https://github.com/apache/dubbo-go-pixiu/pull/446
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ma642 commented on a diff in pull request #446: deploy pixiu as dubbo service egress gateway in k8s istio
Posted by GitBox <gi...@apache.org>.
ma642 commented on code in PR #446:
URL: https://github.com/apache/dubbo-go-pixiu/pull/446#discussion_r967814491
##########
pkg/config/xds/apiclient/grpc_envoy.go:
##########
@@ -0,0 +1,446 @@
+/*
Review Comment:
it's xDS client like envoy over grpc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #446: deploy pixiu as dubbo service egress gateway in k8s istio
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #446:
URL: https://github.com/apache/dubbo-go-pixiu/pull/446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] baerwang commented on a diff in pull request #446: deploy pixiu as dubbo service egress gateway in k8s istio
Posted by GitBox <gi...@apache.org>.
baerwang commented on code in PR #446:
URL: https://github.com/apache/dubbo-go-pixiu/pull/446#discussion_r952316733
##########
pkg/config/xds/xds.go:
##########
@@ -54,20 +56,58 @@ type (
func (a *Xds) createApiManager(config *model.ApiConfigSource,
node *model.Node,
- resourceTypes ...apiclient.ResourceTypeName) DiscoverApi {
+ resourceType apiclient.ResourceTypeName) DiscoverApi {
if config == nil {
return nil
}
switch config.APIType {
case model.ApiTypeGRPC:
- return apiclient.CreateGrpcApiClient(config, node, a.exitCh, resourceTypes...)
+ return apiclient.CreateGrpExtensionApiClient(config, node, a.exitCh, resourceType)
+ case model.ApiTypeIstioGRPC:
+ dubboServices, api, done := a.readDubboServiceFromListener()
+ if done {
+ return api
+ }
+ return apiclient.CreateEnvoyGrpcApiClient(config, node, a.exitCh, resourceType, apiclient.WithIstioService(dubboServices...))
default:
logger.Errorf("un-support the api type %s", config.APITypeStr)
return nil
}
}
+func (a *Xds) readDubboServiceFromListener() ([]string, DiscoverApi, bool) {
+ dubboServices := make([]string, 0)
Review Comment:
```go
listeners, err := a.listenerMg.CloneXdsControlListener()
if err != nil {
logger.Errorf("can not read listener. %v", err)
return nil, nil, true
}
dubboServices := make([]string, 0)
```
##########
pkg/config/xds/xds.go:
##########
@@ -18,6 +18,8 @@
package xds
import (
+ "github.com/apache/dubbo-go-pixiu/pkg/common/constant"
+ "github.com/mitchellh/mapstructure"
Review Comment:
import style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #446: WIP: deploy pixiu as dubbo service egress gateway in k8s istio
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #446:
URL: https://github.com/apache/dubbo-go-pixiu/pull/446#issuecomment-1207371256
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#446](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4895bc) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/28e040d46a0c754c2390944334d003817fe1e336?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28e040d) will **decrease** coverage by `2.40%`.
> The diff coverage is `1.67%`.
```diff
@@ Coverage Diff @@
## develop #446 +/- ##
===========================================
- Coverage 37.26% 34.85% -2.41%
===========================================
Files 56 57 +1
Lines 3805 4068 +263
===========================================
Hits 1418 1418
- Misses 2224 2487 +263
Partials 163 163
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...registry/zookeeper/application\_service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <ø> (ø)` | |
| [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `42.85% <0.00%> (-1.74%)` | :arrow_down: |
| [pkg/config/xds/apiclient/apiclient.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy94ZHMvYXBpY2xpZW50L2FwaWNsaWVudC5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/config/xds/apiclient/grpc\_envoy.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy94ZHMvYXBpY2xpZW50L2dycGNfZW52b3kuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/config/xds/apiclient/grpc.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy94ZHMvYXBpY2xpZW50L2dycGMuZ28=) | `17.85% <3.33%> (-0.10%)` | :arrow_down: |
| [pkg/config/xds/xds.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy94ZHMveGRzLmdv) | `12.30% <7.40%> (-7.70%)` | :arrow_down: |
| [pkg/server/dynamic\_resource\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9keW5hbWljX3Jlc291cmNlX21hbmFnZXIuZ28=) | `89.18% <100.00%> (ø)` | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] PhilYue commented on pull request #446: deploy pixiu as dubbo service egress gateway in k8s istio
Posted by GitBox <gi...@apache.org>.
PhilYue commented on PR #446:
URL: https://github.com/apache/dubbo-go-pixiu/pull/446#issuecomment-1236178021
is the Sidecar start need special handling? the relevant code : [sidecar.go](https://github.com/apache/dubbo-go-pixiu/blob/develop/cmd/pixiu/sidecar.go)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on pull request #446: deploy pixiu as dubbo service egress gateway in k8s istio
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on PR #446:
URL: https://github.com/apache/dubbo-go-pixiu/pull/446#issuecomment-1236033198
pls fix the file confliction.thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on a diff in pull request #446: deploy pixiu as dubbo service egress gateway in k8s istio
Posted by GitBox <gi...@apache.org>.
mark4z commented on code in PR #446:
URL: https://github.com/apache/dubbo-go-pixiu/pull/446#discussion_r953573845
##########
pkg/config/xds/apiclient/grpc_envoy.go:
##########
@@ -0,0 +1,446 @@
+/*
Review Comment:
What is the meaning of this file name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on a diff in pull request #446: deploy pixiu as dubbo service egress gateway in k8s istio
Posted by GitBox <gi...@apache.org>.
mark4z commented on code in PR #446:
URL: https://github.com/apache/dubbo-go-pixiu/pull/446#discussion_r953562530
##########
pkg/model/listener.go:
##########
@@ -28,9 +28,10 @@ const (
)
const (
- REST_VALUE = "REST"
- GRPC_VALUE = "GRPC"
- DUBBO_VALUE = "DUBBO"
+ REST_VALUE = "REST"
+ GRPC_VALUE = "GRPC"
+ DUBBO_VALUE = "DUBBO"
+ IstioGRPC_VALUE = "ISTIO"
Review Comment:
same with before.
##########
pkg/config/xds/xds.go:
##########
@@ -18,6 +18,8 @@
package xds
import (
+ "github.com/apache/dubbo-go-pixiu/pkg/common/constant"
+ "github.com/mitchellh/mapstructure"
Review Comment:
+1
##########
pkg/model/base.go:
##########
@@ -67,9 +68,10 @@ var (
}
ApiTypeValue = map[string]int32{
- REST_VALUE: 0,
- GRPC_VALUE: 1,
- DUBBO_VALUE: 2,
+ REST_VALUE: 0,
+ GRPC_VALUE: 1,
+ DUBBO_VALUE: 2,
+ IstioGRPC_VALUE: 3,
Review Comment:
ISTIO_GRPC_VALUE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org