You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/04/23 10:42:22 UTC
Review Request: CLOUDSTACK-2087: Destroying the instance is not decrementing
the primary storage usage [Resource Count table - No of volumes is not got
decremented]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen.
Description
-------
CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
This addresses bug CLOUDSTACK-2087.
Diffs
-----
server/src/com/cloud/vm/VirtualMachineManagerImpl.java c1f3f15
Diff: https://reviews.apache.org/r/10725/diff/
Testing
-------
Tests:
1. Deploy an instance from a user account.
2. Check the updated resource count (primary storage and volume).
3. Destroy the same instance.
4. Verify the decremented resource count from the account detailView.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-2087: Destroying the instance is not
decrementing the primary storage usage [Resource Count table - No of
volumes is not got decremented]
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/#review20070
-----------------------------------------------------------
Commit 85a1cc962cb39baafd0aeb3457eeb227e848aef9 in branch refs/heads/master from Sateesh Chodapuneedi <sa...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=85a1cc9 ]
CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
Signed-off-by: Sateesh Chodapuneedi <sa...@apache.org>
- ASF Subversion and Git Services
On April 30, 2013, 10:15 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10725/
> -----------------------------------------------------------
>
> (Updated April 30, 2013, 10:15 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, Sateesh Chodapuneedi, and Min Chen.
>
>
> Description
> -------
>
> CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
>
>
> This addresses bug CLOUDSTACK-2087.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java e8805ae
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378
>
> Diff: https://reviews.apache.org/r/10725/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an instance from a user account.
> 2. Check the updated resource count (primary storage and volume).
> 3. Destroy the same instance.
> 4. Verify the decremented resource count from the account detailView.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2087: Destroying the instance is not
decrementing the primary storage usage [Resource Count table - No of
volumes is not got decremented]
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/#review20071
-----------------------------------------------------------
Ship it!
Commit 85a1cc962cb39baafd0aeb3457eeb227e848aef9 in branch refs/heads/master
- Sateesh Chodapuneedi
On April 30, 2013, 10:15 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10725/
> -----------------------------------------------------------
>
> (Updated April 30, 2013, 10:15 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, Sateesh Chodapuneedi, and Min Chen.
>
>
> Description
> -------
>
> CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
>
>
> This addresses bug CLOUDSTACK-2087.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java e8805ae
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378
>
> Diff: https://reviews.apache.org/r/10725/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an instance from a user account.
> 2. Check the updated resource count (primary storage and volume).
> 3. Destroy the same instance.
> 4. Verify the decremented resource count from the account detailView.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2087: Destroying the instance is not
decrementing the primary storage usage [Resource Count table - No of
volumes is not got decremented]
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/#review20053
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On April 30, 2013, 10:15 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10725/
> -----------------------------------------------------------
>
> (Updated April 30, 2013, 10:15 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, Sateesh Chodapuneedi, and Min Chen.
>
>
> Description
> -------
>
> CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
>
>
> This addresses bug CLOUDSTACK-2087.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java e8805ae
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378
>
> Diff: https://reviews.apache.org/r/10725/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an instance from a user account.
> 2. Check the updated resource count (primary storage and volume).
> 3. Destroy the same instance.
> 4. Verify the decremented resource count from the account detailView.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2087: Destroying the instance is not
decrementing the primary storage usage [Resource Count table - No of
volumes is not got decremented]
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/
-----------------------------------------------------------
(Updated April 30, 2013, 10:15 a.m.)
Review request for cloudstack, Devdeep Singh, Nitin Mehta, Sateesh Chodapuneedi, and Min Chen.
Changes
-------
updated Patch after resolving the conflicts with latest code.
Description
-------
CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
This addresses bug CLOUDSTACK-2087.
Diffs (updated)
-----
server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java e8805ae
server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378
Diff: https://reviews.apache.org/r/10725/diff/
Testing
-------
Tests:
1. Deploy an instance from a user account.
2. Check the updated resource count (primary storage and volume).
3. Destroy the same instance.
4. Verify the decremented resource count from the account detailView.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-2087: Destroying the instance is not
decrementing the primary storage usage [Resource Count table - No of
volumes is not got decremented]
Posted by Sanjay Tripathi <sa...@citrix.com>.
> On April 23, 2013, 8:58 p.m., David Nalley wrote:
> > In the process of fixing this bug, can we also write a test that ensure we don't regress it in the future?
> >
David,
There is a separate ticket created to test the limit resources on domain/accounts under [QA Automation] tag: https://issues.apache.org/jira/browse/CLOUDSTACK-1466
I'll work with Prasanna to complete the tests for all the resource types.
There is already a patch on the review board which tests the CPU limits: https://reviews.apache.org/r/10828/ submitted by Chiraj Jog.
- Sanjay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/#review19602
-----------------------------------------------------------
On April 23, 2013, 9:29 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10725/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 9:29 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, Sateesh Chodapuneedi, and Min Chen.
>
>
> Description
> -------
>
> CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
>
>
> This addresses bug CLOUDSTACK-2087.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java c1f3f15
>
> Diff: https://reviews.apache.org/r/10725/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an instance from a user account.
> 2. Check the updated resource count (primary storage and volume).
> 3. Destroy the same instance.
> 4. Verify the decremented resource count from the account detailView.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2087: Destroying the instance is not
decrementing the primary storage usage [Resource Count table - No of
volumes is not got decremented]
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/#review19602
-----------------------------------------------------------
In the process of fixing this bug, can we also write a test that ensure we don't regress it in the future?
- David Nalley
On April 23, 2013, 9:29 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10725/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 9:29 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, Sateesh Chodapuneedi, and Min Chen.
>
>
> Description
> -------
>
> CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
>
>
> This addresses bug CLOUDSTACK-2087.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java c1f3f15
>
> Diff: https://reviews.apache.org/r/10725/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an instance from a user account.
> 2. Check the updated resource count (primary storage and volume).
> 3. Destroy the same instance.
> 4. Verify the decremented resource count from the account detailView.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2087: Destroying the instance is not
decrementing the primary storage usage [Resource Count table - No of
volumes is not got decremented]
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/
-----------------------------------------------------------
(Updated April 23, 2013, 9:29 a.m.)
Review request for cloudstack, Devdeep Singh, Nitin Mehta, Sateesh Chodapuneedi, and Min Chen.
Description
-------
CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
This addresses bug CLOUDSTACK-2087.
Diffs
-----
server/src/com/cloud/vm/VirtualMachineManagerImpl.java c1f3f15
Diff: https://reviews.apache.org/r/10725/diff/
Testing
-------
Tests:
1. Deploy an instance from a user account.
2. Check the updated resource count (primary storage and volume).
3. Destroy the same instance.
4. Verify the decremented resource count from the account detailView.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-2087: Destroying the instance is not
decrementing the primary storage usage [Resource Count table - No of
volumes is not got decremented]
Posted by Sanjay Tripathi <sa...@citrix.com>.
> On April 23, 2013, 8:48 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/vm/VirtualMachineManagerImpl.java, line 447
> > <https://reviews.apache.org/r/10725/diff/1/?file=283382#file283382line447>
> >
> > Would restore vm increment these limits again ?
> >
Are you talking about resotreVM or recoverVM?
In case of restoreVM, it is resetting the VM by deleting old root volume and allocating duplicate root volume, so we don't have to check for limits here.
In case of recoverVM, this API option is available only if the root disk is not yet expunged, so it will not increment primary storage limits.
> On April 23, 2013, 8:48 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/vm/VirtualMachineManagerImpl.java, line 448
> > <https://reviews.apache.org/r/10725/diff/1/?file=283382#file283382line448>
> >
> > What about the resource limit for the vm ? where is that getting decremented. Are these consistent ?
Other resource limits related to VM like vm_instance, cpu, memory etc are getting decremented once the destroyVM API returns the result successfully. CloudStack waits for expunging of VM to decrement the storage limits like Volume, primary storage.
- Sanjay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/#review19579
-----------------------------------------------------------
On April 23, 2013, 8:42 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10725/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 8:42 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen.
>
>
> Description
> -------
>
> CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
>
>
> This addresses bug CLOUDSTACK-2087.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java c1f3f15
>
> Diff: https://reviews.apache.org/r/10725/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an instance from a user account.
> 2. Check the updated resource count (primary storage and volume).
> 3. Destroy the same instance.
> 4. Verify the decremented resource count from the account detailView.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2087: Destroying the instance is not
decrementing the primary storage usage [Resource Count table - No of
volumes is not got decremented]
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10725/#review19579
-----------------------------------------------------------
server/src/com/cloud/vm/VirtualMachineManagerImpl.java
<https://reviews.apache.org/r/10725/#comment40435>
Would restore vm increment these limits again ?
server/src/com/cloud/vm/VirtualMachineManagerImpl.java
<https://reviews.apache.org/r/10725/#comment40436>
What about the resource limit for the vm ? where is that getting decremented. Are these consistent ?
- Nitin Mehta
On April 23, 2013, 8:42 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10725/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 8:42 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen.
>
>
> Description
> -------
>
> CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]
>
>
> This addresses bug CLOUDSTACK-2087.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java c1f3f15
>
> Diff: https://reviews.apache.org/r/10725/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an instance from a user account.
> 2. Check the updated resource count (primary storage and volume).
> 3. Destroy the same instance.
> 4. Verify the decremented resource count from the account detailView.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>