You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/20 16:06:47 UTC
[GitHub] [rocketmq] BingCoke opened a new pull request, #5557: fix:build instance name with pid instead of pid+nanotime .Because tha…
BingCoke opened a new pull request, #5557:
URL: https://github.com/apache/rocketmq/pull/5557
fix that create a MQClientInstance as long as create a producer or a consumer.
That lead to clientInstance just manages one producer or producer,
but clientInstance is designed for managing many of producers and consumers;
#5555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #5555] fix:build instance name with pid instead of pid+nanotime .Because tha… [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5557:
URL: https://github.com/apache/rocketmq/pull/5557#issuecomment-1826447831
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #5555] fix:build instance name with pid instead of pid+nanotime .Because tha… [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5557: [ISSUE #5555] fix:build instance name with pid instead of pid+nanotime .Because tha…
URL: https://github.com/apache/rocketmq/pull/5557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #5557: [ISSUE #5555 ]fix:build instance name with pid instead of pid+nanotime .Because tha…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5557:
URL: https://github.com/apache/rocketmq/pull/5557#issuecomment-1321175703
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5557?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5557](https://codecov.io/gh/apache/rocketmq/pull/5557?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6efd4aa) into [develop](https://codecov.io/gh/apache/rocketmq/commit/1657475997733133fea6a1be14b8a22cc5730698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1657475) will **decrease** coverage by `5.66%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## develop #5557 +/- ##
=============================================
- Coverage 48.39% 42.73% -5.67%
- Complexity 4618 8040 +3422
=============================================
Files 555 1031 +476
Lines 36731 72743 +36012
Branches 4839 9614 +4775
=============================================
+ Hits 17776 31084 +13308
- Misses 16726 37724 +20998
- Partials 2229 3935 +1706
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/5557?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/rocketmq/client/ClientConfig.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvQ2xpZW50Q29uZmlnLmphdmE=) | `63.37% <ø> (+2.22%)` | :arrow_up: |
| [...che/rocketmq/common/consumer/ConsumeFromWhere.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vY29uc3VtZXIvQ29uc3VtZUZyb21XaGVyZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rocketmq/test/client/rmq/RMQBroadCastConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUUJyb2FkQ2FzdENvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...est/listener/rmq/concurrent/RMQNormalListener.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9saXN0ZW5lci9ybXEvY29uY3VycmVudC9STVFOb3JtYWxMaXN0ZW5lci5qYXZh) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [.../apache/rocketmq/test/message/MessageQueueMsg.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9tZXNzYWdlL01lc3NhZ2VRdWV1ZU1zZy5qYXZh) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
| [.../apache/rocketmq/test/factory/ConsumerFactory.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9mYWN0b3J5L0NvbnN1bWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
| [...ava/org/apache/rocketmq/test/util/RandomUtils.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL1JhbmRvbVV0aWxzLmphdmE=) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [...rocketmq/test/client/rmq/RMQAsyncSendProducer.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUUFzeW5jU2VuZFByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (-80.51%)` | :arrow_down: |
| [...pache/rocketmq/test/client/rmq/RMQSqlConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUVNxbENvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...he/rocketmq/test/client/rmq/RMQNormalProducer.java](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUU5vcm1hbFByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (-79.79%)` | :arrow_down: |
| ... and [1023 more](https://codecov.io/gh/apache/rocketmq/pull/5557/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #5555] fix:build instance name with pid instead of pid+nanotime .Because tha… [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5557:
URL: https://github.com/apache/rocketmq/pull/5557#issuecomment-1821887514
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org