You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by jl...@apache.org on 2019/01/15 13:34:42 UTC
[tomee] branch master updated: more checkstyle issues
This is an automated email from the ASF dual-hosted git repository.
jlmonteiro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git
The following commit(s) were added to refs/heads/master by this push:
new 61512d5 more checkstyle issues
61512d5 is described below
commit 61512d5f7300ffadf3bd0a3cf214b62e6e1e32ab
Author: Jean-Louis Monteiro <je...@gmail.com>
AuthorDate: Tue Jan 15 14:34:33 2019 +0100
more checkstyle issues
---
.../enterprise/credential/BasicAuthenticationCredential.java | 6 +++---
.../apache/tomee/security/http/LoginToContinueMechanism.java | 10 +++++-----
.../apache/tomee/security/http/TomEEHttpMessageContext.java | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/tomee/tomee-security/src/main/java/javax/security/enterprise/credential/BasicAuthenticationCredential.java b/tomee/tomee-security/src/main/java/javax/security/enterprise/credential/BasicAuthenticationCredential.java
index 404cc3c..1d05f1b 100644
--- a/tomee/tomee-security/src/main/java/javax/security/enterprise/credential/BasicAuthenticationCredential.java
+++ b/tomee/tomee-security/src/main/java/javax/security/enterprise/credential/BasicAuthenticationCredential.java
@@ -26,7 +26,7 @@ public class BasicAuthenticationCredential extends UsernamePasswordCredential {
}
private static String decodeHeader(String authorizationHeader) {
- final String BASIC_AUTH_CHARSET = "US-ASCII";
+ final String basicAuthCharset = "US-ASCII";
if (null == authorizationHeader) {
throw new NullPointerException("authorization header");
@@ -39,9 +39,9 @@ public class BasicAuthenticationCredential extends UsernamePasswordCredential {
final Base64.Decoder decoder = Base64.getMimeDecoder();
byte[] decodedBytes = decoder.decode(authorizationHeader);
try {
- return new String(decodedBytes, BASIC_AUTH_CHARSET);
+ return new String(decodedBytes, basicAuthCharset);
} catch (UnsupportedEncodingException e) {
- throw new IllegalStateException("Unknown Charset: " + BASIC_AUTH_CHARSET, e);
+ throw new IllegalStateException("Unknown Charset: " + basicAuthCharset, e);
}
}
diff --git a/tomee/tomee-security/src/main/java/org/apache/tomee/security/http/LoginToContinueMechanism.java b/tomee/tomee-security/src/main/java/org/apache/tomee/security/http/LoginToContinueMechanism.java
index 7871595..b2c3ae5 100644
--- a/tomee/tomee-security/src/main/java/org/apache/tomee/security/http/LoginToContinueMechanism.java
+++ b/tomee/tomee-security/src/main/java/org/apache/tomee/security/http/LoginToContinueMechanism.java
@@ -39,7 +39,7 @@ public interface LoginToContinueMechanism {
static void saveRequest(final HttpServletRequest request) throws IOException {
SavedRequest saved = new SavedRequest();
- Cookie cookies[] = request.getCookies();
+ Cookie[] cookies = request.getCookies();
if (cookies != null) {
for (int i = 0; i < cookies.length; i++) {
saved.addCookie(cookies[i]);
@@ -91,13 +91,13 @@ public interface LoginToContinueMechanism {
static boolean matchRequest(final HttpServletRequest request) {
// Has a session been created?
- final HttpSession session = request.getSession(false);
+ HttpSession session = request.getSession(false);
if (session == null) {
return false;
}
// Is there a saved request?
- final SavedRequest originalRequest = (SavedRequest) request.getSession().getAttribute(ORIGINAL_REQUEST);
+ SavedRequest originalRequest = (SavedRequest) request.getSession().getAttribute(ORIGINAL_REQUEST);
if (originalRequest == null) {
return false;
}
@@ -110,7 +110,7 @@ public interface LoginToContinueMechanism {
*/
// Does the request URI match?
- final String requestURI = request.getRequestURI();
+ String requestURI = request.getRequestURI();
return requestURI != null && requestURI.equals(originalRequest.getRequestURI());
}
@@ -125,7 +125,7 @@ public interface LoginToContinueMechanism {
static void saveAuthentication(final HttpServletRequest request,
final Principal principal,
final Set<String> groups) {
- final SavedAuthentication savedAuthentication = new SavedAuthentication(principal, groups);
+ SavedAuthentication savedAuthentication = new SavedAuthentication(principal, groups);
request.getSession().setAttribute(AUTHENTICATION, savedAuthentication);
}
diff --git a/tomee/tomee-security/src/main/java/org/apache/tomee/security/http/TomEEHttpMessageContext.java b/tomee/tomee-security/src/main/java/org/apache/tomee/security/http/TomEEHttpMessageContext.java
index f6c25d4..0c2d898 100644
--- a/tomee/tomee-security/src/main/java/org/apache/tomee/security/http/TomEEHttpMessageContext.java
+++ b/tomee/tomee-security/src/main/java/org/apache/tomee/security/http/TomEEHttpMessageContext.java
@@ -45,7 +45,7 @@ import static javax.security.enterprise.AuthenticationStatus.SUCCESS;
import static javax.security.enterprise.identitystore.CredentialValidationResult.Status.VALID;
import static javax.servlet.http.HttpServletResponse.SC_UNAUTHORIZED;
-public class TomEEHttpMessageContext implements HttpMessageContext {
+public final class TomEEHttpMessageContext implements HttpMessageContext {
private final CallbackHandler handler;
private final MessageInfo messageInfo;
private final Subject clientSubject;