You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/21 04:00:34 UTC

[GitHub] [skywalking-kubernetes-event-exporter] kezhenxu94 commented on a diff in pull request #15: Add E2E tests

kezhenxu94 commented on code in PR #15:
URL: https://github.com/apache/skywalking-kubernetes-event-exporter/pull/15#discussion_r854755061


##########
.github/workflows/build-and-test.yaml:
##########
@@ -20,6 +20,13 @@ name: Check
 
 on:
   pull_request:
+    paths-ignore:

Review Comment:
   Adding this will skip the checks in some cases and the `gateway` job below won’t succeed, in those cases pull requests are not able to be merged. Can you do this by leveraging the same way as you did in https://github.com/apache/skywalking-cli/blob/9ad35d097e8966ac9324f1d570b1a2d264b38ca1/.github/workflows/go.yml#L33 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org