[GitHub] [pulsar] jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

[GitBox <gi...@apache.org>]

jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r262044892
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java
 ##########
 @@ -105,6 +105,18 @@ public String authenticateHttpRequest(HttpServletRequest request) throws Authent
         }
     }
 
+    public AuthenticationProvider getAuthenticationProvider(String authMethodName) {
+        return providers.get(authMethodName);
+    }
+
+    public String getAnonymousUserRole() throws AuthenticationException {
+        if (StringUtils.isNotBlank(anonymousUserRole)) {
+            return anonymousUserRole;
+        }
+        // If at least a provider was configured, then the authentication needs to be provided
 
 Review comment:
   will remove this comments. this method is called in serverCnx, under condition: auth enabled, but authmethod="none". In this condition, it is expected anonymousUserRole provided.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services