[GitHub] [madlib] reductionista commented on a change in pull request #395: DL: madlib_keras_evaluate() function

[GitBox <gi...@apache.org>]

reductionista commented on a change in pull request #395: DL: madlib_keras_evaluate() function
URL: https://github.com/apache/madlib/pull/395#discussion_r287135579
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
 ##########
 @@ -544,6 +539,15 @@ def fit_final(state, **kwargs):
     return madlib_keras_serializer.serialize_weights_merge(
         loss, accuracy, image_count, weights)
 
+def get_segments_and_gpus(gpus_per_host):
+    gpus_per_host = 0 if gpus_per_host is None else gpus_per_host
+    segments_per_host = get_segments_per_host()
+
+    if 0 < gpus_per_host < segments_per_host:
+        plpy.warning('The number of gpus per host is less than the number of '
+                     'segments per host. The support for this case is '
+                     'experimental and it may fail.')
 
 Review comment:
   Oh, yes forgot to test!  Fixing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services