MSHADE-209: 'too expensive test'

[Benson Margulies <bi...@gmail.com>]

There's a good patch in a PR. It has no test, and the author references

https://github.com/apache/maven-plugins/blame/8762d5746501b894cf766f38111fc514938be280/maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/filter/MinijarFilterTest.java

containing a commented out test case marked 'too expensive'.

Could anyone comment on the decision process here? We have a lot of
expensive tests, what's so bad about this one?

Re: MSHADE-209: 'too expensive test'

[Robert Scholte <rf...@apache.org>]

I see no reason why this is done, maybe Karl Heinz remembers it.
I see that a different constructor is used for the filter, must have to do  
with that, although I see mocks too, which I consider cheap.
In general, if tests are too expensive, then the code is probably too  
complex and should be split up so you can make more lightweight tests,  
when possible of course.

Robert

On Thu, 23 Mar 2017 17:41:47 +0100, Benson Margulies  
<bi...@gmail.com> wrote:

> There's a good patch in a PR. It has no test, and the author references
>
> https://github.com/apache/maven-plugins/blame/8762d5746501b894cf766f38111fc514938be280/maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/filter/MinijarFilterTest.java
>
> containing a commented out test case marked 'too expensive'.
>
> Could anyone comment on the decision process here? We have a lot of
> expensive tests, what's so bad about this one?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org