You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/09/10 18:56:13 UTC
[PR] Exclude sqlparser_bench from source release archive [datafusion-sqlparser-rs]
alamb opened a new pull request, #2497:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2497
Adds a `.gitattributes` `export-ignore` entry so the `sqlparser_bench` directory (including the generated `flamegraph.svg`, which embeds CDDL-licensed JavaScript from Inferno) is excluded from source archives created by `git archive` in `dev/release/create-tarball.sh`. Also removes the now-unnecessary RAT exclusion for the flamegraph.
Verified with `git archive HEAD | tar -t`: no `sqlparser_bench` entries.
Part of #2495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Replace benchmark flamegraph.svg with png [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2497:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2497#issuecomment-5813655235
Let's go for PNG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Replace benchmark flamegraph.svg with png [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2497:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2497#issuecomment-5813849945
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2497?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 80.96%. Comparing base ([`ae67547`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/ae67547ffc99f942fd929010ddfd6b724d5801e7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`53a3de4`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/53a3de4abb64a22d48e9a0e87ea1abf5e2ef15cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2497 +/- ##
=======================================
Coverage 80.96% 80.96%
=======================================
Files 42 42
Lines 33386 33386
Branches 33386 33386
=======================================
Hits 27032 27032
Misses 2789 2789
Partials 3565 3565
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2497?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Replace benchmark flamegraph.svg with png [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2497:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2497#issuecomment-5686980126
But a PNG cannot be expanded, defeating a bit the purpose of having the flamegraph in the first place. Is this done solely because of the licensing issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Replace benchmark flamegraph.svg with png [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #2497:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2497#issuecomment-5819699198
Thank you @LucaCappelletti94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Replace benchmark flamegraph.svg with png [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #2497:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2497#issuecomment-5687182218
> But a PNG cannot be expanded, defeating a bit the purpose of having the flamegraph in the first place. Is this done solely because of the licensing issue?
Yes -- but note the png is only used for the docs (for instructions on how to create a full svg)
Another thing we could do would be to keep the svg and exclude it from the packaging in create_tarball.sh 🤔 I can do that if you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Replace benchmark flamegraph.svg with png [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 merged PR #2497:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org