You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org> on 2018/02/03 01:28:59 UTC
[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9208
Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query
......................................................................
IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Change the expected result type of Kudu TPCH Q17 to Decimal because
DECIMAL_V2 is now enabled by default. This was not done earlier because
we were not running TPCH on Kudu regularly.
Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Cherry-picks: not for 2.x
---
M testdata/workloads/tpch/queries/tpch-kudu-q17.test
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/9208/1
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 )
Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Sat, 03 Feb 2018 05:22:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 )
Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1873/
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Sat, 03 Feb 2018 01:42:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9208 )
Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query
......................................................................
IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Change the expected result type of Kudu TPCH Q17 to Decimal because
DECIMAL_V2 is now enabled by default. This was not done earlier because
we were not running TPCH on Kudu regularly.
Cherry-picks: not for 2.x
Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Reviewed-on: http://gerrit.cloudera.org:8080/9208
Reviewed-by: Taras Bobrovytsky <tb...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M testdata/workloads/tpch/queries/tpch-kudu-q17.test
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Taras Bobrovytsky: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 3
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 )
Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Comment-Date: Sat, 03 Feb 2018 01:34:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 )
Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1872/
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Sat, 03 Feb 2018 01:35:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9208 )
Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query
......................................................................
IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Change the expected result type of Kudu TPCH Q17 to Decimal because
DECIMAL_V2 is now enabled by default. This was not done earlier because
we were not running TPCH on Kudu regularly.
Cherry-picks: not for 2.x
Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
---
M testdata/workloads/tpch/queries/tpch-kudu-q17.test
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/9208/2
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 )
Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query
......................................................................
Patch Set 2: Code-Review+2
For some reason Change-Id was placed before "Cherry-picks" in the commit message. Fixed. Forwarding the +2
--
To view, visit http://gerrit.cloudera.org:8080/9208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fc038d40969547622707ce77a037494f0ed0a9
Gerrit-Change-Number: 9208
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Sat, 03 Feb 2018 01:42:26 +0000
Gerrit-HasComments: No