You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "anuragmantri (via GitHub)" <gi...@apache.org> on 2024/12/13 00:27:20 UTC
[PR] Core: Allow adding files to multiple partition specs in FastAppend [iceberg]
anuragmantri opened a new pull request, #11771:
URL: https://github.com/apache/iceberg/pull/11771
This PR adds ability to add files to multiple partition specs in FastAppend. Inspired by MergeAppend code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Allow adding files to multiple partition specs in FastAppend [iceberg]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi merged PR #11771:
URL: https://github.com/apache/iceberg/pull/11771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Allow adding files to multiple partition specs in FastAppend [iceberg]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on PR #11771:
URL: https://github.com/apache/iceberg/pull/11771#issuecomment-2583369545
Thanks, @anuragmantri!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Allow adding files to multiple partition specs in FastAppend [iceberg]
Posted by "anuragmantri (via GitHub)" <gi...@apache.org>.
anuragmantri commented on code in PR #11771:
URL: https://github.com/apache/iceberg/pull/11771#discussion_r1887709101
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -1590,13 +1590,15 @@ public void testCompleteCreateTransactionMultipleSchemas() {
updateSchema.commit();
UpdatePartitionSpec updateSpec = create.updateSpec().addField("new_col");
- PartitionSpec newSpec = updateSpec.apply();
updateSpec.commit();
ReplaceSortOrder replaceSortOrder = create.replaceSortOrder().asc("new_col");
SortOrder newSortOrder = replaceSortOrder.apply();
replaceSortOrder.commit();
+ // Get new spec after commit to write new file with new spec
+ PartitionSpec newSpec = create.table().spec();
Review Comment:
This test was not using the latest spec. I would fail with `newAppend()` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Allow adding files to multiple partition specs in FastAppend [iceberg]
Posted by "anuragmantri (via GitHub)" <gi...@apache.org>.
anuragmantri commented on PR #11771:
URL: https://github.com/apache/iceberg/pull/11771#issuecomment-2540277299
@aokolnychyi @stevenzwu - Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org