You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/11 07:42:25 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #27873: [SPARK-31117][SQL][TEST] reduce the test time of DateTimeUtilsSuite

cloud-fan commented on a change in pull request #27873: [SPARK-31117][SQL][TEST] reduce the test time of DateTimeUtilsSuite
URL: https://github.com/apache/spark/pull/27873#discussion_r390789651
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
 ##########
 @@ -623,10 +623,12 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
       "MIT" -> Set(15338))
     for (tz <- ALL_TIMEZONES) {
       val skipped = skipped_days.getOrElse(tz.getID, Set.empty)
-      (-20000 to 20000).foreach { d =>
+      val testingData = Seq(-20000, 20000) ++
 
 Review comment:
   I don't know why we pick -20000 and 20000 as the boundaries, just to be safe to always test the boundary values.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org