[jira] [Updated] (SHINDIG-1757) Defer getting the singleton user prefs in opensocial-templates feature until inline execution of gadgets.Prefs.setDefaultPrefs_ is called

["Ryan Baxter (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Baxter updated SHINDIG-1757:
---------------------------------

    Fix Version/s:     (was: 2.5.0)
                   2.5.0-beta2
    
> Defer getting the singleton user prefs in opensocial-templates feature until inline execution of gadgets.Prefs.setDefaultPrefs_  is called
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1757
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1757
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.0, 2.5.0-beta1, 2.5.0
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>            Priority: Minor
>             Fix For: 2.5.0-beta2
>
>         Attachments: SHINDIG-1757.patch
>
>
> The RenderingGadgetRewriter will inject an inline script to set default user pref via call to gadgets.Prefs.setDefaultPrefs_. 
> So, since gadgets.Prefs is a singleton instance then any call to instantiate gadgets.Prefs need to wait until the inline script is executed.
> In the opensocial-templates feature, the base.js eagerly call new gadgets.Prefs that makes singleton of gadget user pref is instantiated without chance for gadgets.Prefs.setDefaultPrefs_ to be executed.
> This can be solved by using common container which also add default user pref in the iframe URL however we need to make sure the flow from both and client are intact. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira