You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by achristianson <gi...@git.apache.org> on 2018/04/24 17:07:22 UTC
[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/307
MINIFICPP-469 Added encode/decode base64 EL functions
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-469
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #307
----
commit 18387e251a090bd4f38b9a5d5e7e287589363193
Author: Andrew I. Christianson <an...@...>
Date: 2018-04-24T17:06:46Z
MINIFICPP-469 Added encode/decode base64 EL functions
----
---
[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r186519113
--- Diff: extensions/expression-language/base64.h ---
@@ -0,0 +1,188 @@
+/***************************************************************************
--- End diff --
Rebased to fix conflicts. The reason it's here rather than 3rd-party is that it's specific functions copied/pasted, not a third party lib. We own/adopted the code now and it won't be maintained by a third party.
---
[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r184142402
--- Diff: extensions/expression-language/base64.h ---
@@ -0,0 +1,188 @@
+/***************************************************************************
--- End diff --
s/class/file/
Allow me to rephrase though. Why is this file *in this directory* as opposed to our third party directory?
---
[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r184137048
--- Diff: extensions/expression-language/base64.h ---
@@ -0,0 +1,188 @@
+/***************************************************************************
--- End diff --
Why is this class here?
---
[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r184138022
--- Diff: extensions/expression-language/base64.h ---
@@ -0,0 +1,188 @@
+/***************************************************************************
--- End diff --
This is the cURL base64 encode/decode. Here's why:
1) Avoid reinventing the wheel
2) It's a private function in cURL, so that's why it's copied rather than exposing/calling into cURL lib
3) We already have cURL included & in LICENSE, so it's simple to use this one
4) Simpler implementation to call than OpenSSL implementation
---
[GitHub] nifi-minifi-cpp issue #307: MINIFICPP-469 Added encode/decode base64 EL func...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/307
reverified builds on OS X and Debian. will merge.
---
[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r186520663
--- Diff: extensions/expression-language/base64.h ---
@@ -0,0 +1,188 @@
+/***************************************************************************
--- End diff --
Thanks for rebasing I will merge.
---
[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/307
---