[GitHub] sohami closed pull request #1604: DRILL-6954: Move commons libs used in UDFs module to the dependency management

[GitBox <gi...@apache.org>]

sohami closed pull request #1604: DRILL-6954: Move commons libs used in UDFs module to the dependency management
URL: https://github.com/apache/drill/pull/1604
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/contrib/udfs/pom.xml b/contrib/udfs/pom.xml
index 740c06e7d16..c0bc4e51ca0 100644
--- a/contrib/udfs/pom.xml
+++ b/contrib/udfs/pom.xml
@@ -40,31 +40,22 @@
     <dependency>
       <groupId>commons-net</groupId>
       <artifactId>commons-net</artifactId>
-      <version>3.6</version>
     </dependency>
 
     <dependency>
       <groupId>commons-validator</groupId>
       <artifactId>commons-validator</artifactId>
-      <version>1.6</version>
-      <exclusions>
-        <exclusion>
-          <groupId>commons-logging</groupId>
-          <artifactId>commons-logging</artifactId>
-        </exclusion>
-      </exclusions>
     </dependency>
 
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-text</artifactId>
-      <version>1.4</version>
     </dependency>
 
     <dependency>
       <groupId>com.esri.geometry</groupId>
       <artifactId>esri-geometry-api</artifactId>
-      <version>2.2.0</version>
+      <version>2.2.2</version>
     </dependency>
 
     <dependency>
diff --git a/pom.xml b/pom.xml
index f0ecf80dc8c..a2e0948c191 100644
--- a/pom.xml
+++ b/pom.xml
@@ -94,6 +94,9 @@
     <docker.repository>drill/apache-drill</docker.repository>
     <antlr.version>4.7.1</antlr.version>
     <lowestMavenVersion>3.3.3</lowestMavenVersion>
+    <commons.net.version>3.6</commons.net.version>
+    <commons.validator.version>1.6</commons.validator.version>
+    <commons.text.version>1.6</commons.text.version>
   </properties>
 
   <scm>
@@ -1702,6 +1705,32 @@
         <artifactId>antlr4-runtime</artifactId>
         <version>${antlr.version}</version>
       </dependency>
+      <dependency>
+        <groupId>sqlline</groupId>
+        <artifactId>sqlline</artifactId>
+        <version>${sqlline.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>commons-net</groupId>
+        <artifactId>commons-net</artifactId>
+        <version>${commons.net.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>commons-validator</groupId>
+        <artifactId>commons-validator</artifactId>
+        <version>${commons.validator.version}</version>
+        <exclusions>
+          <exclusion>
+            <groupId>commons-logging</groupId>
+            <artifactId>commons-logging</artifactId>
+          </exclusion>
+        </exclusions>
+      </dependency>
+      <dependency>
+        <groupId>org.apache.commons</groupId>
+        <artifactId>commons-text</artifactId>
+        <version>${commons.text.version}</version>
+      </dependency>
     </dependencies>
   </dependencyManagement>
 
@@ -2350,11 +2379,6 @@
             <artifactId>xalan</artifactId>
             <version>2.7.1</version>
           </dependency>
-          <dependency>
-            <groupId>sqlline</groupId>
-            <artifactId>sqlline</artifactId>
-            <version>${sqlline.version}</version>
-          </dependency>
 
           <dependency>
             <groupId>org.apache.calcite</groupId>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services