You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/05/13 11:24:31 UTC

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

huage1994 commented on PR #4368:
URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1125951606

   > Thank you but it looks like braking configuration after upgrading it. Do you have any plan to support old configuration in a new version? Otherwise, do users need to change it by hand?
   
   Hi @jongyoul,  Old configuration is also supported in this PR. 
   I am sorry to forget to add comments for the code. 
   If the string passed in doesn't include time unit,  method `timeUnitToMill`  would fail to parse and  return `-1`.  And the original code logic is then executed
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org