You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "shantanukhond (via GitHub)" <gi...@apache.org> on 2026/04/18 04:32:34 UTC
[PR] fix(docs): broken link and add split Get Started with audience links [superset]
shantanukhond opened a new pull request, #39467:
URL: https://github.com/apache/superset/pull/39467
### SUMMARY
- In documentation the centered homepage **Get Started** control pointed at a path that no longer matched the docs IA; it now sends people to **user docs** from the main label and offers **Users / Admins / Developers** from the chevron.
- The same split control is used in the **top navbar** so behavior matches the hero.
- Dropdown styling is aligned with the button width where relevant.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="722" height="432" alt="before-changes" src="https://github.com/user-attachments/assets/cee4db8a-ea33-4b95-8859-f4088fa420b3" />
<img width="800" height="479" alt="after-changes" src="https://github.com/user-attachments/assets/916a925b-b539-4568-8de6-7bc1ad4311f3" />
### TESTING INSTRUCTIONS
1. `cd docs && yarn start` or `yarn start:quick`.
2. On the homepage: click **Get Started** (left) → should open `/user-docs/`. Click the **chevron** → menu with Users, Admins, Developers; each link goes to `/user-docs/`, `/admin-docs/`, `/developer-docs/` respectively.
3. From any page: use the **navbar** Get Started the same way.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4272725087
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 34cbc01fc53ad679cf1178a435c56ecee11438c2 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69e30962a46a5d0008262766 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-39467--superset-docs-preview.netlify.app](https://deploy-preview-39467--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-39467--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4330166283
@shantanukhond when I look at your second and third commits after your original one, it says "This commit does not include any file changes" - and it doesn't look like you changed anything, e.g., importing the CSS file as the AI bot suggested. Am I missing something there? Also there is now a conflict to resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4299060833
Looks good to me! What do you think of the two comments from the AI review tool? Both seemed pertinent to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "shantanukhond (via GitHub)" <gi...@apache.org>.
shantanukhond commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4272719669
If any changes or suggestions required you can let me know. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4336260277
Looks like #38974 fixed the broken link but your PR is still totally relevant as it overrides that pattern entirely. Thanks for the contribution and for including the screen capture video of the new button!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4332413984
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "shantanukhond (via GitHub)" <gi...@apache.org>.
shantanukhond commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4323836014
> Looks good to me! What do you think of the two comments from the AI review tool? Both seemed pertinent to me.
I updated suggestions from AI review tool and tested it. All is good. I updated the PR with latest code as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4331973097
So then have you incorporated the suggestions from the AI comments? If not,
can you? I didn't see the suggested import of the CSS file, for instance.
On Mon, Apr 27, 2026, 10:10 PM Shantanu Khond ***@***.***>
wrote:
> *shantanukhond* left a comment (apache/superset#39467)
> <https://github.com/apache/superset/pull/39467#issuecomment-4331850624>
>
> @shantanukhond <https://github.com/shantanukhond> when I look at your
> second and third commits after your original one, it says "This commit does
> not include any file changes" - and it doesn't look like you changed
> anything, e.g., importing the CSS file as the AI bot suggested. Am I
> missing something there? Also there is now a conflict to resolve.
>
> All bottom comments after my first commit are for code rebase even like
> the last one I guess where you updated it where there was conflict. It is
> also showing no changes.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/superset/pull/39467#issuecomment-4331850624>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABZYDEBORUQ2VDMBIJLY6BL4YAHIRAVCNFSM6AAAAACX5VUCU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMZRHA2TANRSGQ>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #39467:
URL: https://github.com/apache/superset/pull/39467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #39467:
URL: https://github.com/apache/superset/pull/39467#discussion_r3104511703
##########
docs/src/theme/NavbarItem/GetStartedSplitNavbarItem.tsx:
##########
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import GetStartedSplitButton from '../../components/GetStartedSplitButton';
+
Review Comment:
**Suggestion:** The split button relies on classes defined in `main.css`, but that stylesheet is only imported on the homepage, so opening any non-homepage route directly renders an unstyled/broken navbar control. Import the stylesheet in this navbar item (or the shared button component) so styles are always loaded wherever the navbar renders. [possible bug]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Navbar Get Started button unstyled on deep-linked docs pages.
- ⚠️ Dropdown menu for Get Started lacks intended gradient theming.
- ⚠️ Inconsistent hero vs navbar CTA appearance across documentation.
```
</details>
```suggestion
import '../../styles/main.css';
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Start the docs site using the PR instructions: from `/workspace/superset/docs`, run
`yarn start` (or `yarn start:quick`) so Docusaurus serves the documentation.
2. In a fresh browser session, directly open a non-homepage docs route, for example
`http://localhost:3000/user-docs/using-superset/creating-your-first-dashboard` (this route
is linked from `docs/quickstart.mdx:76` via
`/user-docs/using-superset/creating-your-first-dashboard`).
3. Docusaurus config at `docs/docusaurus.config.ts:895-898` adds a navbar item with `type:
'custom-getStartedSplit'`, which is resolved by
`docs/src/theme/NavbarItem/ComponentTypes.tsx:30-40` to `GetStartedSplitNavbarItem`,
implemented in `docs/src/theme/NavbarItem/GetStartedSplitNavbarItem.tsx:19-26` and
rendering `GetStartedSplitButton` with `rootClassName="default-button-theme
get-started-split get-started-button"`.
4. The styles for `.default-button-theme`, `.get-started-split`, the dropdown menu, and
navbar-specific sizing are defined only in
`docs/src/styles/main.css:74-165,114-141,149-165`, which is imported exclusively by the
homepage component `docs/src/pages/index.tsx:31-32` (`import '../styles/main.css';`).
Because the `/user-docs/...` route does not load `index.tsx`, `main.css` is not included
on initial render, so the navbar "Get Started" split button appears without its gradient
background, sizing, and dropdown theming until the homepage is visited, demonstrating that
the navbar component relies on CSS that is not loaded on non-homepage routes.
```
</details>
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20docs%2Fsrc%2Ftheme%2FNavbarItem%2FGetStartedSplitNavbarItem.tsx%0A%2A%2ALine%3A%2A%2A%2020%3A20%0A%2A%2AComment%3A%2A%2A%0A%09%2APossible%20Bug%3A%20The%20split%20button%20relies%20on%20classes%20defined%20in%20%60main.css%60%2C%20but%20that%20stylesheet%20is%20only%20imported%20on%20the%20homepage%2C%20so%20opening%20any%20non-homepage%20route%20directly%20renders%20an%20unstyled%2Fbroken%20navbar%20control.%20Import%20the%20stylesheet%20in%20this%20navbar%20item%20%28or%20the%20shared%20button%20component%29%20so%20styles%20are%20always%20loaded%20wherever%20the%20navbar%20renders.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0A) | [Fix in VSCode Claude](https://app
.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20docs%2Fsrc%2Ftheme%2FNavbarItem%2FGetStartedSplitNavbarItem.tsx%0A%2A%2ALine%3A%2A%2A%2020%3A20%0A%2A%2AComment%3A%2A%2A%0A%09%2APossible%20Bug%3A%20The%20split%20button%20relies%20on%20classes%20defined%20in%20%60main.css%60%2C%20but%20that%20stylesheet%20is%20only%20imported%20on%20the%20homepage%2C%20so%20opening%20any%20non-homepage%20route%20directly%20renders%20an%20unstyled%2Fbroken%20navbar%20control.%20Import%20the%20stylesheet%20in%20this%20navbar%20item%20%28or%20the%20shared%20button%20component%29%20so%20styles%20are%20always%20loaded%20wherever%20the%20navbar%20renders.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0A)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/src/theme/NavbarItem/GetStartedSplitNavbarItem.tsx
**Line:** 20:20
**Comment:**
*Possible Bug: The split button relies on classes defined in `main.css`, but that stylesheet is only imported on the homepage, so opening any non-homepage route directly renders an unstyled/broken navbar control. Import the stylesheet in this navbar item (or the shared button component) so styles are always loaded wherever the navbar renders.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39467&comment_hash=80346483cdac6c5045313fdedb4c222502d0c7a642522e4a0584597347f8bf73&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39467&comment_hash=80346483cdac6c5045313fdedb4c222502d0c7a642522e4a0584597347f8bf73&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "shantanukhond (via GitHub)" <gi...@apache.org>.
shantanukhond commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4332477771
@sfirke done! I added those changes suggested by AI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "shantanukhond (via GitHub)" <gi...@apache.org>.
shantanukhond commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4331850624
> @shantanukhond when I look at your second and third commits after your original one, it says "This commit does not include any file changes" - and it doesn't look like you changed anything, e.g., importing the CSS file as the AI bot suggested. Am I missing something there? Also there is now a conflict to resolve.
All bottom comments after my first commit are for code rebase even like the last one I guess where you updated it where there was conflict. It is also showing no changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #39467:
URL: https://github.com/apache/superset/pull/39467#discussion_r3104510419
##########
docs/src/theme/Root.js:
##########
@@ -147,7 +147,9 @@ export default function Root({ children }) {
const button = event.target.closest('.get-started-button, .default-button-theme');
if (button) {
const buttonText = button.textContent?.trim() || 'Unknown';
- const href = button.getAttribute('href') || '';
+ const mainLink = button.querySelector('a.split-main');
+ const href =
+ mainLink?.getAttribute('href') || button.getAttribute('href') || '';
Review Comment:
**Suggestion:** The new CTA tracking logic always falls back to the split button's main link, so clicking the chevron trigger (which only opens the dropdown) is incorrectly recorded as a `/user-docs/` click. Use the actually clicked anchor first, and only fall back to the element's own `href`, so analytics reflects real navigation targets. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Matomo CTA metrics misreport dropdown-trigger clicks as /user-docs/.
- ⚠️ Homepage Get Started menu usage statistics become inaccurate.
- ⚠️ Navbar Get Started split-button interactions tracked with wrong targets.
```
</details>
```suggestion
const clickedLink = event.target.closest?.('a');
const href =
clickedLink?.getAttribute('href') || button.getAttribute('href') || '';
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Start the docs site using `cd docs && yarn start` as described in the PR, which serves
the homepage from `docs/src/pages/index.tsx`.
2. On the homepage, locate the hero "Get Started" split button rendered by
`GetStartedSplitButton` at `docs/src/pages/index.tsx:707-710`, which uses the component
from `docs/src/components/GetStartedSplitButton.tsx:124-135` (main link `<Link
to="/user-docs/" className="split-main">` at line 132 and dropdown trigger `<button
className="split-dropdown-trigger">` at lines 25-32).
3. Click directly on the chevron dropdown trigger (the button with
`className="split-dropdown-trigger"`) in the hero, not on the "Get Started" text. This
click is inside the `.default-button-theme` container
(`rootClassName="default-button-theme get-started-split"` in `index.tsx:709`), so the
global click handler registered in `docs/src/theme/Root.js` at lines 284-287
(`document.addEventListener('click', handleCTAClick);`) runs.
4. In `handleCTAClick` at `docs/src/theme/Root.js:146-75`, `button` becomes the outer
`.default-button-theme` element, `mainLink = button.querySelector('a.split-main')` finds
the `/user-docs/` anchor, and `href` is set to that `/user-docs/` URL even though the
chevron click only opens the `Dropdown` (no navigation). As a result, `trackEvent('CTA',
'Click', `${buttonText} - ${href}`);` logs the event as a `/user-docs/` CTA click. The
same mis-attribution occurs when clicking the navbar "Get Started" chevron rendered via
`docs/src/theme/NavbarItem/GetStartedSplitNavbarItem.tsx:23-26` (root class
`default-button-theme get-started-split get-started-button`), since the handler logic is
identical. The suggested change to derive `href` from `event.target.closest('a')` would
correctly leave `href` empty for chevron clicks, matching the fact that no navigation
occurs.
```
</details>
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20docs%2Fsrc%2Ftheme%2FRoot.js%0A%2A%2ALine%3A%2A%2A%20150%3A152%0A%2A%2AComment%3A%2A%2A%0A%09%2ALogic%20Error%3A%20The%20new%20CTA%20tracking%20logic%20always%20falls%20back%20to%20the%20split%20button%27s%20main%20link%2C%20so%20clicking%20the%20chevron%20trigger%20%28which%20only%20opens%20the%20dropdown%29%20is%20incorrectly%20recorded%20as%20a%20%60%2Fuser-docs%2F%60%20click.%20Use%20the%20actually%20clicked%20anchor%20first%2C%20and%20only%20fall%20back%20to%20the%20element%27s%20own%20%60href%60%2C%20so%20analytics%20reflects%20real%20navigation%20targets.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0A) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide
?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20docs%2Fsrc%2Ftheme%2FRoot.js%0A%2A%2ALine%3A%2A%2A%20150%3A152%0A%2A%2AComment%3A%2A%2A%0A%09%2ALogic%20Error%3A%20The%20new%20CTA%20tracking%20logic%20always%20falls%20back%20to%20the%20split%20button%27s%20main%20link%2C%20so%20clicking%20the%20chevron%20trigger%20%28which%20only%20opens%20the%20dropdown%29%20is%20incorrectly%20recorded%20as%20a%20%60%2Fuser-docs%2F%60%20click.%20Use%20the%20actually%20clicked%20anchor%20first%2C%20and%20only%20fall%20back%20to%20the%20element%27s%20own%20%60href%60%2C%20so%20analytics%20reflects%20real%20navigation%20targets.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0A)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/src/theme/Root.js
**Line:** 150:152
**Comment:**
*Logic Error: The new CTA tracking logic always falls back to the split button's main link, so clicking the chevron trigger (which only opens the dropdown) is incorrectly recorded as a `/user-docs/` click. Use the actually clicked anchor first, and only fall back to the element's own `href`, so analytics reflects real navigation targets.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39467&comment_hash=98fcfbcf9cc0b0e43103eb9be1879f7f7b2d5bcb31d59f2f1f04db09e0880dac&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39467&comment_hash=98fcfbcf9cc0b0e43103eb9be1879f7f7b2d5bcb31d59f2f1f04db09e0880dac&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): broken link and add split Get Started with audience links [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39467:
URL: https://github.com/apache/superset/pull/39467#issuecomment-4272717349
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org