You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by nishadi <gi...@git.apache.org> on 2017/08/07 14:26:14 UTC
[GitHub] gora pull request #115: GORA-518 Update the policies as per the 4.0.6 aerosp...
GitHub user nishadi opened a pull request:
https://github.com/apache/gora/pull/115
GORA-518 Update the policies as per the 4.0.6 aerospike java client
This PR contains changes to update the supported policy configurations as per the 4.0.6 Aerospike java client.
The configurable policies in both [write policy](https://www.aerospike.com/apidocs/java/com/aerospike/client/policy/WritePolicy.html) and [read policy](https://www.aerospike.com/apidocs/java/com/aerospike/client/policy/Policy.html) are made configurable with these changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nishadi/gora GORA-518
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit d93261e9492a2e6cdebcb1f47b4f24f7c93f4c9f
Author: nishadi <nd...@gmail.com>
Date: 2017-08-07T13:53:32Z
Update the policies as per the 4.0.6 aerospike java client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #115: GORA-518 Update the policies as per the 4.0.6 aerosp...
Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/115#discussion_r131670595
--- Diff: gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikePolicyConst.java ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.aerospike.store;
+
+public class AerospikePolicyConst {
--- End diff --
Shall we add java doc here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #115: GORA-518 Update the policies as per the 4.0.6 aerosp...
Posted by nishadi <gi...@git.apache.org>.
Github user nishadi commented on a diff in the pull request:
https://github.com/apache/gora/pull/115#discussion_r131671457
--- Diff: gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikePolicyConst.java ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.aerospike.store;
+
+public class AerospikePolicyConst {
--- End diff --
Added the java docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #115: GORA-518 Update the policies as per the 4.0.6 aerospike jav...
Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/115
@nishadi PR looks good. Will let some time allowing others to take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #115: GORA-518 Update the policies as per the 4.0.6 aerospike jav...
Posted by nishadi <gi...@git.apache.org>.
Github user nishadi commented on the issue:
https://github.com/apache/gora/pull/115
Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #115: GORA-518 Update the policies as per the 4.0.6 aerospike jav...
Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/115
@nishadi Merged the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #115: GORA-518 Update the policies as per the 4.0.6 aerosp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #115: GORA-518 Update the policies as per the 4.0.6 aerosp...
Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/115#discussion_r131668621
--- Diff: gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikeMappingBuilder.java ---
@@ -16,10 +16,7 @@
*/
package org.apache.gora.aerospike.store;
-import com.aerospike.client.policy.GenerationPolicy;
-import com.aerospike.client.policy.Policy;
-import com.aerospike.client.policy.RecordExistsAction;
-import com.aerospike.client.policy.WritePolicy;
+import com.aerospike.client.policy.*;
--- End diff --
Shall we remove this wild card imports?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #115: GORA-518 Update the policies as per the 4.0.6 aerospike jav...
Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/115
[INFO] Apache Gora ....................................... SUCCESS [1.683s]
[INFO] Apache Gora :: Compiler ........................... SUCCESS [1.866s]
[INFO] Apache Gora :: Compiler-CLI ....................... SUCCESS [1.054s]
[INFO] Apache Gora :: Core ............................... SUCCESS [1:17.569s]
[INFO] Apache Gora :: Accumulo ........................... SUCCESS [1:26.088s]
[INFO] Apache Gora :: Cassandra .......................... SUCCESS [44.335s]
[INFO] Apache Gora :: GoraCI ............................. SUCCESS [8.669s]
[INFO] Apache Gora :: HBase .............................. SUCCESS [2:32.693s]
[INFO] Apache Gora :: Infinispan ......................... SUCCESS [1:17.819s]
[INFO] Apache Gora :: JCache ............................. SUCCESS [59.781s]
[INFO] Apache Gora :: Dynamodb ........................... SUCCESS [3.486s]
[INFO] Apache Gora :: CouchDB ............................ SUCCESS [4.607s]
[INFO] Apache Gora :: Maven Plugin ....................... SUCCESS [2.794s]
[INFO] Apache Gora :: MongoDB ............................ SUCCESS [1:22.538s]
[INFO] Apache Gora :: Solr ............................... SUCCESS [3:01.099s]
[INFO] Apache Gora :: Aerospike .......................... SUCCESS [3.101s]
[INFO] Apache Gora :: Tutorial ........................... SUCCESS [9.868s]
[INFO] Apache Gora :: Sources-Dist ....................... SUCCESS [0.333s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:20.072s
[INFO] Finished at: Wed Aug 09 10:01:57 IST 2017
[INFO] Final Memory: 79M/741M
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #115: GORA-518 Update the policies as per the 4.0.6 aerosp...
Posted by nishadi <gi...@git.apache.org>.
Github user nishadi commented on a diff in the pull request:
https://github.com/apache/gora/pull/115#discussion_r131669721
--- Diff: gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikeMappingBuilder.java ---
@@ -16,10 +16,7 @@
*/
package org.apache.gora.aerospike.store;
-import com.aerospike.client.policy.GenerationPolicy;
-import com.aerospike.client.policy.Policy;
-import com.aerospike.client.policy.RecordExistsAction;
-import com.aerospike.client.policy.WritePolicy;
+import com.aerospike.client.policy.*;
--- End diff --
Removed the wild card import and added separate imports.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---