You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by "xubo245 (via GitHub)" <gi...@apache.org> on 2023/04/09 17:09:18 UTC

[GitHub] [carbondata] xubo245 opened a new pull request, #4315: [ISSUE-4313] Variable should use LowerCamelCase style

xubo245 opened a new pull request, #4315:
URL: https://github.com/apache/carbondata/pull/4315

    ### Why is this PR needed?
   
    There are some code smells in processing module
   For example
   1.Didn't add @OverRide for override method
   2.magic number
   3.variable Should Use LowerCamelCase
    
    ### What changes were proposed in this PR?
   
       variableShouldUseLowerCamelCase
   
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] chenliang613 merged pull request #4315: [ISSUE-4313] Variable should use LowerCamelCase style

Posted by "chenliang613 (via GitHub)" <gi...@apache.org>.
chenliang613 merged PR #4315:
URL: https://github.com/apache/carbondata/pull/4315


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] shenjiayu17 commented on pull request #4315: [ISSUE-4313] Variable should use LowerCamelCase style

Posted by "shenjiayu17 (via GitHub)" <gi...@apache.org>.
shenjiayu17 commented on PR #4315:
URL: https://github.com/apache/carbondata/pull/4315#issuecomment-1501402247

   Build Failed  with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6384/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] shenjiayu17 commented on pull request #4315: [ISSUE-4313] Variable should use LowerCamelCase style

Posted by "shenjiayu17 (via GitHub)" <gi...@apache.org>.
shenjiayu17 commented on PR #4315:
URL: https://github.com/apache/carbondata/pull/4315#issuecomment-1501223110

   Build Failed  with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4675/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] shenjiayu17 commented on pull request #4315: [ISSUE-4313] Variable should use LowerCamelCase style

Posted by "shenjiayu17 (via GitHub)" <gi...@apache.org>.
shenjiayu17 commented on PR #4315:
URL: https://github.com/apache/carbondata/pull/4315#issuecomment-1501285564

   Build Failed  with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/767/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org