You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by li...@apache.org on 2023/07/31 11:30:19 UTC

[seatunnel] branch dev updated: [Improve][Connector-v2][Jdbc] check url not null throw friendly message (#5097)

This is an automated email from the ASF dual-hosted git repository.

liugddx pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new b0815f2a95 [Improve][Connector-v2][Jdbc]  check url not null throw friendly message (#5097)
b0815f2a95 is described below

commit b0815f2a95e01acedb1fde7d56a81b32a5d3b494
Author: kk <12...@users.noreply.github.com>
AuthorDate: Mon Jul 31 19:30:13 2023 +0800

    [Improve][Connector-v2][Jdbc]  check url not null throw friendly message (#5097)
    
    * check url not null throw friendly message
    
    * check jdbc source config
    
    * modify jdbc validate method
    
    ---------
    
    Co-authored-by: 80597928 <Lz...@qq.com>
    Co-authored-by: 80597928 <67...@qq.com>
---
 .../apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSource.java   | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSource.java b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSource.java
index aa001f78e2..1bf1b332fa 100644
--- a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSource.java
+++ b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSource.java
@@ -21,6 +21,7 @@ import org.apache.seatunnel.shade.com.typesafe.config.Config;
 
 import org.apache.seatunnel.api.common.PrepareFailException;
 import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.configuration.util.ConfigValidator;
 import org.apache.seatunnel.api.serialization.Serializer;
 import org.apache.seatunnel.api.source.Boundedness;
 import org.apache.seatunnel.api.source.SeaTunnelSource;
@@ -94,6 +95,7 @@ public class JdbcSource
     @Override
     public void prepare(Config pluginConfig) throws PrepareFailException {
         ReadonlyConfig config = ReadonlyConfig.fromConfig(pluginConfig);
+        ConfigValidator.of(config).validate(new JdbcSourceFactory().optionRule());
         this.jdbcSourceConfig = JdbcSourceConfig.of(config);
         this.jdbcConnectionProvider =
                 new SimpleJdbcConnectionProvider(jdbcSourceConfig.getJdbcConnectionConfig());