[jira] [Commented] (APEXCORE-596) Committed method on operators not called when stream locality is THREAD_LOCAL

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/APEXCORE-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800763#comment-15800763 ] 

ASF GitHub Bot commented on APEXCORE-596:
-----------------------------------------

GitHub user francisf opened a pull request:

    https://github.com/apache/apex-core/pull/442

    APEXCORE-596 Setting the thread for all oio nodes in the oio group

    @tushargosavi please review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/francisf/apex-core APEXCORE-596_OioThreadSet

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-core/pull/442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #442
    
----
commit 89fb23c106163d92907038acfb72b3fb810d9246
Author: francisf <fr...@gmail.com>
Date:   2017-01-05T07:32:05Z

    APEXCORE-596 Setting the thread for all oio nodes in the oio group

----


> Committed method on operators not called when stream locality is THREAD_LOCAL
> -----------------------------------------------------------------------------
>
>                 Key: APEXCORE-596
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-596
>             Project: Apache Apex Core
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Francis Fernandes
>            Assignee: Francis Fernandes
>
> When the locality of the stream connecting the two operators is Locality.THREAD_LOCAL, the committed method is not called for some operators. These operators implement the Operator.CheckpointListener. e.g. AbstractFileOutputOperator
> For thread local during activate  we do not set the thread in the node's context
> Because the thread is not set, we skip this operator in the processHeartBeatResponse and the committed is not called
> {code}
> if (thread == null || !thread.isAlive()) {
>           continue;
>         }
> {code}
> We need this condition for invalid operators (operator failures) in case of other localities. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)