You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "sankalp kohli (JIRA)" <ji...@apache.org> on 2012/08/13 23:34:38 UTC

[jira] [Created] (CASSANDRA-4537) We should emit number of sstables in each level from JMX

sankalp kohli created CASSANDRA-4537:
----------------------------------------

             Summary: We should emit number of sstables in each level from JMX
                 Key: CASSANDRA-4537
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4537
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 1.2
            Reporter: sankalp kohli
            Priority: Minor


We should add methods to this Mbean org.apache.cassandra.db.ColumnFamilyStoreMBean

These metrics will be helpful to see how sstables are distributed in different levels and how they move to higher level with time. 
Currently we can see this by looking at the json file but with JMX, we can monitor the historic values over time using any monitoring tool.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4537) We should emit number of sstables in each level from JMX

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450985#comment-13450985 ] 

Jonathan Ellis commented on CASSANDRA-4537:
-------------------------------------------

Idea: show number of sstables / desired max, when we exceed the desired threshold?  This would give you a quick eyeball of "here's where compaction is behind."

SSTables in each level: [43/0, 8, 102/100, 123, 0, 0, 0, 0]

                
> We should emit number of sstables in each level from JMX
> --------------------------------------------------------
>
>                 Key: CASSANDRA-4537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4537
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: sankalp kohli
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: compaction, leveled
>             Fix For: 1.2.1
>
>         Attachments: 4537.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> We should add methods to this Mbean org.apache.cassandra.db.ColumnFamilyStoreMBean
> These metrics will be helpful to see how sstables are distributed in different levels and how they move to higher level with time. 
> Currently we can see this by looking at the json file but with JMX, we can monitor the historic values over time using any monitoring tool.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4537) We should emit number of sstables in each level from JMX

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-4537:
--------------------------------------

             Reviewer: jbellis
    Affects Version/s:     (was: 1.2.0 beta 1)
                       1.0.0
        Fix Version/s: 1.2.1
             Assignee: Yuki Morishita
    
> We should emit number of sstables in each level from JMX
> --------------------------------------------------------
>
>                 Key: CASSANDRA-4537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4537
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: sankalp kohli
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: compaction, leveled
>             Fix For: 1.2.1
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> We should add methods to this Mbean org.apache.cassandra.db.ColumnFamilyStoreMBean
> These metrics will be helpful to see how sstables are distributed in different levels and how they move to higher level with time. 
> Currently we can see this by looking at the json file but with JMX, we can monitor the historic values over time using any monitoring tool.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4537) We should emit number of sstables in each level from JMX

Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yuki Morishita updated CASSANDRA-4537:
--------------------------------------

    Attachment: 4537-v2.txt

v2 attached. It displays max threshold of level when exceeded.
                
> We should emit number of sstables in each level from JMX
> --------------------------------------------------------
>
>                 Key: CASSANDRA-4537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4537
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: sankalp kohli
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: compaction, leveled
>             Fix For: 1.2.1
>
>         Attachments: 4537.txt, 4537-v2.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> We should add methods to this Mbean org.apache.cassandra.db.ColumnFamilyStoreMBean
> These metrics will be helpful to see how sstables are distributed in different levels and how they move to higher level with time. 
> Currently we can see this by looking at the json file but with JMX, we can monitor the historic values over time using any monitoring tool.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CASSANDRA-4537) We should emit number of sstables in each level from JMX

Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yuki Morishita resolved CASSANDRA-4537.
---------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.2.1)
                   1.2.0 beta 1

Committed with above nit fixed.
                
> We should emit number of sstables in each level from JMX
> --------------------------------------------------------
>
>                 Key: CASSANDRA-4537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4537
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: sankalp kohli
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: compaction, leveled
>             Fix For: 1.2.0 beta 1
>
>         Attachments: 4537.txt, 4537-v2.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> We should add methods to this Mbean org.apache.cassandra.db.ColumnFamilyStoreMBean
> These metrics will be helpful to see how sstables are distributed in different levels and how they move to higher level with time. 
> Currently we can see this by looking at the json file but with JMX, we can monitor the historic values over time using any monitoring tool.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4537) We should emit number of sstables in each level from JMX

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433833#comment-13433833 ] 

Brandon Williams commented on CASSANDRA-4537:
---------------------------------------------

I would go one further and say it should be available via nodetool compactionstats.  I can't count the number of times I've had to paste a python script that prints level counts.
                
> We should emit number of sstables in each level from JMX
> --------------------------------------------------------
>
>                 Key: CASSANDRA-4537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4537
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: sankalp kohli
>            Priority: Minor
>              Labels: compaction, leveled
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> We should add methods to this Mbean org.apache.cassandra.db.ColumnFamilyStoreMBean
> These metrics will be helpful to see how sstables are distributed in different levels and how they move to higher level with time. 
> Currently we can see this by looking at the json file but with JMX, we can monitor the historic values over time using any monitoring tool.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4537) We should emit number of sstables in each level from JMX

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453326#comment-13453326 ] 

Jonathan Ellis commented on CASSANDRA-4537:
-------------------------------------------

+1, lgtm

nit: getLevelSize call is a little confusing since it handles i > generations.length, inlining to generations[i].size might be more clear
                
> We should emit number of sstables in each level from JMX
> --------------------------------------------------------
>
>                 Key: CASSANDRA-4537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4537
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: sankalp kohli
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: compaction, leveled
>             Fix For: 1.2.1
>
>         Attachments: 4537.txt, 4537-v2.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> We should add methods to this Mbean org.apache.cassandra.db.ColumnFamilyStoreMBean
> These metrics will be helpful to see how sstables are distributed in different levels and how they move to higher level with time. 
> Currently we can see this by looking at the json file but with JMX, we can monitor the historic values over time using any monitoring tool.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4537) We should emit number of sstables in each level from JMX

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453539#comment-13453539 ] 

Hudson commented on CASSANDRA-4537:
-----------------------------------

Integrated in Cassandra #2090 (See [https://builds.apache.org/job/Cassandra/2090/])
    Add SSTable count per level to cfstats patch by yukim; reviewed by jbellis for CASSANDRA-4537 (Revision c64d975cdf9eebddb04801573035a7272f779fed)

     Result = ABORTED
yukim : 
Files : 
* src/java/org/apache/cassandra/db/compaction/LeveledManifest.java
* src/java/org/apache/cassandra/tools/NodeCmd.java
* src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java
* CHANGES.txt
* src/java/org/apache/cassandra/db/ColumnFamilyStore.java
* src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java

                
> We should emit number of sstables in each level from JMX
> --------------------------------------------------------
>
>                 Key: CASSANDRA-4537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4537
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: sankalp kohli
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: compaction, leveled
>             Fix For: 1.2.0 beta 1
>
>         Attachments: 4537.txt, 4537-v2.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> We should add methods to this Mbean org.apache.cassandra.db.ColumnFamilyStoreMBean
> These metrics will be helpful to see how sstables are distributed in different levels and how they move to higher level with time. 
> Currently we can see this by looking at the json file but with JMX, we can monitor the historic values over time using any monitoring tool.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4537) We should emit number of sstables in each level from JMX

Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yuki Morishita updated CASSANDRA-4537:
--------------------------------------

    Attachment: 4537.txt

Attaching patch that adds SSTableCountPerLevel to ColulmnFamilyStoreMBean, which returns number of SSTable for each level in _int[]_ and prints it with nodetool cfstats.

Output looks like below:
{code}
...
    Column Family: Standard1
    SSTable count: 19
    SSTables in each level: [0, 8, 11, 0, 0, 0, 0, 0]
    Space used (live): 100923462
    Space used (total): 101012612
...
{code}

compactionstats displays info only when compaction is happening, so I chose cfstats to show info.

cfstats output is long, but let CASSANDRA-4191 handle it.
                
> We should emit number of sstables in each level from JMX
> --------------------------------------------------------
>
>                 Key: CASSANDRA-4537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4537
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: sankalp kohli
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: compaction, leveled
>             Fix For: 1.2.1
>
>         Attachments: 4537.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> We should add methods to this Mbean org.apache.cassandra.db.ColumnFamilyStoreMBean
> These metrics will be helpful to see how sstables are distributed in different levels and how they move to higher level with time. 
> Currently we can see this by looking at the json file but with JMX, we can monitor the historic values over time using any monitoring tool.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira