You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/02/27 00:40:32 UTC

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan' 

Hello Yingchun Lai,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12618

to review the following change.


Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................

tools: make it easier to scan full rows with 'kudu table scan'

This changes the 'table scan' tool so that if --show_value is passed, or
if '--columns=*' is specified, the entire row is projected. Previously,
the user would have to manually list out all columns of the table, which
is somewhat tedious.

Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
---
M src/kudu/tools/table_scanner.cc
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12618/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 1:

A very useful improvement, can we merge it quickly?


-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 08 May 2019 03:02:19 +0000
Gerrit-HasComments: No

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has uploaded a new patch set (#3) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................

tools: make it easier to scan full rows with 'kudu table scan'

This changes the 'table scan' tool so that if --show_values is passed, or
if '--columns=*' is specified, the entire row is projected. Previously,
the user would have to manually list out all columns of the table, which
is somewhat tedious.

Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
2 files changed, 19 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12618/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc
File src/kudu/tools/table_scanner.cc:

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc@344
PS1, Line 344:   bool project_all = FLAGS_columns == "*" ||
> btw we're already sort of relying on the user not having a literal ',' in t
Maybe a JSON list is a kind of method to solve this, but it will be inconvenience to use this CLI tool. Anyway, keep it simple is ok as a tool.



-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 01:35:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> A very useful improvement, can we merge it quickly?

I had to rebase it to bring it up to date. Please rereview.


-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 08 May 2019 05:19:25 +0000
Gerrit-HasComments: No

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc
File src/kudu/tools/table_scanner.cc:

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc@344
PS1, Line 344:   bool project_all = FLAGS_columns == "*" ||
> If we ever ran into the case where someone hit this, we could add some supp
btw we're already sort of relying on the user not having a literal ',' in their column names, so I dunno that '*' is any worse :)



-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 23:01:12 +0000
Gerrit-HasComments: Yes

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................

tools: make it easier to scan full rows with 'kudu table scan'

This changes the 'table scan' tool so that if --show_values is passed, or
if '--columns=*' is specified, the entire row is projected. Previously,
the user would have to manually list out all columns of the table, which
is somewhat tedious.

Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Reviewed-on: http://gerrit.cloudera.org:8080/12618
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <40...@qq.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
2 files changed, 19 insertions(+), 4 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yingchun Lai: Looks good to me, but someone else must approve
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Thu, 16 May 2019 01:59:41 +0000
Gerrit-HasComments: No

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 08 May 2019 16:55:39 +0000
Gerrit-HasComments: No

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc
File src/kudu/tools/table_scanner.cc:

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc@344
PS1, Line 344:   bool project_all = FLAGS_columns == "*" ||
> I was ever want to add this logic code, but how to deal the case when a col
I thought about this a bit. We could remove the '*' option but I thought it was unlikely that someone would name a column '*', and this is just a CLI tool. It would still be possible to access such a column from a real API. What do others think about this?



-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 17:50:33 +0000
Gerrit-HasComments: Yes

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc
File src/kudu/tools/table_scanner.cc:

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc@344
PS1, Line 344:   bool project_all = FLAGS_columns == "*" ||
I was ever want to add this logic code, but how to deal the case when a column named "*"?



-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 15:55:17 +0000
Gerrit-HasComments: Yes

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 08 May 2019 05:43:18 +0000
Gerrit-HasComments: No

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 03:27:04 +0000
Gerrit-HasComments: No

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 01:35:18 +0000
Gerrit-HasComments: No

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Removed Code-Review+1 by Yingchun Lai <40...@qq.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has uploaded a new patch set (#2) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................

tools: make it easier to scan full rows with 'kudu table scan'

This changes the 'table scan' tool so that if --show_value is passed, or
if '--columns=*' is specified, the entire row is projected. Previously,
the user would have to manually list out all columns of the table, which
is somewhat tedious.

Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
---
M src/kudu/tools/table_scanner.cc
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12618/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Thu, 16 May 2019 03:33:14 +0000
Gerrit-HasComments: No

[kudu-CR] tools: make it easier to scan full rows with 'kudu table scan'

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )

Change subject: tools: make it easier to scan full rows with 'kudu table scan'
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc
File src/kudu/tools/table_scanner.cc:

http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc@344
PS1, Line 344:   bool project_all = FLAGS_columns == "*" ||
> I thought about this a bit. We could remove the '*' option but I thought it
If we ever ran into the case where someone hit this, we could add some support for escaping the * with \ or something similar. Until someone needs it, I am not sure we should worry about this case.



-- 
To view, visit http://gerrit.cloudera.org:8080/12618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6
Gerrit-Change-Number: 12618
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 19:06:20 +0000
Gerrit-HasComments: Yes