You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/13 07:44:23 UTC
[GitHub] [airflow] potiuk opened a new pull request #7711: [AIRFLOW-7055]
Verbose logging option for google provider
potiuk opened a new pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598711733
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7e1523684c9e338889403a90be9742ac40915f0d&el=desc) will **decrease** coverage by `0.51%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 86.93% 86.42% -0.52%
==========================================
Files 910 911 +1
Lines 44073 44084 +11
==========================================
- Hits 38316 38099 -217
- Misses 5757 5985 +228
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/google/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL19faW5pdF9fLnB5) | `36.36% <36.36%> (ø)` | |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0.00%> (-32.36%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=footer). Last update [7e15236...73d0c05](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7711: [AIRFLOW-7055] Verbose
logging option for google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598695291
And we have more and more provider-specific stuff in providers, which is a good sign for AIP-8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598711733
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7e1523684c9e338889403a90be9742ac40915f0d&el=desc) will **decrease** coverage by `0.51%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 86.93% 86.42% -0.52%
==========================================
Files 910 911 +1
Lines 44073 44084 +11
==========================================
- Hits 38316 38099 -217
- Misses 5757 5985 +228
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/google/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL19faW5pdF9fLnB5) | `36.36% <36.36%> (ø)` | |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0.00%> (-32.36%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=footer). Last update [7e15236...73d0c05](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#discussion_r392130777
##########
File path: airflow/providers/__init__.py
##########
@@ -14,3 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from airflow.config_templates.airflow_local_settings import DEFAULT_LOGGING_CONFIG, LOG_LEVEL
+from airflow.configuration import conf
+
+PROVIDERS_LOGGING_SETTINGS: str = conf.get('providers_google', 'VERBOSE_LOGGING')
+if PROVIDERS_LOGGING_SETTINGS == "true":
+ for a in ["google_auth_httplib2", "httplib2", "googleapiclient"]:
Review comment:
Let's change the name to something different from `a` :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#discussion_r392392550
##########
File path: airflow/providers/google/__init__.py
##########
@@ -14,3 +14,19 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+import logging
+
+from airflow.configuration import conf
+
+PROVIDERS_GOOGLE_VERBOSE_LOGGING: bool = conf.getboolean('providers_google',
+ 'VERBOSE_LOGGING', fallback=False)
+if PROVIDERS_GOOGLE_VERBOSE_LOGGING:
+ for a in ["google_auth_httplib2", "httplib2", "googleapiclient"]:
+ logger = logging.getLogger(a)
+ logger.handlers = [handler for handler in
Review comment:
Now I understand why. Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#discussion_r392341080
##########
File path: airflow/providers/google/__init__.py
##########
@@ -14,3 +14,19 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+import logging
+
+from airflow.configuration import conf
+
+PROVIDERS_GOOGLE_VERBOSE_LOGGING: bool = conf.getboolean('providers_google',
+ 'VERBOSE_LOGGING', fallback=False)
+if PROVIDERS_GOOGLE_VERBOSE_LOGGING:
+ for a in ["google_auth_httplib2", "httplib2", "googleapiclient"]:
+ logger = logging.getLogger(a)
+ logger.handlers = [handler for handler in
Review comment:
Should we add instead of replace handlers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#discussion_r392141394
##########
File path: airflow/providers/__init__.py
##########
@@ -14,3 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from airflow.config_templates.airflow_local_settings import DEFAULT_LOGGING_CONFIG, LOG_LEVEL
+from airflow.configuration import conf
+
+PROVIDERS_LOGGING_SETTINGS: str = conf.get('providers_google', 'VERBOSE_LOGGING')
+if PROVIDERS_LOGGING_SETTINGS == "true":
+ for a in ["google_auth_httplib2", "httplib2", "googleapiclient"]:
Review comment:
Yeah. I am rewriting it a bit!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#discussion_r392357581
##########
File path: airflow/providers/google/__init__.py
##########
@@ -14,3 +14,19 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+import logging
+
+from airflow.configuration import conf
+
+PROVIDERS_GOOGLE_VERBOSE_LOGGING: bool = conf.getboolean('providers_google',
+ 'VERBOSE_LOGGING', fallback=False)
+if PROVIDERS_GOOGLE_VERBOSE_LOGGING:
+ for a in ["google_auth_httplib2", "httplib2", "googleapiclient"]:
+ logger = logging.getLogger(a)
+ logger.handlers = [handler for handler in
Review comment:
What would be the consequence of that? Do you think it's better to add?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598711733
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7e1523684c9e338889403a90be9742ac40915f0d&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 86.93% 86.92% -0.02%
==========================================
Files 910 911 +1
Lines 44073 44084 +11
==========================================
+ Hits 38316 38320 +4
- Misses 5757 5764 +7
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/google/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL19faW5pdF9fLnB5) | `36.36% <36.36%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=footer). Last update [7e15236...73d0c05](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#discussion_r392141541
##########
File path: airflow/providers/__init__.py
##########
@@ -14,3 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from airflow.config_templates.airflow_local_settings import DEFAULT_LOGGING_CONFIG, LOG_LEVEL
+from airflow.configuration import conf
+
+PROVIDERS_LOGGING_SETTINGS: str = conf.get('providers_google', 'VERBOSE_LOGGING')
Review comment:
> Yes, can we move it to `airflow.providers.google.__init__.py` please?
Yes. it was mistake :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598711733
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7e1523684c9e338889403a90be9742ac40915f0d?src=pr&el=desc) will **decrease** coverage by `22.44%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
===========================================
- Coverage 86.93% 64.49% -22.45%
===========================================
Files 910 910
Lines 44073 44071 -2
===========================================
- Hits 38316 28423 -9893
- Misses 5757 15648 +9891
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/google/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL19faW5pdF9fLnB5) | `36.36% <36.36%> (ø)` | |
| [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/sensors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvX19pbml0X18ucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...viders/docker/example\_dags/example\_docker\_swarm.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZG9ja2VyL2V4YW1wbGVfZGFncy9leGFtcGxlX2RvY2tlcl9zd2FybS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/webhdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy93ZWJoZGZzX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...irflow/contrib/operators/slack\_webhook\_operator.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zbGFja193ZWJob29rX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...providers/google/cloud/example\_dags/example\_dlp.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2RscC5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| ... and [492 more](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=footer). Last update [7e15236...73d0c05](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7711: [AIRFLOW-7055] Verbose
logging option for google provider
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#discussion_r392131085
##########
File path: airflow/providers/__init__.py
##########
@@ -14,3 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from airflow.config_templates.airflow_local_settings import DEFAULT_LOGGING_CONFIG, LOG_LEVEL
+from airflow.configuration import conf
+
+PROVIDERS_LOGGING_SETTINGS: str = conf.get('providers_google', 'VERBOSE_LOGGING')
Review comment:
Should we set a fallback value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7711: [AIRFLOW-7055] Verbose
logging option for google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598741182
All good now. It works like a charm @mik-laj @kaxil -> (thanks @mik-laj for the "email version" of it ).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598711733
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7e1523684c9e338889403a90be9742ac40915f0d&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 86.93% 86.92% -0.02%
==========================================
Files 910 911 +1
Lines 44073 44084 +11
==========================================
+ Hits 38316 38320 +4
- Misses 5757 5764 +7
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/google/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL19faW5pdF9fLnB5) | `36.36% <36.36%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=footer). Last update [7e15236...73d0c05](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7711: [AIRFLOW-7055]
Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598711733
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/c997cab42d8695ac444e63dfe4b948a7ea82ed89?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 86.93% 86.64% -0.29%
==========================================
Files 909 910 +1
Lines 43975 43986 +11
==========================================
- Hits 38229 38112 -117
- Misses 5746 5874 +128
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/google/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL19faW5pdF9fLnB5) | `36.36% <36.36%> (ø)` | |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88.33% <0%> (-0.39%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=footer). Last update [c997cab...d76bd1a](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598711733
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7e1523684c9e338889403a90be9742ac40915f0d&el=desc) will **decrease** coverage by `0.51%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 86.93% 86.42% -0.52%
==========================================
Files 910 911 +1
Lines 44073 44084 +11
==========================================
- Hits 38316 38099 -217
- Misses 5757 5985 +228
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/google/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL19faW5pdF9fLnB5) | `36.36% <36.36%> (ø)` | |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0.00%> (-32.36%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=footer). Last update [7e15236...73d0c05](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598711733
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/c997cab42d8695ac444e63dfe4b948a7ea82ed89?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 86.93% 86.64% -0.29%
==========================================
Files 909 910 +1
Lines 43975 43986 +11
==========================================
- Hits 38229 38112 -117
- Misses 5746 5874 +128
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/google/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL19faW5pdF9fLnB5) | `36.36% <36.36%> (ø)` | |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88.33% <0%> (-0.39%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=footer). Last update [c997cab...d76bd1a](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#discussion_r392372768
##########
File path: airflow/providers/google/__init__.py
##########
@@ -14,3 +14,19 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+import logging
+
+from airflow.configuration import conf
+
+PROVIDERS_GOOGLE_VERBOSE_LOGGING: bool = conf.getboolean('providers_google',
+ 'VERBOSE_LOGGING', fallback=False)
+if PROVIDERS_GOOGLE_VERBOSE_LOGGING:
+ for a in ["google_auth_httplib2", "httplib2", "googleapiclient"]:
+ logger = logging.getLogger(a)
+ logger.handlers = [handler for handler in
Review comment:
I configure loggers in my configuration file. Now, when I use this option, my configuration will be overwritten. I won't even know why my configuration has not been used because there will be no message.This is a very small problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#discussion_r392141980
##########
File path: airflow/providers/__init__.py
##########
@@ -14,3 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from airflow.config_templates.airflow_local_settings import DEFAULT_LOGGING_CONFIG, LOG_LEVEL
+from airflow.configuration import conf
+
+PROVIDERS_LOGGING_SETTINGS: str = conf.get('providers_google', 'VERBOSE_LOGGING')
Review comment:
And yes fall back... I also have to make it differently to account for different logging not only the default config (pointed out by @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7711:
[AIRFLOW-7055] Verbose logging option for google provider
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598711733
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7e1523684c9e338889403a90be9742ac40915f0d&el=desc) will **decrease** coverage by `0.51%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 86.93% 86.42% -0.52%
==========================================
Files 910 911 +1
Lines 44073 44084 +11
==========================================
- Hits 38316 38099 -217
- Misses 5757 5985 +228
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/google/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL19faW5pdF9fLnB5) | `36.36% <36.36%> (ø)` | |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0.00%> (-32.36%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/airflow/pull/7711/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=footer). Last update [7e15236...73d0c05](https://codecov.io/gh/apache/airflow/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7711: [AIRFLOW-7055] Verbose
logging option for google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7711: [AIRFLOW-7055] Verbose logging option for google provider
URL: https://github.com/apache/airflow/pull/7711#issuecomment-598695111
I think I got it correctly now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services