[GitHub] [beam] lukecwik commented on a change in pull request #15442: [BEAM-12767] Add another unit test for PipelineOptions deserialization

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #15442:
URL: https://github.com/apache/beam/pull/15442#discussion_r701217279



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
##########
@@ -501,7 +502,9 @@ public Registration(Class<T> proxyClass, List<PropertyDescriptor> beanInfo) {
   private static final DefaultDeserializationContext DESERIALIZATION_CONTEXT =
       new DefaultDeserializationContext.Impl(MAPPER.getDeserializationContext().getFactory())
           .createInstance(
-              MAPPER.getDeserializationConfig(), new TokenBuffer(MAPPER, false).asParser(), null);
+              MAPPER.getDeserializationConfig(),
+              new TokenBuffer(MAPPER, false).asParser(),
+              new InjectableValues.Std());

Review comment:
       It will just lead to a different exception being thrown [no injectable values](https://github.com/joansmith/jackson-databind/blob/230a19d527df7dc0c05017429bcb7aa1cbbe41ef/src/main/java/com/fasterxml/jackson/databind/DeserializationContext.java#L375) vs [can't find the value](https://github.com/joansmith/jackson-databind/blob/230a19d527df7dc0c05017429bcb7aa1cbbe41ef/src/main/java/com/fasterxml/jackson/databind/InjectableValues.java#L75) since the InjectableValues is empty.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org