You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/03 16:40:14 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #15675: [BEAM-12313] - Initial changes to support Java 17 SDK Harness docker image

kennknowles commented on a change in pull request #15675:
URL: https://github.com/apache/beam/pull/15675#discussion_r742132102



##########
File path: sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/jvmverification/JvmVerification.java
##########
@@ -55,6 +54,11 @@ public void verifyTestCodeIsCompiledWithJava11() throws IOException {
     assertEquals(v11, getByteCodeVersion(JvmVerification.class));
   }
 
+  @Test
+  public void verifyTestCodeIsCompiledWithJava17() throws IOException {
+    assertEquals(v17, getByteCodeVersion(JvmVerification.class));

Review comment:
       Need to add an entry to `versionMapping`, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org