You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "jackeyfaker77 (via GitHub)" <gi...@apache.org> on 2026/09/04 19:35:28 UTC
[PR] docs: audit Desktop and frontend references [maka]
jackeyfaker77 opened a new pull request, #4810:
URL: https://github.com/apache/maka/pull/4810
## Summary
- Audit all seven Desktop and frontend documents against the current renderer and `@maka/ui` implementation.
- Keep the generated file-level inventory as the current authority, and mark four dated audit/fix logs as historical with fresh current-state pointers.
- Synchronize the English and Chinese CSS governance documents with the current layer order, selector scopes, token ownership, and `!important` exception policy.
- Reconcile the contradictory historical height classification and remove a duplicate audit row.
Refs #3522
## Verification
- `npm run astryx:surface-inventory` — 249 files, 0 blockers, 0 reimplementations, 1 polish item, 248 aligned.
- `npm run astryx:surface-inventory:test` — 19/19 tests passed.
- `node apps/desktop/scripts/check-renderer-architecture.mjs` — passed.
- Changed-document ASF header validation — all six headers canonical.
- Relative Markdown link and exact repository path checks — no missing targets.
- `git diff --check` — passed.
- `npm run check:renderer-architecture` — 97/98 fixture tests passed; the single failure is Windows path normalization of a POSIX-only `/fixture/...` fixture test input. The actual renderer architecture checker above passes.
- Full-checkout ASF validation: pre-existing missing headers under untracked `.bika-*` staging directories are unrelated to this PR.
## Checklist
- [ ] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
*Documentation-only change; Biome ignores Markdown and no product runtime typecheck was required. All relevant generator and architecture checks pass as reported above.*
Does this PR entail a change in behavior?
- [ ] Yes — described under Summary above
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] docs: audit Desktop and frontend references [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4810:
URL: https://github.com/apache/maka/pull/4810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] docs: audit Desktop and frontend references [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #4810:
URL: https://github.com/apache/maka/pull/4810#issuecomment-5872234649
Thanks @jackeyfaker77 for the contribution and for following up on review feedback. Merging at @Astro-Han's request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] docs: audit Desktop and frontend references [maka]
Posted by "jackeyfaker77 (via GitHub)" <gi...@apache.org>.
jackeyfaker77 commented on PR #4810:
URL: https://github.com/apache/maka/pull/4810#issuecomment-5553780356
Addressed in 9b176466c: added the missing !important overrides to both the English and Chinese governance docs. The surface inventory consistency check and all 19 tests pass.
The dated historical snapshots are retained, and automated translation-sync checks remain outside this PR’s scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org