[GitHub] [pulsar] lhotari commented on pull request #17419: [fix][broker] Remove timestamp from Promtheus metrics

[GitBox <gi...@apache.org>]

lhotari commented on PR #17419:
URL: https://github.com/apache/pulsar/pull/17419#issuecomment-1235116484

   This change is also consistent with ZK and BK since the Prometheus metrics for ZK or BK don't have the timestamps. 
   
   I verified this on a local microk8s cluster by opening a shell to a ZK and a BK pod:
   
   no timestamps in ZK metrics
   ```
   I have no name!@pulsar-testenv-pulsar-zookeeper-0:/pulsar$ curl -s http://localhost:8000/metrics|tail -n 10
   process_open_fds 314.0
   # HELP process_max_fds Maximum number of open file descriptors.
   # TYPE process_max_fds gauge
   process_max_fds 65536.0
   # HELP process_virtual_memory_bytes Virtual memory size in bytes.
   # TYPE process_virtual_memory_bytes gauge
   process_virtual_memory_bytes 5.394948096E9
   # HELP process_resident_memory_bytes Resident memory size in bytes.
   # TYPE process_resident_memory_bytes gauge
   process_resident_memory_bytes 1.96804608E8
   ```
   
   no timestamps in BK metrics
   ```
   I have no name!@pulsar-testenv-pulsar-bookkeeper-0:/pulsar$ curl -s localhost:8000/metrics | tail -n 10
   bookie_bookie_zk_create_sum{success="false"} 0.0
   bookie_bookie_zk_create{success="true",quantile="0.5"} NaN
   bookie_bookie_zk_create{success="true",quantile="0.75"} NaN
   bookie_bookie_zk_create{success="true",quantile="0.95"} NaN
   bookie_bookie_zk_create{success="true",quantile="0.99"} NaN
   bookie_bookie_zk_create{success="true",quantile="0.999"} NaN
   bookie_bookie_zk_create{success="true",quantile="0.9999"} NaN
   bookie_bookie_zk_create{success="true",quantile="1.0"} NaN
   bookie_bookie_zk_create_count{success="true"} 3
   bookie_bookie_zk_create_sum{success="true"} 12.0
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org