You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2016/03/14 18:31:08 UTC
Review Request 44795: HDP 2.3.4 package install through Ambari on
SLES11 hosts fails
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44795/
-----------------------------------------------------------
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-15405
https://issues.apache.org/jira/browse/AMBARI-15405
Repository: ambari
Description
-------
# Installing bits for new registered version fails on suse11 if it is having any other additional repo
# This is because of a parsing error and out of index error in ambari-agent's zypper.py file
{code}
2016-03-10 15:12:19,018 - Package['ranger_2_3_4_0_3485*-admin'] {'use_repos': ['base', 'HDP-2.3.4.0-3485', 'HDP-UTILS-2.3.4.0-3485'], 'skip_repos': []}
2016-03-10 15:12:19,194 - Package Manager failed to install packages. Error: list index out of range
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 376, in install_packages
skip_repos=[self.REPO_FILE_NAME_PREFIX + "*"] if OSCheck.is_redhat_family() else [])
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
self.env.run()
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
self.run_action(resource, action)
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
provider_action()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py", line 49, in action_install
self.install_package(package_name, self.resource.use_repos, self.resource.skip_repos)
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 45, in install_package
active_base_repos = self.get_active_base_repos()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 78, in get_active_base_repos
if line_list[3].strip() == 'Yes' and line_list[2].strip().startswith("SUSE-"):
IndexError: list index out of range
2016-03-10 15:12:19,918 - Installation of packages failed. Checking if installation was partially complete
{code}
Diffs
-----
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py a519ce0
Diff: https://reviews.apache.org/r/44795/diff/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 44795: HDP 2.3.4 package install through Ambari on
SLES11 hosts fails
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On March 14, 2016, 8:23 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/core/providers/package/zypper.py, line 78
> > <https://reviews.apache.org/r/44795/diff/1/?file=1297436#file1297436line78>
> >
> > It's useful here to include a comment with that that output looks like so it's easier for others to read.
> > Why not ignore lines that begin with "-" after stripping whitespace characters?
ignoring lines that begin with "-" seems to be too tricky, since we saw various repo names that contain : , @ and so on.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44795/#review123472
-----------------------------------------------------------
On March 14, 2016, 7:31 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44795/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 7:31 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-15405
> https://issues.apache.org/jira/browse/AMBARI-15405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> # Installing bits for new registered version fails on suse11 if it is having any other additional repo
> # This is because of a parsing error and out of index error in ambari-agent's zypper.py file
> {code}
> 2016-03-10 15:12:19,018 - Package['ranger_2_3_4_0_3485*-admin'] {'use_repos': ['base', 'HDP-2.3.4.0-3485', 'HDP-UTILS-2.3.4.0-3485'], 'skip_repos': []}
> 2016-03-10 15:12:19,194 - Package Manager failed to install packages. Error: list index out of range
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 376, in install_packages
> skip_repos=[self.REPO_FILE_NAME_PREFIX + "*"] if OSCheck.is_redhat_family() else [])
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py", line 49, in action_install
> self.install_package(package_name, self.resource.use_repos, self.resource.skip_repos)
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 45, in install_package
> active_base_repos = self.get_active_base_repos()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 78, in get_active_base_repos
> if line_list[3].strip() == 'Yes' and line_list[2].strip().startswith("SUSE-"):
> IndexError: list index out of range
> 2016-03-10 15:12:19,918 - Installation of packages failed. Checking if installation was partially complete
> {code}
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py a519ce0
>
> Diff: https://reviews.apache.org/r/44795/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 44795: HDP 2.3.4 package install through Ambari on
SLES11 hosts fails
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44795/#review123472
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py (line 78)
<https://reviews.apache.org/r/44795/#comment185712>
It's useful here to include a comment with that that output looks like so it's easier for others to read.
Why not ignore lines that begin with "-" after stripping whitespace characters?
- Alejandro Fernandez
On March 14, 2016, 5:31 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44795/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 5:31 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-15405
> https://issues.apache.org/jira/browse/AMBARI-15405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> # Installing bits for new registered version fails on suse11 if it is having any other additional repo
> # This is because of a parsing error and out of index error in ambari-agent's zypper.py file
> {code}
> 2016-03-10 15:12:19,018 - Package['ranger_2_3_4_0_3485*-admin'] {'use_repos': ['base', 'HDP-2.3.4.0-3485', 'HDP-UTILS-2.3.4.0-3485'], 'skip_repos': []}
> 2016-03-10 15:12:19,194 - Package Manager failed to install packages. Error: list index out of range
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 376, in install_packages
> skip_repos=[self.REPO_FILE_NAME_PREFIX + "*"] if OSCheck.is_redhat_family() else [])
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py", line 49, in action_install
> self.install_package(package_name, self.resource.use_repos, self.resource.skip_repos)
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 45, in install_package
> active_base_repos = self.get_active_base_repos()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 78, in get_active_base_repos
> if line_list[3].strip() == 'Yes' and line_list[2].strip().startswith("SUSE-"):
> IndexError: list index out of range
> 2016-03-10 15:12:19,918 - Installation of packages failed. Checking if installation was partially complete
> {code}
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py a519ce0
>
> Diff: https://reviews.apache.org/r/44795/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 44795: HDP 2.3.4 package install through Ambari on
SLES11 hosts fails
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44795/#review123684
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On March 15, 2016, 4:17 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44795/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 4:17 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-15405
> https://issues.apache.org/jira/browse/AMBARI-15405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> # Installing bits for new registered version fails on suse11 if it is having any other additional repo
> # This is because of a parsing error and out of index error in ambari-agent's zypper.py file
> {code}
> 2016-03-10 15:12:19,018 - Package['ranger_2_3_4_0_3485*-admin'] {'use_repos': ['base', 'HDP-2.3.4.0-3485', 'HDP-UTILS-2.3.4.0-3485'], 'skip_repos': []}
> 2016-03-10 15:12:19,194 - Package Manager failed to install packages. Error: list index out of range
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 376, in install_packages
> skip_repos=[self.REPO_FILE_NAME_PREFIX + "*"] if OSCheck.is_redhat_family() else [])
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py", line 49, in action_install
> self.install_package(package_name, self.resource.use_repos, self.resource.skip_repos)
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 45, in install_package
> active_base_repos = self.get_active_base_repos()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 78, in get_active_base_repos
> if line_list[3].strip() == 'Yes' and line_list[2].strip().startswith("SUSE-"):
> IndexError: list index out of range
> 2016-03-10 15:12:19,918 - Installation of packages failed. Checking if installation was partially complete
> {code}
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py a519ce0
>
> Diff: https://reviews.apache.org/r/44795/diff/
>
>
> Testing
> -------
>
> mvn clean test,
> test on live system
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 44795: HDP 2.3.4 package install through Ambari on
SLES11 hosts fails
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44795/
-----------------------------------------------------------
(Updated March 15, 2016, 6:17 p.m.)
Review request for Ambari and Andrew Onischuk.
Changes
-------
Fixed patch
Bugs: AMBARI-15405
https://issues.apache.org/jira/browse/AMBARI-15405
Repository: ambari
Description
-------
# Installing bits for new registered version fails on suse11 if it is having any other additional repo
# This is because of a parsing error and out of index error in ambari-agent's zypper.py file
{code}
2016-03-10 15:12:19,018 - Package['ranger_2_3_4_0_3485*-admin'] {'use_repos': ['base', 'HDP-2.3.4.0-3485', 'HDP-UTILS-2.3.4.0-3485'], 'skip_repos': []}
2016-03-10 15:12:19,194 - Package Manager failed to install packages. Error: list index out of range
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 376, in install_packages
skip_repos=[self.REPO_FILE_NAME_PREFIX + "*"] if OSCheck.is_redhat_family() else [])
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
self.env.run()
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
self.run_action(resource, action)
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
provider_action()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py", line 49, in action_install
self.install_package(package_name, self.resource.use_repos, self.resource.skip_repos)
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 45, in install_package
active_base_repos = self.get_active_base_repos()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 78, in get_active_base_repos
if line_list[3].strip() == 'Yes' and line_list[2].strip().startswith("SUSE-"):
IndexError: list index out of range
2016-03-10 15:12:19,918 - Installation of packages failed. Checking if installation was partially complete
{code}
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py a519ce0
Diff: https://reviews.apache.org/r/44795/diff/
Testing
-------
mvn clean test,
test on live system
Thanks,
Dmitro Lisnichenko
Re: Review Request 44795: HDP 2.3.4 package install through Ambari on
SLES11 hosts fails
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44795/
-----------------------------------------------------------
(Updated March 15, 2016, 6:17 p.m.)
Review request for Ambari and Andrew Onischuk.
Changes
-------
fixed patch
Bugs: AMBARI-15405
https://issues.apache.org/jira/browse/AMBARI-15405
Repository: ambari
Description
-------
# Installing bits for new registered version fails on suse11 if it is having any other additional repo
# This is because of a parsing error and out of index error in ambari-agent's zypper.py file
{code}
2016-03-10 15:12:19,018 - Package['ranger_2_3_4_0_3485*-admin'] {'use_repos': ['base', 'HDP-2.3.4.0-3485', 'HDP-UTILS-2.3.4.0-3485'], 'skip_repos': []}
2016-03-10 15:12:19,194 - Package Manager failed to install packages. Error: list index out of range
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 376, in install_packages
skip_repos=[self.REPO_FILE_NAME_PREFIX + "*"] if OSCheck.is_redhat_family() else [])
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
self.env.run()
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
self.run_action(resource, action)
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
provider_action()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py", line 49, in action_install
self.install_package(package_name, self.resource.use_repos, self.resource.skip_repos)
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 45, in install_package
active_base_repos = self.get_active_base_repos()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 78, in get_active_base_repos
if line_list[3].strip() == 'Yes' and line_list[2].strip().startswith("SUSE-"):
IndexError: list index out of range
2016-03-10 15:12:19,918 - Installation of packages failed. Checking if installation was partially complete
{code}
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py a519ce0
Diff: https://reviews.apache.org/r/44795/diff/
Testing
-------
mvn clean test,
test on live system
Thanks,
Dmitro Lisnichenko
Re: Review Request 44795: HDP 2.3.4 package install through Ambari on
SLES11 hosts fails
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44795/
-----------------------------------------------------------
(Updated March 15, 2016, 6:06 p.m.)
Review request for Ambari and Andrew Onischuk.
Changes
-------
fixed comment
Bugs: AMBARI-15405
https://issues.apache.org/jira/browse/AMBARI-15405
Repository: ambari
Description
-------
# Installing bits for new registered version fails on suse11 if it is having any other additional repo
# This is because of a parsing error and out of index error in ambari-agent's zypper.py file
{code}
2016-03-10 15:12:19,018 - Package['ranger_2_3_4_0_3485*-admin'] {'use_repos': ['base', 'HDP-2.3.4.0-3485', 'HDP-UTILS-2.3.4.0-3485'], 'skip_repos': []}
2016-03-10 15:12:19,194 - Package Manager failed to install packages. Error: list index out of range
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 376, in install_packages
skip_repos=[self.REPO_FILE_NAME_PREFIX + "*"] if OSCheck.is_redhat_family() else [])
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
self.env.run()
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
self.run_action(resource, action)
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
provider_action()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/__init__.py", line 49, in action_install
self.install_package(package_name, self.resource.use_repos, self.resource.skip_repos)
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 45, in install_package
active_base_repos = self.get_active_base_repos()
File "/usr/lib/python2.6/site-packages/resource_management/core/providers/package/zypper.py", line 78, in get_active_base_repos
if line_list[3].strip() == 'Yes' and line_list[2].strip().startswith("SUSE-"):
IndexError: list index out of range
2016-03-10 15:12:19,918 - Installation of packages failed. Checking if installation was partially complete
{code}
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py a519ce0
Diff: https://reviews.apache.org/r/44795/diff/
Testing (updated)
-------
mvn clean test,
test on live system
Thanks,
Dmitro Lisnichenko