You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/10/14 00:40:59 UTC
[GitHub] [fineract] IOhacker opened a new pull request #1891: Updated Java to Azul Zulu jdk17
IOhacker opened a new pull request #1891:
URL: https://github.com/apache/fineract/pull/1891
## Description
Dockerfile was Updated Java to Azul Zulu jdk17
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [X] Create/update unit or integration tests for verifying the changes made.
- [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-945406006
Great effort here;
The one problem I see here is that the project itself might not be quite java_17 ready or maybe it is cause I've not personally tested yet but I recall not so long ago, it took quite some struggle to migrate the project to java_11(https://github.com/apache/fineract/pull/820). I'm not sure what causes your build to fail but maybe the work done here: https://github.com/apache/fineract/pull/820 on Java_11 migration can help you resolve it.
And I think we should probably discuss more migrating to Java 17 now. For example; Gradle does not cover Java 17 yet (https://docs.gradle.org/current/userguide/compatibility.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-945176389
Yes, I will do a testing on a local Jenkins, trying to emulate as muchs as posible the testing environment, because the Travis CI is not free anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-948016299
Yes, thank you, I will include that tag for making sure it is
display properly.
Thank you.
El mié, 20 oct 2021 a las 15:30, Awasum Yannick ***@***.***>)
escribió:
> @IOhacker <https://github.com/IOhacker> Good work picking this up and
> making some progress. Another minor feedback, please read:
> https://github.com/apache/fineract#pull-requests on how we send PRs and
> write commit messages to always include the FINERACT-ISSUE, that way, the
> PRs will show up in the JIRA ticket and will ease product management and QA
> efforts. Do you understand what I am trying to say?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1891#issuecomment-948013234>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAQMPBDGVRCTEYGM6MDUH4RGRANCNFSM5F6NVQBQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan edited a comment on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
BLasan edited a comment on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-943301116
@IOhacker Please squash the commits. Also build is failing
```
Test verifyConcurrentLoanRepayments() FAILED
java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was <500>.
at org.apache.fineract.integrationtests.ConcurrencyIntegrationTest.verifyConcurrentLoanRepayments(ConcurrencyIntegrationTest.java:75)
```
BTW, what's the exact use of updating to jdk 17 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-946956681
@IOhacker Could you please squash the commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-974550540
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-974558906
Yes, Gradle 7.3 has been released.
El vie, 19 nov 2021 a las 18:07, github-actions[bot] (<
***@***.***>) escribió:
> This pull request seems to be stale. Are you still planning to work on it?
> We will automatically close it in 30 days.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1891#issuecomment-974550540>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAWGW6E3MWK5JRWOSPDUM3RFTANCNFSM5F6NVQBQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-943352324
Hello BLasan,
The usage is for extending the EOL which is reported here to be until 2026
https://www.oracle.com/java/technologies/java-se-support-roadmap.html
On the other hand I had to test which were the errors were causing the compiling failure which includes now fixes:
- The version of JaCoco is now 0.8.7 (now it supports JDK 17)
- Including the JDK API now secured (it is a workaround for passing the JDK_JAVA_OPTS parameters)
- The Travis CI script now should be upgraded to support the JDK 17.
I notice the validation test which were failing, which is a matter of review.
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-943301116
@IOhacker Please squash the commits. Also build is failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-948013234
@IOhacker Good work picking this up and making some progress. Another minor feedback, please read: https://github.com/apache/fineract#pull-requests on how we send PRs and write commit messages to always include the FINERACT-ISSUE, that way, the PRs will show up in the JIRA ticket and will ease product management and QA efforts. Do you understand what I am trying to say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker closed pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
IOhacker closed pull request #1891:
URL: https://github.com/apache/fineract/pull/1891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan edited a comment on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
BLasan edited a comment on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-943301116
@IOhacker Please squash the commits. Also build is failing
```
Test verifyConcurrentLoanRepayments() FAILED
java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was <500>.
at org.apache.fineract.integrationtests.ConcurrencyIntegrationTest.verifyConcurrentLoanRepayments(ConcurrencyIntegrationTest.java:75)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fintecheando commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
fintecheando commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-946854197
@xurror it is compiling, It is at testing time when the error occurs, it is running (booting the fineract, without any issue but all the tests must be passed).
Test verifyConcurrentLoanRepayments() FAILED
java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was <500>.
at org.apache.fineract.integrationtests.ConcurrencyIntegrationTest.verifyConcurrentLoanRepayments(ConcurrencyIntegrationTest.java:75)
I will continue the research as soon as the tools add support to JDK 17 i.e. Gradle has a RC for JDK 17 support
https://docs.gradle.org/7.3-rc-1/release-notes.html
Also I will take a look at the tickets with Springboot updates.
Regards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-948017396
I agree, I have read in the gradle site that it will be available during
this month. So I will wait for this Gradle GA. Also I am checking the code
that is failing to make sure it can pass the test.
Regards
El mié, 20 oct 2021 a las 15:34, Awasum Yannick ***@***.***>)
escribió:
> @xurror <https://github.com/xurror> it is compiling, It is at testing
> time when the error occurs, it is running (booting the fineract, without
> any issue but all the tests must be passed).
>
> Test verifyConcurrentLoanRepayments() FAILED java.lang.AssertionError: 1
> expectation failed. Expected status code <200> but was <500>. at
> org.apache.fineract.integrationtests.ConcurrencyIntegrationTest.verifyConcurrentLoanRepayments(ConcurrencyIntegrationTest.java:75)
>
> I will continue the research as soon as the tools add support to JDK 17
> i.e. Gradle has a RC for JDK 17 support
>
> https://docs.gradle.org/7.3-rc-1/release-notes.html
>
> Also I will take a look at the tickets with Springboot updates.
>
> Regards
>
> For an open source project like ours with few volunteers, lets try to use
> only GA (Generally Available) releases which are stable and easy to
> maintain. So lets keep doing the other things required to get this codebase
> to Java 17 but wait for Gradle 7.3 if that is what supports JDK 17. Do you
> agree with the above opinion?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1891#issuecomment-948015980>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZASV4QU25NSACTHMOJ3UH4RV7ANCNFSM5F6NVQBQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-948015980
> @xurror it is compiling, It is at testing time when the error occurs, it is running (booting the fineract, without any issue but all the tests must be passed).
>
> Test verifyConcurrentLoanRepayments() FAILED java.lang.AssertionError: 1 expectation failed. Expected status code <200> but was <500>. at org.apache.fineract.integrationtests.ConcurrencyIntegrationTest.verifyConcurrentLoanRepayments(ConcurrencyIntegrationTest.java:75)
>
> I will continue the research as soon as the tools add support to JDK 17 i.e. Gradle has a RC for JDK 17 support
>
> https://docs.gradle.org/7.3-rc-1/release-notes.html
>
> Also I will take a look at the tickets with Springboot updates.
>
> Regards
For an open source project like ours with few volunteers, lets try to use only GA (Generally Available) releases which are stable and easy to maintain. So lets keep doing the other things required to get this codebase to Java 17 but wait for Gradle 7.3 if that is what supports JDK 17. Do you agree with the above opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-944672590
> Hello BLasan,
>
> The usage is for extending the EOL which is reported here to be until 2026
>
> https://www.oracle.com/java/technologies/java-se-support-roadmap.html
>
> On the other hand I had to test which were the errors were causing the compiling failure which includes now fixes:
>
> * The version of JaCoco is now 0.8.7 (now it supports JDK 17)
> * Including the JDK API now secured (it is a workaround for passing the JDK_JAVA_OPTS parameters)
> * The Travis CI script now should be upgraded to support the JDK 17.
>
> I notice the validation test which were failing, which is a matter of review.
>
> Thank you
Changes look ok to me. Btw, could you please run the integration tests locally and check the report generated? Or else try reopening the PR with squashed commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1891: Updated Java to Azul Zulu jdk17
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-979280078
I will close this PR, because I have tested the latest update of Spring 2.6.0 and there are less issues. I will submit another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org