You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/29 09:09:27 UTC

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1374: PHY and FEM TX/RX gain imporovements

apache-mynewt-bot commented on PR #1374:
URL: https://github.com/apache/mynewt-nimble/pull/1374#issuecomment-1261993994

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/controller/src/ble_ll_dtm.c
   <details>
   
   ```diff
   @@ -34,16 +34,16 @@
    #include "ble_ll_priv.h"
    
    STATS_SECT_START(ble_ll_dtm_stats)
   -    STATS_SECT_ENTRY(rx_count)
   -    STATS_SECT_ENTRY(tx_failed)
   -    STATS_SECT_ENTRY(rx_failed)
   +STATS_SECT_ENTRY(rx_count)
   +STATS_SECT_ENTRY(tx_failed)
   +STATS_SECT_ENTRY(rx_failed)
    STATS_SECT_END
    STATS_SECT_DECL(ble_ll_dtm_stats) ble_ll_dtm_stats;
    
    STATS_NAME_START(ble_ll_dtm_stats)
   -    STATS_NAME(ble_ll_dtm_stats, rx_count)
   -    STATS_NAME(ble_ll_dtm_stats, tx_failed)
   -    STATS_NAME(ble_ll_dtm_stats, rx_failed)
   +STATS_NAME(ble_ll_dtm_stats, rx_count)
   +STATS_NAME(ble_ll_dtm_stats, tx_failed)
   +STATS_NAME(ble_ll_dtm_stats, rx_failed)
    STATS_NAME_END(ble_phy_stats)
    
    struct dtm_ctx {
   ```
   
   </details>
   
   #### nimble/controller/src/ble_ll_scan.c
   <details>
   
   ```diff
   @@ -720,8 +719,8 @@
                                                       hdr->rxinfo.rssi - ble_ll_rx_gain(),
                                                       adv_data_len, om,
                                                       inita, inita_type);
   -goto done;
   -}
   +        goto done;
   +    }
    #endif
    
        if (subev == BLE_HCI_LE_SUBEV_DIRECT_ADV_RPT) {
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org