You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2026/07/16 11:34:23 UTC

[PR] test: fix smoke test failures on xen/vmware [cloudstack]

weizhouapache opened a new pull request, #13628:
URL: https://github.com/apache/cloudstack/pull/13628

   ### Description
   
   This PR fixes some smoke test failures on vmware or xenserver/xcpng
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ******************************************************************************* -->
   <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ******************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   
   #### How did you try to break this feature and the system with this change?
   
   <!-- see how your change affects other areas of the code, etc. -->
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5127974385

   <b>[SF] Trillian test result (tid-16649)</b>
   Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
   Total time taken: 78485 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16649-xcpng82.zip
   Smoke tests completed. 154 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.06 | test_ssvm.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.59 | test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.59 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5460985801

   <b>[SF] Trillian test result (tid-16840)</b>
   Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
   Total time taken: 75729 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16840-xcpng82.zip
   Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5379618066

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5399617424

   <b>[SF] Trillian test result (tid-16807)</b>
   Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 123155 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16807-vmware-70u3.zip
   Smoke tests completed. 152 look OK, 4 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_more_vms_than_limit_allows | `Error` | 124.21 | test_deploy_vms_in_parallel.py
   test_05_list_volumes_isrecursive | `Failure` | 0.05 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.04 | test_list_volumes.py
   test_01_deploy_vm_on_specific_host | `Error` | 3602.45 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 1.51 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 19.98 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 3604.36 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.39 | test_vm_deployment_planner.py
   test_01_migrate_vm_strict_tags_success | `Error` | 3603.47 | test_vm_strict_host_tags.py
   test_02_migrate_vm_strict_tags_failure | `Error` | 29.84 | test_vm_strict_host_tags.py
   ContextSuite context=TestMigrateVMStrictTags>:teardown | `Error` | 32.38 | test_vm_strict_host_tags.py
   test_01_restore_vm_strict_tags_success | `Error` | 3602.75 | test_vm_strict_host_tags.py
   test_02_restore_vm_strict_tags_failure | `Error` | 9.21 | test_vm_strict_host_tags.py
   ContextSuite context=TestRestoreVMStrictTags>:teardown | `Error` | 10.49 | test_vm_strict_host_tags.py
   test_01_scale_vm_strict_tags_success | `Error` | 25.48 | test_vm_strict_host_tags.py
   test_02_scale_vm_strict_tags_failure | `Error` | 7204.10 | test_vm_strict_host_tags.py
   test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 3604.01 | test_vm_strict_host_tags.py
   test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 5.92 | test_vm_strict_host_tags.py
   test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 5.89 | test_vm_strict_host_tags.py
   test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 3609.63 | test_vm_strict_host_tags.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5003431801

   @blueorangutan test ubuntu26 vmware-80u3e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5915244276

   
   @blueorangutan test ubuntu26 vmware-70u3
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5912740065

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-4991415180

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13628?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 3.41%. Comparing base ([`75748a5`](https://app.codecov.io/gh/apache/cloudstack/commit/75748a5cb8524d8453d2544d1c5ffe065f1e4d0b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09fca9b`](https://app.codecov.io/gh/apache/cloudstack/commit/09fca9bc8327b58bad2edab21cc4fe2d12f42293?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (75748a5) and HEAD (09fca9b). Click for more details.
   > 
   > <details><summary>HEAD has 1 upload less than BASE</summary>
   >
   >| Flag | BASE (75748a5) | HEAD (09fca9b) |
   >|------|------|------|
   >|unittests|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##               main   #13628       +/-   ##
   =============================================
   - Coverage     19.65%    3.41%   -16.24%     
   =============================================
     Files          6368      487     -5881     
     Lines        575107    41860   -533247     
     Branches      70370     7910    -62460     
   =============================================
   - Hits         113016     1429   -111587     
   + Misses       449808    40232   -409576     
   + Partials      12283      199    -12084     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13628/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13628/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.41% <ø> (ø)` | |
   | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13628/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/13628?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-4991875737

   @blueorangutan test ubuntu26 xcpng82 keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5176628254

   <b>[SF] Trillian Build Failed (tid-20)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#discussion_r3666656568


##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java:
##########
@@ -556,7 +556,15 @@ private boolean canBypassSecondaryStorage(DataObject srcData, DataObject destDat
                 return true;
             }
 
+            if (Hypervisor.HypervisorType.XenServer.equals(((VolumeInfo) srcData).getHypervisorType())) {
+                return false;
+            }

Review Comment:
   already checked by line 554



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5416091089

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#discussion_r3879133693


##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java:
##########
@@ -556,7 +556,15 @@ private boolean canBypassSecondaryStorage(DataObject srcData, DataObject destDat
                 return true;
             }
 
+            if (Hypervisor.HypervisorType.XenServer.equals(((VolumeInfo) srcData).getHypervisorType())) {
+                return false;
+            }
+
             if (destData instanceof VolumeInfo) {
+                if (Hypervisor.HypervisorType.XenServer.equals(((VolumeInfo) destData).getHypervisorType())) {
+                    return false;
+                }

Review Comment:
   The new XenServer short-circuit changes behavior of `canBypassSecondaryStorage` for volume-to-volume copies, but there is no unit test asserting that XenServer volumes cannot bypass secondary storage. Adding a focused test (e.g., src/dest VolumeInfo hypervisor type = XenServer with otherwise-eligible scopes/pool types => expect `false`) would prevent regressions.



##########
test/integration/smoke/test_deploy_vms_in_parallel.py:
##########
@@ -123,6 +125,40 @@ def update_resource_limit(self, max=1):
         )
 
     def tearDown(self):
+        # Deleting the account only soft-deletes it; the account row (and
+        # its "needs cleanup" state) is purged asynchronously by the
+        # account.cleanup.interval background task. Deleting the domain
+        # right after the account can therefore race with that task and
+        # fail with "Can't delete the domain yet because it has N
+        # accounts to cleanup". Delete the account first, then retry the
+        # domain deletion for a bit to ride out that race.
+        try:
+            self.cleanup_resources(self.apiclient, [self.account])
+        except Exception as e:
+            self.debug("Warning: Exception during account cleanup : %s" % e)
+
+        retries_left = 15
+        while True:
+            try:
+                self.domain.delete(self.apiclient)
+                break
+            except Exception as e:
+                retries_left -= 1
+                if "accounts to cleanup" not in str(e):
+                    raise Exception("Warning: Exception during cleanup : %s" % e)

Review Comment:
   Reraising a new generic `Exception` here drops the original exception type/stack trace, which makes this cleanup failure much harder to debug (and can hide the real root cause in CI). Use exception chaining (`from e`) to preserve the underlying error context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5459909129

   <b>[SF] Trillian test result (tid-16838)</b>
   Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
   Total time taken: 60561 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16838-kvm-ubuntu22.zip
   Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5819638212

   <b>[SF] Trillian Build Failed (tid-50)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5912777973

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5008427420

   <b>[SF] Trillian Build Failed (tid-9)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#discussion_r3658235988


##########
test/integration/smoke/test_vm_life_cycle.py:
##########
@@ -858,6 +858,7 @@ def test_11_destroy_vm_and_volumes(self):
             zoneid=self.zone.id
         )
 
+        time.sleep(10)

Review Comment:
   A fixed sleep makes this test slower and still potentially flaky because Volume.create() returns immediately and the volume may not be in state 'Ready' after 10s on slower backends/hypervisors. Prefer polling the volume state until it becomes Ready (with a timeout) before attaching.



##########
test/integration/smoke/test_usage.py:
##########
@@ -782,6 +783,7 @@ def test_01_volume_usage(self):
         )
         rool_volume_pool = rool_volume_pool_response[0]
         try:
+            time.sleep(10)
             self.virtual_machine.attach_volume(self.apiclient,volume_uploaded)

Review Comment:
   Sleeping a fixed 10s before attach makes the test slower and doesn't guarantee the VM/host is ready for a hot-plug attach on slower hypervisors. A bounded retry loop around attach_volume() (with short sleeps) is both faster when things are ready quickly and more reliable when readiness takes longer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5177173952

   <b>[SF] Trillian test result (tid-17)</b>
   Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server u26
   Total time taken: 67811 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-n17-xcpng82.zip
   Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2090.29 | test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2090.38 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5416624098

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18987


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5139360182

   <b>[SF] Trillian test result (tid-16651)</b>
   Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 134966 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16651-vmware-80u3.zip
   Smoke tests completed. 152 look OK, 4 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_list_volumes_isrecursive | `Failure` | 0.03 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.03 | test_list_volumes.py
   test_01_deploy_vm_on_specific_host | `Error` | 3602.44 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 1.31 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 4.36 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.44 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.26 | test_vm_deployment_planner.py
   test_03_live_migrate_VM_with_two_data_disks | `Error` | 40.11 | test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 27.11 | test_vm_life_cycle.py
   test_09_expunge_vm | `Failure` | 432.04 | test_vm_life_cycle.py
   test_01_migrate_vm_strict_tags_success | `Error` | 3603.92 | test_vm_strict_host_tags.py
   test_02_migrate_vm_strict_tags_failure | `Error` | 9.00 | test_vm_strict_host_tags.py
   ContextSuite context=TestMigrateVMStrictTags>:teardown | `Error` | 10.28 | test_vm_strict_host_tags.py
   test_01_restore_vm_strict_tags_success | `Error` | 25.13 | test_vm_strict_host_tags.py
   test_02_restore_vm_strict_tags_failure | `Error` | 3608.35 | test_vm_strict_host_tags.py
   test_01_scale_vm_strict_tags_success | `Error` | 24.31 | test_vm_strict_host_tags.py
   test_02_scale_vm_strict_tags_failure | `Error` | 3602.36 | test_vm_strict_host_tags.py
   ContextSuite context=TestScaleVMStrictTags>:teardown | `Error` | 3604.89 | test_vm_strict_host_tags.py
   test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 25.40 | test_vm_strict_host_tags.py
   test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 3609.18 | test_vm_strict_host_tags.py
   test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 23.61 | test_vm_strict_host_tags.py
   test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 3610.25 | test_vm_strict_host_tags.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5379873473

   @weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5716266097

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5913743859

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5105945841

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18697


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5105327154

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5379620860

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5384106069

   <b>[SF] Trillian test result (tid-16803)</b>
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 56956 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16803-kvm-ol8.zip
   Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_ssl_offloading_isolated_network | `Failure` | 724.59 | test_ssl_offloading.py
   test_02_ssl_offloading_project_vpc | `Failure` | 686.26 | test_ssl_offloading.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5012742136

   <b>[SF] Trillian Build Failed (tid-10)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5912373739

   @weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-70u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5118991164

   <b>[SF] Trillian test result (tid-16642)</b>
   Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 77858 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16642-vmware-80u3.zip
   Smoke tests completed. 154 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_list_volumes_isrecursive | `Failure` | 0.04 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.03 | test_list_volumes.py
   test_list_vms_metrics_admin | `Error` | 3620.69 | test_metrics_api.py
   test_list_vms_metrics_history | `Error` | 4.95 | test_metrics_api.py
   test_list_volumes_metrics_history | `Error` | 3623.56 | test_metrics_api.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6339876272

   @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6364309107

   @nvazquez @RosiKyu 
   there are some intermittent failures on vmware and xcpng. most of the test failures are gone.
   do you think we can merge this PR to 24.0 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5003440979

   @weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3e) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5004906487

   @weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-4991901271

   @weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3e) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5168431680

   <b>[SF] Trillian Build Failed (tid-19)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5420825824

   <b>[SF] Trillian test result (tid-16820)</b>
   Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 66723 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16820-vmware-80u3.zip
   Smoke tests completed. 142 look OK, 3 have errors, 11 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_more_vms_than_limit_allows | `Error` | 178.69 | test_deploy_vms_in_parallel.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 828.38 | test_kubernetes_clusters.py
   test_05_list_volumes_isrecursive | `Failure` | 0.05 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.05 | test_list_volumes.py
   all_test_volumes | `Skipped` | --- | test_volumes.py
   all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
   all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
   all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
   all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
   all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
   all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
   all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
   all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
   all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
   all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5466530935

   <b>[SF] Trillian test result (tid-16844)</b>
   Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 68496 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16844-vmware-80u3.zip
   Smoke tests completed. 154 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_list_volumes_isrecursive | `Failure` | 0.07 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.04 | test_list_volumes.py
   test_01_volume_usage | `Failure` | 108.99 | test_usage.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5460570858

   <b>[SF] Trillian test result (tid-16839)</b>
   Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 68381 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16839-vmware-70u3.zip
   Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deployVMInSharedNetwork | `Error` | 392.19 | test_network.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5717049894

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19272


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5931735853

   <b>[SF] Trillian test result (tid-56)</b>
   Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server u26
   Total time taken: 69822 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-n56-vmware-70u3.zip
   Smoke tests completed. 153 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_13_test_add_external_nodes_to_cluster | `Error` | 831.30 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 920.38 | test_kubernetes_clusters.py
   test_05_list_volumes_isrecursive | `Failure` | 0.06 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.06 | test_list_volumes.py
   test_08_migrate_vm | `Error` | 29.32 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5003415825

   @blueorangutan test ubuntu26 xcpng82


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5105321742

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5114433378

   @blueorangutan test ubuntu26 xcpng82


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5114447935

   @DaanHoogland a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + xcpng82) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#discussion_r3595139681


##########
test/integration/smoke/test_nonstrict_affinity_group.py:
##########
@@ -209,6 +209,9 @@ def test_01_non_strict_host_anti_affinity(self):
                             vm_2_host_id,
                             msg="Both VMs of affinity group %s are on the same host" % self.affinity_group.name)
 
+
+        time.sleep(10)
+

Review Comment:
   wait 10 seconds for the vm to boot into OS. it is already Running



##########
test/integration/smoke/test_nonstrict_affinity_group.py:
##########
@@ -362,6 +365,8 @@ def test_02_non_strict_host_affinity(self):
                          vm_12_host_id,
                          msg="Both VMs of affinity group %s are on the different host" % self.affinity_group.name)
 
+        time.sleep(10)
+

Review Comment:
   wait 10 seconds for the vm to boot into OS. it is already Running



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-4991880373

   @weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + xcpng82) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5450733928

   @weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5384641872

   <b>[SF] Trillian test result (tid-16805)</b>
   Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 66816 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16805-vmware-70u3.zip
   Smoke tests completed. 140 look OK, 16 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeleteDomain | `Error` | 48.02 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 43.61 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 128.78 | test_accounts.py
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 107.95 | test_affinity_groups_projects.py
   test_DeployVmAffinityGroup | `Error` | 150.33 | test_affinity_groups.py
   test_DeployVmAntiAffinityGroup | `Error` | 45.03 | test_affinity_groups.py
   ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py
   test_01_vm_with_thin_disk_offering | `Error` | 152.58 | test_disk_provisioning_types.py
   test_02_vm_with_fat_disk_offering | `Error` | 120.70 | test_disk_provisioning_types.py
   test_03_vm_with_sparse_disk_offering | `Error` | 209.11 | test_disk_provisioning_types.py
   test_03_create_vpc_domain_vpc_offering | `Error` | 381.79 | test_domain_vpc_offerings.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 46.60 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 240.29 | test_kubernetes_clusters.py
   test_12_test_deploy_cluster_different_offerings_per_node_type | `Failure` | 132.54 | test_kubernetes_clusters.py
   test_13_test_add_external_nodes_to_cluster | `Failure` | 131.48 | test_kubernetes_clusters.py
   test_05_list_volumes_isrecursive | `Failure` | 0.07 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.07 | test_list_volumes.py
   test_01_non_strict_host_anti_affinity | `Failure` | 120.76 | test_nonstrict_affinity_group.py
   test_02_non_strict_host_affinity | `Error` | 51.69 | test_nonstrict_affinity_group.py
   test_01_isolated_persistent_network | `Failure` | 105.87 | test_persistent_network.py
   test_02_L2_persistent_network | `Failure` | 2.22 | test_persistent_network.py
   test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Failure` | 68.76 | test_persistent_network.py
   test_01_add_primary_storage_disabled_host | `Error` | 37.86 | test_primary_storage.py
   test_01_primary_storage_scope_change | `Error` | 0.12 | test_primary_storage_scope.py
   test_01_sys_vm_start | `Failure` | 0.12 | test_secondary_storage.py
   test_03_live_migrate_VM_with_two_data_disks | `Error` | 39.69 | test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 0.08 | test_vm_life_cycle.py
   test_01_deploy_vm_on_specific_host | `Error` | 0.11 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 0.18 | test_vm_deployment_planner.py
   test_01_migrate_vm_strict_tags_success | `Error` | 0.35 | test_vm_strict_host_tags.py
   test_02_migrate_vm_strict_tags_failure | `Error` | 0.32 | test_vm_strict_host_tags.py
   test_01_restore_vm_strict_tags_success | `Error` | 0.29 | test_vm_strict_host_tags.py
   test_02_restore_vm_strict_tags_failure | `Error` | 0.29 | test_vm_strict_host_tags.py
   test_01_scale_vm_strict_tags_success | `Error` | 0.36 | test_vm_strict_host_tags.py
   test_02_scale_vm_strict_tags_failure | `Error` | 0.38 | test_vm_strict_host_tags.py
   test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 0.33 | test_vm_strict_host_tags.py
   test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 2.92 | test_vm_strict_host_tags.py
   test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 0.33 | test_vm_strict_host_tags.py
   test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 5.96 | test_vm_strict_host_tags.py
   test_05_deploy_vm_on_specific_host_with_strict_tags_failure | `Failure` | 0.30 | test_vm_strict_host_tags.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5831296430

   <b>[SF] Trillian test result (tid-46)</b>
   Environment: xcpng83 (x2), zone: Advanced Networking with Mgmt server u26
   Total time taken: 76081 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-n46-xcpng83.zip
   Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_1_userdata_on_ssvm | `Error` | 8.62 | test_systemvm_userdata.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5718883019

   <b>[SF] Trillian Build Failed (tid-17017)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5729336869

   <b>[SF] Trillian test result (tid-17015)</b>
   Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
   Total time taken: 63458 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t17015-kvm-ubuntu22.zip
   Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6337016531

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6338965076

   @blueorangutan test ol8 vmware-70u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5167687907

   <b>[SF] Trillian Build Failed (tid-18)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#discussion_r3666435853


##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java:
##########
@@ -556,7 +556,15 @@ private boolean canBypassSecondaryStorage(DataObject srcData, DataObject destDat
                 return true;
             }
 
+            if (Hypervisor.HypervisorType.XenServer.equals(((VolumeInfo) srcData).getHypervisorType())) {
+                return false;
+            }

Review Comment:
   This casts `srcData` to `VolumeInfo` without an `instanceof` guard. If `srcData` is not a `VolumeInfo`, this will throw `ClassCastException` at runtime and break data motion for non-volume source objects. Fix by guarding the cast (e.g., `if (srcData instanceof VolumeInfo && XenServer.equals(((VolumeInfo) srcData).getHypervisorType())) { ... }`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5716299251

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5200684814

   <b>[SF] Trillian test result (tid-23)</b>
   Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server u26
   Total time taken: 150749 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-n23-vmware-80u3.zip
   Smoke tests completed. 150 look OK, 6 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_more_vms_than_limit_allows | `Error` | 192.00 | test_deploy_vms_in_parallel.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 747.89 | test_kubernetes_clusters.py
   test_13_test_add_external_nodes_to_cluster | `Failure` | 1078.03 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 1169.81 | test_kubernetes_clusters.py
   test_05_list_volumes_isrecursive | `Failure` | 0.08 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.06 | test_list_volumes.py
   test_01_deploy_vm_on_specific_host | `Error` | 17.25 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 3603.00 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 4.78 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 2.69 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 2.77 | test_vm_deployment_planner.py
   test_08_migrate_vm | `Error` | 31.83 | test_vm_life_cycle.py
   test_01_migrate_vm_strict_tags_success | `Error` | 3608.28 | test_vm_strict_host_tags.py
   test_02_migrate_vm_strict_tags_failure | `Error` | 3609.54 | test_vm_strict_host_tags.py
   test_01_restore_vm_strict_tags_success | `Error` | 3603.04 | test_vm_strict_host_tags.py
   test_02_restore_vm_strict_tags_failure | `Error` | 7.93 | test_vm_strict_host_tags.py
   ContextSuite context=TestRestoreVMStrictTags>:teardown | `Error` | 10.48 | test_vm_strict_host_tags.py
   test_01_scale_vm_strict_tags_success | `Error` | 20.64 | test_vm_strict_host_tags.py
   test_02_scale_vm_strict_tags_failure | `Error` | 7206.52 | test_vm_strict_host_tags.py
   test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 3602.53 | test_vm_strict_host_tags.py
   test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 7.67 | test_vm_strict_host_tags.py
   test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 8.01 | test_vm_strict_host_tags.py
   test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 7219.92 | test_vm_strict_host_tags.py
   ContextSuite context=TestVMDeploymentPlannerStrictTags>:teardown | `Error` | 8.12 | test_vm_strict_host_tags.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5205902258

   <b>[SF] Trillian test result (tid-25)</b>
   Environment: kvm-ol10 (x2), zone: Advanced Networking with Mgmt server ol10
   Total time taken: 62835 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-n25-kvm-ol10.zip
   Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_ssl_offloading_isolated_network | `Failure` | 718.18 | test_ssl_offloading.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5912323508

   @blueorangutan test ubuntu26 vmware-70u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5450722323

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#discussion_r3906129139


##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java:
##########
@@ -556,7 +556,15 @@ private boolean canBypassSecondaryStorage(DataObject srcData, DataObject destDat
                 return true;
             }
 
+            if (Hypervisor.HypervisorType.XenServer.equals(((VolumeInfo) srcData).getHypervisorType())) {

Review Comment:
   @sureshanaparti 
   this is related to #11625. could you please review ?
   
   another option would be 
   ```
               if (! Hypervisor.HypervisorType.KVM.equals(((VolumeInfo) srcData).getHypervisorType())) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5809956095

   <b>[SF] Trillian Build Failed (tid-43)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5104338045

   <b>[SF] Trillian test result (tid-16632)</b>
   Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
   Total time taken: 73150 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16632-xcpng82.zip
   Smoke tests completed. 151 look OK, 5 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py
   test_list_system_vms_metrics_history | `Failure` | 0.69 | test_metrics_api.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 13.87 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 13.87 | test_snapshots.py
   test_01_vpn_usage | `Error` | 1.12 | test_usage.py
   test_01_migrate_vm_strict_tags_success | `Error` | 51.68 | test_vm_strict_host_tags.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-4991776490

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-4991356246

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6369041583

   <b>[SF] Trillian test result (tid-17212)</b>
   Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 98653 seconds
   Marvin logs: not retained - PR was already closed when the run finished
   Smoke tests completed. 154 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_readiness_cache_invalidated_on_out_of_band_restart | `Error` | 171.29 | test_instance_boot_group.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 3736.13 | test_kubernetes_clusters.py
   test_change_service_offering_for_vm_with_snapshots | `Failure` | 1023.27 | test_vm_snapshots.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5115281490

   <b>[SF] Trillian Build Failed (tid-14)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-4991892465

   @blueorangutan test ubuntu26 vmware-80u3e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#discussion_r3602109778


##########
test/integration/smoke/test_kms_lifecycle.py:
##########
@@ -424,6 +425,10 @@ def test_12_deploy_vm_with_root_disk_encryption(self):
         Test: deploy a VM with its root disk encrypted using a KMS key.
         Verify that the VM starts and the root volume has the KMS key ID.
         """
+
+        if self.hypervisor.lower() != 'kvm':
+            raise self.skipTest("Skipping test case for non-kvm hypervisor")

Review Comment:
   Same here: `skipTest()` raises internally, so `raise self.skipTest(...)` is redundant (and differs from the other skip branches in this test class). Prefer calling `self.skipTest(...)` directly.



##########
test/integration/smoke/test_events_resource.py:
##########
@@ -147,6 +147,7 @@ def test_01_events_resource(self):
             diskofferingid=self.disk_offering.id
         )
         self.cleanup.append(volume)
+        time.sleep(10)

Review Comment:
   Hard-coding a fixed 10s sleep before attach makes this test slower and can still be flaky if volume allocation takes longer on some backends. Prefer polling the volume state until it is Allocated/Ready (or timing out) before attaching.



##########
test/integration/smoke/test_network_extension_namespace.py:
##########
@@ -859,6 +859,8 @@ def _check_kvm_host_prerequisites(self, tools=None):
         excluded from the check — the connectivity failure will surface
         naturally when the test later tries to deploy scripts.
         """
+        if self.hv.lower() != 'kvm':
+            raise self.skipTest("Skipping test case for non-kvm hypervisor")

Review Comment:
   `skipTest()` already raises `unittest.SkipTest`; using `raise self.skipTest(...)` is redundant and inconsistent with the rest of this file (which calls `self.skipTest(...)` directly). Drop the extra `raise` for clarity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5002828497

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5239426250

   > moving to 4.22.2 milestone as it fixes smoke tests, not functionalities
   
   does it still need rebasing on 4.22, @weizhouapache ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5450236452

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5190162098

   <b>[SF] Trillian test result (tid-16696)</b>
   Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server u24
   Total time taken: 88037 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16696-vmware-80u3.zip
   Smoke tests completed. 147 look OK, 9 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_arping_in_ssvm | `Failure` | 25.08 | test_diagnostics.py
   test_09_arping_in_cpvm | `Failure` | 9.55 | test_diagnostics.py
   test_deploy_more_vms_than_limit_allows | `Error` | 193.66 | test_deploy_vms_in_parallel.py
   test_13_test_add_external_nodes_to_cluster | `Failure` | 1102.87 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 1188.22 | test_kubernetes_clusters.py
   test_05_list_volumes_isrecursive | `Failure` | 0.07 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.06 | test_list_volumes.py
   test_list_vms_metrics_admin | `Error` | 3640.82 | test_metrics_api.py
   test_list_vms_metrics_history | `Error` | 6.66 | test_metrics_api.py
   test_list_volumes_metrics_history | `Error` | 3635.50 | test_metrics_api.py
   test_01_vpc_privategw_acl | `Failure` | 6.51 | test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 6.56 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 6.62 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 6.37 | test_privategw_acl.py
   test_01_restore_vm | `Error` | 4.63 | test_restore_vm.py
   test_02_restore_vm_with_disk_offering | `Error` | 7.67 | test_restore_vm.py
   test_03_restore_vm_with_disk_offering_custom_size | `Error` | 7.91 | test_restore_vm.py
   test_04_restore_vm_allocated_root | `Error` | 9.96 | test_restore_vm.py
   ContextSuite context=TestRestoreVM>:teardown | `Error` | 22.64 | test_restore_vm.py
   test_01_deploy_vm_on_specific_host | `Error` | 4.46 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 1.37 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 4.48 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 2.45 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.39 | test_vm_deployment_planner.py
   test_01_migrate_vm_strict_tags_success | `Error` | 9.18 | test_vm_strict_host_tags.py
   test_02_migrate_vm_strict_tags_failure | `Error` | 6.07 | test_vm_strict_host_tags.py
   test_01_restore_vm_strict_tags_success | `Error` | 6.18 | test_vm_strict_host_tags.py
   test_02_restore_vm_strict_tags_failure | `Error` | 6.26 | test_vm_strict_host_tags.py
   test_01_scale_vm_strict_tags_success | `Error` | 9.14 | test_vm_strict_host_tags.py
   test_02_scale_vm_strict_tags_failure | `Error` | 9.28 | test_vm_strict_host_tags.py
   test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 9.05 | test_vm_strict_host_tags.py
   test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 12.10 | test_vm_strict_host_tags.py
   test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 9.04 | test_vm_strict_host_tags.py
   test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 15.16 | test_vm_strict_host_tags.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5093244580

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18686


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5740027307

   <b>[SF] Trillian test result (tid-17016)</b>
   Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 131950 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t17016-vmware-70u3.zip
   Smoke tests completed. 153 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deploy_vm_on_specific_host | `Error` | 23.81 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 3606.01 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 24.85 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 3603.03 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 4.38 | test_vm_deployment_planner.py
   test_09_expunge_vm | `Failure` | 427.87 | test_vm_life_cycle.py
   test_01_migrate_vm_strict_tags_success | `Error` | 3608.56 | test_vm_strict_host_tags.py
   test_02_migrate_vm_strict_tags_failure | `Error` | 20.28 | test_vm_strict_host_tags.py
   test_01_restore_vm_strict_tags_success | `Error` | 3605.24 | test_vm_strict_host_tags.py
   test_02_restore_vm_strict_tags_failure | `Error` | 4.91 | test_vm_strict_host_tags.py
   test_01_scale_vm_strict_tags_success | `Error` | 20.09 | test_vm_strict_host_tags.py
   test_02_scale_vm_strict_tags_failure | `Error` | 3608.11 | test_vm_strict_host_tags.py
   test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 26.24 | test_vm_strict_host_tags.py
   test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 7207.20 | test_vm_strict_host_tags.py
   test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 3606.29 | test_vm_strict_host_tags.py
   test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 5.81 | test_vm_strict_host_tags.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5718234221

   @weizhouapache a [SL] Trillian-Jenkins matrix job (ol8 mgmt + kvm-ol8, ubuntu22 mgmt + kvm-ubuntu22, ol8 mgmt + vmware-70u3, ol9 mgmt + xcpng82) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5727567675

   <b>[SF] Trillian test result (tid-17014)</b>
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 52932 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t17014-kvm-ol8.zip
   Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5416074193

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6338834125

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6339844306

   
   @blueorangutan test ol8 xcpng82
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6367636798

   thanks @nvazquez @DaanHoogland 
   I am merging . If there are new failures, we could address in another PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6363988671

   <b>[SF] Trillian test result (tid-17210)</b>
   Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 85281 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t17210-vmware-70u3.zip
   Smoke tests completed. 155 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 3706.60 | test_kubernetes_clusters.py
   test_05_list_volumes_isrecursive | `Failure` | 0.06 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.05 | test_list_volumes.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5092642642

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5092668228

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5010923893

   <b>[SF] Trillian test result (tid-6)</b>
   Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server u26
   Total time taken: 75917 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-n6-xcpng82.zip
   Smoke tests completed. 152 look OK, 4 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_list_snapshots_with_removed_data_store | `Error` | 11.89 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 11.89 | test_snapshots.py
   test_01_volume_usage | `Failure` | 95.61 | test_usage.py
   test_01_vpn_usage | `Error` | 1.13 | test_usage.py
   test_11_destroy_vm_and_volumes | `Error` | 25.53 | test_vm_life_cycle.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2109.67 | test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2109.76 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5003424048

   @weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + xcpng82) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-4991343211

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5387256721

   <b>[SF] Trillian test result (tid-16804)</b>
   Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
   Total time taken: 104230 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16804-kvm-ubuntu22.zip
   Smoke tests completed. 140 look OK, 16 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py
   test_01_ssl_offloading_isolated_network | `Failure` | 722.71 | test_ssl_offloading.py
   test_02_ssl_offloading_project_vpc | `Failure` | 730.47 | test_ssl_offloading.py
   test_03_ssvm_internals | `Failure` | 3.57 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 88.72 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 146.92 | test_ssvm.py
   test_09_reboot_ssvm_forced | `Failure` | 171.55 | test_ssvm.py
   test_1_userdata_on_ssvm | `Failure` | 216.09 | test_systemvm_userdata.py
   test_2_userdata_on_cpvm | `Failure` | 209.98 | test_systemvm_userdata.py
   test_3_userdata_on_vr | `Failure` | 201.99 | test_systemvm_userdata.py
   test_01_create_template | `Error` | 23.01 | test_templates.py
   test_CreateTemplateWithDuplicateName | `Error` | 21.06 | test_templates.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.84 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.82 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.80 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.80 | test_templates.py
   test_03_delete_template | `Error` | 1.13 | test_templates.py
   test_04_extract_template | `Error` | 1.13 | test_templates.py
   test_09_list_templates_download_details | `Failure` | 0.13 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_snapshot_usage | `Error` | 26.06 | test_usage.py
   test_01_template_usage | `Error` | 24.14 | test_usage.py
   test_01_volume_usage | `Error` | 188.92 | test_usage.py
   test_10_attachAndDetach_iso | `Failure` | 1514.91 | test_vm_life_cycle.py
   ContextSuite context=TestMigrateVMStrictTags>:setup | `Error` | 0.00 | test_vm_strict_host_tags.py
   ContextSuite context=TestRestoreVMStrictTags>:setup | `Error` | 0.00 | test_vm_strict_host_tags.py
   ContextSuite context=TestScaleVMStrictTags>:setup | `Error` | 0.00 | test_vm_strict_host_tags.py
   ContextSuite context=TestVMDeploymentPlannerStrictTags>:setup | `Error` | 0.00 | test_vm_strict_host_tags.py
   test_04_deploy_vnf_appliance | `Error` | 317.25 | test_vnf_templates.py
   test_06_download_detached_volume | `Error` | 301.67 | test_volumes.py
   ContextSuite context=TestVPCConserveModeRules>:setup | `Error` | 0.00 | test_vpc_conserve_mode.py
   ContextSuite context=TestIpv6Vpc>:setup | `Error` | 0.00 | test_vpc_ipv6.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1518.69 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5461169277

   @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5815804408

   <b>[SF] Trillian Build Failed (tid-47)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5810077988

   <b>[SF] Trillian Build Failed (tid-42)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5912638670

   <b>[SF] Trillian Build Failed (tid-55)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5915422242

   @weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-70u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5973512408

   <b>[SF] Trillian test result (tid-57)</b>
   Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server u26
   Total time taken: 101910 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-n57-vmware-70u3.zip
   Smoke tests completed. 152 look OK, 3 have errors, 1 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 3689.65 | test_kubernetes_clusters.py
   test_13_test_add_external_nodes_to_cluster | `Error` | 834.28 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 910.87 | test_kubernetes_clusters.py
   test_01_deploy_vm_on_specific_host | `Error` | 3603.93 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 2.48 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 2.56 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.43 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 2.49 | test_vm_deployment_planner.py
   test_09_expunge_vm | `Failure` | 423.76 | test_vm_life_cycle.py
   all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5735863190

   <b>[SF] Trillian test result (tid-17018)</b>
   Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
   Total time taken: 92929 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t17018-xcpng82.zip
   Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_11_destroy_vm_and_volumes | `Error` | 34.16 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6339005324

   @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6365494379

   Thanks @weizhouapache, looks good to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5450250391

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5459745253

   <b>[SF] Trillian test result (tid-16837)</b>
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 57510 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16837-kvm-ol8.zip
   Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5461162945

   @blueorangutan test ol8 vmware-80u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5379783965

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18953


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5379869652

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5450697311

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19010


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5385624896

   <b>[SF] Trillian test result (tid-16806)</b>
   Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
   Total time taken: 82694 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-t16806-xcpng82.zip
   Smoke tests completed. 151 look OK, 5 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py
   ContextSuite context=TestCloudStackDNSFramework>:setup | `Error` | 0.00 | test_dns_framework_powerdns.py
   test_05_list_volumes_isrecursive | `Failure` | 0.04 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.04 | test_list_volumes.py
   test_change_service_offering_for_vm_with_snapshots | `Failure` | 1025.17 | test_vm_snapshots.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2147.70 | test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2147.81 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#discussion_r3595068951


##########
test/integration/smoke/test_nonstrict_affinity_group.py:
##########
@@ -209,6 +209,9 @@ def test_01_non_strict_host_anti_affinity(self):
                             vm_2_host_id,
                             msg="Both VMs of affinity group %s are on the same host" % self.affinity_group.name)
 
+
+        time.sleep(10)
+

Review Comment:
   Using a fixed sleep here makes the test slower and still flaky across hypervisors (the VM may not yet be fully Running/ready for migration after 10s, or may be ready much sooner). Prefer polling for the VM to reach Running (or for a stable hostid) before attempting the migrate.



##########
test/integration/smoke/test_nonstrict_affinity_group.py:
##########
@@ -362,6 +365,8 @@ def test_02_non_strict_host_affinity(self):
                          vm_12_host_id,
                          msg="Both VMs of affinity group %s are on the different host" % self.affinity_group.name)
 
+        time.sleep(10)
+

Review Comment:
   Same as above: a fixed sleep is a brittle way to wait for the VM to become migration-ready and unnecessarily increases suite runtime. Poll for the VM reaching Running (or another concrete readiness signal) before migrating.



##########
test/integration/smoke/test_events_resource.py:
##########
@@ -147,16 +147,25 @@ def test_01_events_resource(self):
             diskofferingid=self.disk_offering.id
         )
         self.cleanup.append(volume)
-        virtual_machine.attach_volume(
-            self.apiclient,
-            volume
-        )
+        try:
+            virtual_machine.attach_volume(
+                self.apiclient,
+                volume
+            )

Review Comment:
   Catching all exceptions and continuing (with `print` + `pass`) can turn real attach/detach failures into false positives and also makes the later detach/delete steps ambiguous. If attach is optional here, track whether it succeeded and only detach when attached; avoid `print` and log via the test logger/debug instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5004893539

   @blueorangutan test ubuntu26 vmware-80u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5002839443

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5003239714

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5003920460

   <b>[SF] Trillian Build Failed (tid-7)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5202884542

   moving to 4.22.2 milestone as it fixes smoke tests, not functionalities


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5718205902

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5719032223

   @weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + xcpng82) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5719024072

   @blueorangutan test ol9 xcpng82


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5239829337

   > > moving to 4.22.2 milestone as it fixes smoke tests, not functionalities
   > 
   > does it still need rebasing on 4.22, @weizhouapache ?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5836697181

   <b>[SF] Trillian test result (tid-49)</b>
   Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server u26
   Total time taken: 91199 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13628-n49-vmware-80u3.zip
   Smoke tests completed. 153 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 3698.26 | test_kubernetes_clusters.py
   test_13_test_add_external_nodes_to_cluster | `Failure` | 1009.38 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 1097.86 | test_kubernetes_clusters.py
   test_05_list_volumes_isrecursive | `Failure` | 0.06 | test_list_volumes.py
   test_07_list_volumes_listall | `Failure` | 0.05 | test_list_volumes.py
   test_list_vms_metrics_admin | `Error` | 3627.05 | test_metrics_api.py
   test_list_vms_metrics_history | `Error` | 8.74 | test_metrics_api.py
   test_list_volumes_metrics_history | `Error` | 3625.81 | test_metrics_api.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-5817077912

   <b>[SF] Trillian Build Failed (tid-48)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628#issuecomment-6337044143

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: fix smoke test failures on xen/vmware [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #13628:
URL: https://github.com/apache/cloudstack/pull/13628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org