[GitHub] [gobblin] aplex commented on a change in pull request #3285: [GOBBLIN-1446] Parse Whitespace in Curli Request from GaaS

[GitBox <gi...@apache.org>]

aplex commented on a change in pull request #3285:
URL: https://github.com/apache/gobblin/pull/3285#discussion_r635588580



##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigV2Client.java
##########
@@ -214,14 +216,24 @@ public FlowConfig getFlowConfig(FlowId flowId)
       String propertyFilter) throws RemoteInvocationException {
     LOG.debug("getAllFlowConfigs called");
 
-    FindRequest<FlowConfig> getRequest = _flowconfigsV2RequestBuilders.findByFilterFlows()
-        .flowGroupParam(flowGroup).flowNameParam(flowName).templateUriParam(templateUri).userToProxyParam(userToProxy)
-        .sourceIdentifierParam(sourceIdentifier).destinationIdentifierParam(destinationIdentifier).scheduleParam(schedule)
-        .isRunImmediatelyParam(isRunImmediately).owningGroupParam(owningGroup).propertyFilterParam(propertyFilter).build();
+    // the following parameters may contain white space
+    try {
+      String decodedSchedule = URLDecoder.decode(schedule, StandardCharsets.UTF_8.toString());

Review comment:
       Interesting. I would expect that rest.li framework will do url decoding for us automatically. Can we check that the clients are not double-encoding the urls? e.g. instead of encoding space to %20, we could possibly encode it twice to %2520, and then after decoding by restli it would still be %20.
   
   Also, if we don't see an issue on our side, I suggest to reach out to rest.li folks and ask them if we are supposed to do url decoding manually for finders. There could be some configuration setting that turns decoding on and off for the whole service, and it's not set to the expected value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org