You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/08 05:21:14 UTC
[GitHub] [doris] xiaokang opened a new pull request, #14061: [bug](ColumnDecimal)call set_decimalv2_type when cloning ColumnDecimal
xiaokang opened a new pull request, #14061:
URL: https://github.com/apache/doris/pull/14061
# Proposed changes
Issue Number: close #14060
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14061: [bug](ColumnDecimal)call set_decimalv2_type when cloning ColumnDecimal
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14061:
URL: https://github.com/apache/doris/pull/14061#issuecomment-1306711764
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.68 seconds
load time: 454 seconds
storage size: 17182819778 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221108064429_clickbench_pr_41759.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #14061: [bug](ColumnDecimal)call set_decimalv2_type when cloning ColumnDecimal
Posted by GitBox <gi...@apache.org>.
xiaokang commented on PR #14061:
URL: https://github.com/apache/doris/pull/14061#issuecomment-1307329886
> Could you also set `is_date` and `is_date_time` in `ColumnVector<T>::clone_resized` ?
@Gabriel39 , there is already a copy_date_types for `is_date` and `is_date_time`. But I'm not sure if it's right to check for Int64 before calling copy_date_types in ColumnVector.
be/src/vec/columns/column_vector.cpp
`
MutableColumnPtr ColumnVector<T>::clone_resized(size_t size) const {
auto res = this->create();
if constexpr (std::is_same_v<T, vectorized::Int64>) {
res->copy_date_types(*this);
}
// ...
`
be/src/vec/columns/column.h
`
void copy_date_types(const IColumn& col) {
if (col.is_date_type()) {
set_date_type();
}
if (col.is_datetime_type()) {
set_datetime_type();
}
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on pull request #14061: [bug](ColumnDecimal)call set_decimalv2_type when cloning ColumnDecimal
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on PR #14061:
URL: https://github.com/apache/doris/pull/14061#issuecomment-1307374550
>
Hi @xiaokang , I checked this logics and I think it works well. Thanks for reply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #14061: [bug](ColumnDecimal)call set_decimalv2_type when cloning ColumnDecimal
Posted by GitBox <gi...@apache.org>.
xiaokang commented on PR #14061:
URL: https://github.com/apache/doris/pull/14061#issuecomment-1307428620
Thanks for your comment @Gabriel39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14061: [bug](ColumnDecimal)call set_decimalv2_type when cloning ColumnDecimal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14061:
URL: https://github.com/apache/doris/pull/14061#issuecomment-1307377128
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #14061: [bug](ColumnDecimal)call set_decimalv2_type when cloning ColumnDecimal
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14061:
URL: https://github.com/apache/doris/pull/14061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org