You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "rpuch (via GitHub)" <gi...@apache.org> on 2025/05/07 13:57:15 UTC
[PR] IGNITE-25326 Throw exception when handling replica request for destroyed table [ignite-3]
rpuch opened a new pull request, #5776:
URL: https://github.com/apache/ignite-3/pull/5776
https://issues.apache.org/jira/browse/IGNITE-25326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25326 Throw exception when handling replica request for destroyed table [ignite-3]
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch merged PR #5776:
URL: https://github.com/apache/ignite-3/pull/5776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25326 Throw exception when handling replica request for destroyed table [ignite-3]
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #5776:
URL: https://github.com/apache/ignite-3/pull/5776#discussion_r2077804245
##########
modules/partition-replicator/src/test/java/org/apache/ignite/internal/partition/replicator/ZonePartitionReplicaListenerTest.java:
##########
@@ -78,8 +98,8 @@ class ZonePartitionReplicaListenerTest extends BaseIgniteAbstractTest {
@Mock
private ValidationSchemasSource validationSchemasSource;
- @Mock
- private SchemaSyncService schemaSyncService;
+ @Spy
+ private final SchemaSyncService schemaSyncService = new AlwaysSyncedSchemaSyncService();
Review Comment:
`@Spy` does. It recreates the nesting object (test class object), if I'm not mistaken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25326 Throw exception when handling replica request for destroyed table [ignite-3]
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #5776:
URL: https://github.com/apache/ignite-3/pull/5776#discussion_r2077790485
##########
modules/partition-replicator/src/test/java/org/apache/ignite/internal/partition/replicator/ZonePartitionReplicaListenerTest.java:
##########
@@ -78,8 +98,8 @@ class ZonePartitionReplicaListenerTest extends BaseIgniteAbstractTest {
@Mock
private ValidationSchemasSource validationSchemasSource;
- @Mock
- private SchemaSyncService schemaSyncService;
+ @Spy
+ private final SchemaSyncService schemaSyncService = new AlwaysSyncedSchemaSyncService();
Review Comment:
Interesting, Mockito annotations work on final variables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org