You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by chenliang613 <gi...@git.apache.org> on 2016/10/22 10:57:28 UTC
[GitHub] incubator-carbondata pull request #255: CARBONDATA-336 Align the the name de...
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/255
CARBONDATA-336 Align the the name description
Align the the name description for databaseNameOp and tableName.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenliang613/incubator-carbondata align_name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/255.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #255
----
commit 5644320801425d87b44758a0e8735e5e0d9dc27d
Author: chenliang613 <ch...@apache.org>
Date: 2016-10-22T10:51:16Z
CARBONDATA-336 Align the the name description
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #255: CARBONDATA-336 Align the the name de...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #255: CARBONDATA-336 Align the the name de...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/255#discussion_r84578556
--- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
@@ -926,14 +926,14 @@ class CarbonSqlParser()
(INTO ~> TABLE ~> (ident <~ ".").? ~ ident) ~
(OPTIONS ~> "(" ~> repsep(loadOptions, ",") <~ ")").? <~ opt(";") ^^ {
case filePath ~ isOverwrite ~ table ~ partionDataOptions =>
- val (schema, tablename) = table match {
+ val (databaseNameOp, tableName) = table match {
--- End diff --
1. Why add "Op", because this is option[], so all places using the below :
case class LoadTable(
databaseNameOp: Option[String],
tableName: String,
2.Using options.dbName to get databaseName.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #255: CARBONDATA-336 Align the the name de...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/255#discussion_r84578283
--- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
@@ -926,14 +926,14 @@ class CarbonSqlParser()
(INTO ~> TABLE ~> (ident <~ ".").? ~ ident) ~
(OPTIONS ~> "(" ~> repsep(loadOptions, ",") <~ ")").? <~ opt(";") ^^ {
case filePath ~ isOverwrite ~ table ~ partionDataOptions =>
- val (schema, tablename) = table match {
+ val (databaseNameOp, tableName) = table match {
--- End diff --
change to databaseName
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #255: CARBONDATA-336 Align the the name de...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/255#discussion_r84699713
--- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
@@ -926,14 +926,14 @@ class CarbonSqlParser()
(INTO ~> TABLE ~> (ident <~ ".").? ~ ident) ~
(OPTIONS ~> "(" ~> repsep(loadOptions, ",") <~ ")").? <~ opt(";") ^^ {
case filePath ~ isOverwrite ~ table ~ partionDataOptions =>
- val (schema, tablename) = table match {
+ val (databaseNameOp, tableName) = table match {
case databaseName ~ tableName => (databaseName, tableName.toLowerCase())
}
if(partionDataOptions.isDefined) {
validateOptions(partionDataOptions)
}
val patitionOptionsMap = partionDataOptions.getOrElse(List.empty[(String, String)]).toMap
- LoadTable(schema, tablename, filePath, Seq(), patitionOptionsMap, isOverwrite.isDefined)
+ LoadTable(databaseNameOp, tableName, filePath, Seq(), patitionOptionsMap, isOverwrite.isDefined)
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---