You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/09/17 09:07:50 UTC
[GitHub] [incubator-brpc] chenBright opened a new pull request, #1927: http response uses brpc error code
chenBright opened a new pull request, #1927:
URL: https://github.com/apache/incubator-brpc/pull/1927
背景：
目前brpc上游收到http回包后，会将http异常状态码归结为EHTTP这个错误码。如果下游限流了，brpc上游也不会重试，因为brpc不会对EHTTP这个错误码进行重试，即使下游是brpc框架实现的。
实现：
brpc上游将下游回的x-bd-error-code这个header设置为error code。如果下游通过x-bd-error-code回了ELIMIT，brpc上游就会重试。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm merged pull request #1927: http response uses brpc error code
Posted by GitBox <gi...@apache.org>.
wwbmmm merged PR #1927:
URL: https://github.com/apache/incubator-brpc/pull/1927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] chenBright commented on pull request #1927: http response uses brpc error code
Posted by GitBox <gi...@apache.org>.
chenBright commented on PR #1927:
URL: https://github.com/apache/incubator-brpc/pull/1927#issuecomment-1252265327
> 这个可能会影响对现有用户代码的兼容性，要不加个gflag控制一下？
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1927: http response uses brpc error code
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on PR #1927:
URL: https://github.com/apache/incubator-brpc/pull/1927#issuecomment-1250479428
这个可能会影响对现有用户代码的兼容性，要不加个gflag控制一下？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] chenBright commented on pull request #1927: http response uses brpc error code
Posted by GitBox <gi...@apache.org>.
chenBright commented on PR #1927:
URL: https://github.com/apache/incubator-brpc/pull/1927#issuecomment-1256855408
> CI单测挂了。加了gflag之后，原来的单测应该不用改了，可以加个专门针对这个gflag的单测 @chenBright
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] chenBright commented on pull request #1927: http response uses brpc error code
Posted by GitBox <gi...@apache.org>.
chenBright commented on PR #1927:
URL: https://github.com/apache/incubator-brpc/pull/1927#issuecomment-1256855895
@wwbmmm 加单测了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1927: http response uses brpc error code
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on PR #1927:
URL: https://github.com/apache/incubator-brpc/pull/1927#issuecomment-1253126854
CI单测挂了。加了gflag之后，原来的单测应该不用改了，可以加个专门针对这个gflag的单测 @chenBright
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] chenBright closed pull request #1927: http response uses brpc error code
Posted by GitBox <gi...@apache.org>.
chenBright closed pull request #1927: http response uses brpc error code
URL: https://github.com/apache/incubator-brpc/pull/1927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org