You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by PCStefan <gi...@git.apache.org> on 2016/06/06 12:01:15 UTC
[GitHub] incubator-taverna-databundle-viewer pull request #3: Provenance Viewer for T...
GitHub user PCStefan opened a pull request:
https://github.com/apache/incubator-taverna-databundle-viewer/pull/3
Provenance Viewer for Taverna
This is my first pull request.
For the next I am going to redo it, The new version will have implemented the taverna server and a ontology datastore which will speed up the entire process.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PCStefan/incubator-taverna-databundle-viewer master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-taverna-databundle-viewer/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 94ddf9b964047be165659f951f642872c9174332
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:48:39Z
Add files via upload
commit 7dddbeb48ca8d9a651cf2377e590417e0fa11f17
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:51:05Z
Add files via upload
commit 672194226f3cd2dfa273772ff114a50e1e44ef75
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:51:44Z
Add files via upload
commit 043417a9318fdc6848f4a33b3621c61742791240
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:52:23Z
Add files via upload
commit 590ee9998fc452cd106c7829dafe97cd0682e24c
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:52:48Z
Add files via upload
commit 5f01fa1c2a98a73c6a1db1c4dfcf87e57bc04c5b
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:53:05Z
Add files via upload
commit 877aa41be15534a0a51fb4ed63dcb816dec8778b
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:53:31Z
Add files via upload
commit 7421fc777f847dd694db7f88847ca458b997c3e6
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:53:49Z
Add files via upload
commit defd6df0b2c112cc57b29b309b9dbe31d78acd36
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:54:16Z
Add files via upload
commit 380bdcfaa78a00792205b2514725295fb3fba2fc
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:54:40Z
Add files via upload
commit e3ac7c23d60d7d98ca67506042ee0264b29b6021
Author: PCStefan <pa...@gmail.com>
Date: 2016-06-06T11:56:10Z
Add files via upload
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-databundle-viewer issue #3: Provenance Viewer for Taverna
Posted by d3noob <gi...@git.apache.org>.
Github user d3noob commented on the issue:
https://github.com/apache/incubator-taverna-databundle-viewer/pull/3
Perfect! Thanks @stain You got it spot on. Only the index.html file is mine. Also many thanks for the licence clarification. You are correct the [CC0 ](https://creativecommons.org/choose/zero/)licence seems to fit well with my intentions. Cheers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-taverna-databundle-viewer pull request #3:
Provenance Viewer for T...
Posted by Stian Soiland-Reyes <st...@apache.org>.
Now merged.
It seems comments on the github pull request on this repository was
not being forwarded to the list..
I've raised this with INFRA - https://issues.apache.org/jira/browse/INFRA-12163
which seems now to be solved.
See https://github.com/apache/incubator-taverna-databundle-viewer/pull/3
for discussion.
In summary: Stefan has added a provenance viewer feature to the
databundle, including a graphical view. He has already signed ICLA.
There were some uncertainty of the licensing of sankey.js which was
then clarified with help from some of the original authors.
On 23 June 2016 at 09:53, asfgit <gi...@git.apache.org> wrote:
> Github user asfgit closed the pull request at:
>
> https://github.com/apache/incubator-taverna-databundle-viewer/pull/3
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718
[GitHub] incubator-taverna-databundle-viewer pull request #3: Provenance Viewer for T...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-taverna-databundle-viewer/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-databundle-viewer issue #3: Provenance Viewer for Taverna
Posted by stain <gi...@git.apache.org>.
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-databundle-viewer/pull/3
I found that the content of @PCStefan's [sankey.js](https://github.com/PCStefan/incubator-taverna-databundle-viewer/blob/master/app/assets/javascripts/sankey.js) almost matched https://github.com/kunalb/d3-plugins/blob/sankey/sankey/sankey.js (particularly the - so I've added @kunalb to the (c).
Thanks all! Now we know why it's cool to add those license headers in advance..
I'm adding:
```javascript
// Copyright (c) 2012-2015, Michael Bostock,
// Nathan Malkin, Kunal Bhalla, Claudiu Stefan Padurariu
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are met:
//
// * Redistributions of source code must retain the above copyright notice, this
// list of conditions and the following disclaimer.
//
// * Redistributions in binary form must reproduce the above copyright notice,
// this list of conditions and the following disclaimer in the documentation
// and/or other materials provided with the distribution.
//
// * The name Michael Bostock may not be used to endorse or promote products
// derived from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
// DISCLAIMED. IN NO EVENT SHALL MICHAEL BOSTOCK BE LIABLE FOR ANY DIRECT,
// INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
// BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
// NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
// EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
```
and to LICENSE:
```
---------------------------------------------------
app/assets/javascripts/sankey.js is licensed as BSD-3 clause
https://github.com/d3/d3-plugins/blob/master/LICENSE
---------------------------------------------------
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---